Skip to content

test(actions): remove retired steward contract - #145

Closed
seonghobae wants to merge 1 commit into
mainfrom
codex/remove-retired-hourly-steward-tests
Closed

test(actions): remove retired steward contract#145
seonghobae wants to merge 1 commit into
mainfrom
codex/remove-retired-hourly-steward-tests

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

원인

중앙 required workflows로 PR 운영을 통합한 #144가 repo-local .github/workflows/hourly-pr-steward.yml을 제거했지만, 삭제된 workflow의 정적 계약 테스트는 main에 남았습니다. 그 결과 unrelated PR의 merge ref에서도 account-unification suite가 5건의 FileNotFoundError로 실패했습니다.

수정

목적을 마친 self-modifying workflow의 잔여 테스트 한 파일만 제거했습니다. workflow를 복원하거나 중앙 owner 경계를 우회하지 않습니다.

검증

  • exact base: 100917dba555531bdaad0db3780da80686e237d8
  • exact head: 239e362c95d48894a10841ec8a087f9107f3f90c
  • uv run --python 3.12 pytest -q services/account_unification/tests 통과
  • git diff --check 통과

이 PR이 보호 병합된 뒤 Keyverse #128을 non-force로 최신 main에 restack하고 exact-head 검증을 다시 받습니다.

Summary by CodeRabbit

  • 테스트
    • 시간별 실행, 동시성 제한, 읽기 전용 권한, 신뢰·검사 조건, 브랜치 업데이트 검증 및 자동 병합 대상 검증을 확인하던 정적 계약 테스트가 제거되었습니다.

@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 4fb71829-b2f7-4d5f-928e-6a0597c34cd6

📥 Commits

Reviewing files that changed from the base of the PR and between 100917d and 239e362.

📒 Files selected for processing (1)
  • services/account_unification/tests/test_hourly_pr_steward.py
💤 Files with no reviewable changes (1)
  • services/account_unification/tests/test_hourly_pr_steward.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

시간별 PR 스튜어드의 정적 계약 테스트 파일 전체를 삭제했습니다. 관련 헬퍼와 다섯 개의 테스트 함수도 함께 제거했습니다.

Changes

Cohort / File(s) Summary
시간별 PR 스튜어드 테스트 삭제
services/account_unification/tests/test_hourly_pr_steward.py
시간별 실행, 동시성, 읽기 전용 권한, fail-closed 검증, 브랜치 업데이트 후 검증 무효화, 확인된 head SHA 대상 자동 병합을 검사하던 테스트와 헬퍼를 삭제했습니다.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 239e3

This removes the stale test for a retired workflow, eliminating its file-not-found failures without changing centralized workflow ownership or runtime behavior. No merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 폐기된 steward 계약 테스트를 제거한다는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/remove-retired-hourly-steward-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

이 삭제는 #146의 현재 head 에 포함되어 전체 중앙 dispatch 및 orchestrator/free 전환과 함께 검증됩니다. 중복 Checks를 줄이기 위해 superseded로 닫습니다.

@seonghobae seonghobae closed this Sep 4, 2026
@seonghobae

Copy link
Copy Markdown
Contributor Author

정정: 삭제 내용은 #146의 현재 head ea34fdf07fac57a374103f998431c816a9e1a9b6에 포함되어 전체 중앙 dispatch 및 orchestrator/free 전환과 함께 검증됩니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant