refactor(naming): use semantic command helper name - #133
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Repair an organization-owned naming defect in Keyverse's autonomous product guard without changing its security or publication behavior.
Protected base re-fetched immediately before the repair:
main@2e00633e5485905ecc608708eb9f57e2779ea5e2.TDD / exact lineage
85b1fa5fe86336a546ac5fe0c7bba6ff481333ce: require the repository-owned guard to expose_run_commandand not_run.5efd4ec2e6d049ef3f2bece136beb7d3ba0e1e72: rename_run→_run_command, rename its generic first parameterargs→command_arguments, and propagate every repository-local caller.The branch is two commits ahead and zero behind the unchanged protected base; only
scripts/ci/hourly_product_guard.pyandservices/account_unification/tests/test_hourly_product_guard.pychange.Boundary / compatibility
Python
subprocess.runkeywords such ascwd,env,check, andtextremain exactly as required at the stdlib adapter boundary. No CLI command, workflow input/output, patch/proposal schema, API, event, database table/column/index/constraint, persisted value, secret flow, or external protocol field changes. No migration or rollback data transform is required.This is an internal ubiquitous-language repair: the helper owns trusted command execution, so
_run_command(command_arguments, ...)is the bounded semantic name; external/vendor spellings remain at their boundary.Merge gate
Keep Draft until fresh exact-head verification is terminal-success and a qualifying independent non-author approval applies to the unchanged last push. Do not reuse predecessor-head evidence, self-approve, force-push, or bypass protection.