Skip to content

docs(agents): preserve maintenance evidence lessons - #410

Open
seonghobae wants to merge 4 commits into
mainfrom
codex/maintenance-evidence-lessons
Open

docs(agents): preserve maintenance evidence lessons#410
seonghobae wants to merge 4 commits into
mainfrom
codex/maintenance-evidence-lessons

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Scope

Add concise, reusable field notes to AGENTS.md at the user's request. Preserve every existing authority, work-conserving maintenance and code-owner policy paragraph unchanged. No product/runtime/workflow/dependency/release change and no replacement of the existing CLAUDE.md.

The notes cover immutable acquisition heads, exact packed artifacts, retained failed attempts, skipped chained commands, expired process handles, serial heavy acquisition under contention, actual host-composition visual inspection, canonical source ownership, and secret-safe release acceptance. Package commands are checked against the current manifest and separate browser lock; commit attribution must remain accurate.

Keep future lessons short and repository-specific. Detailed logs belong in bounded evidence records; no transient SHAs, run IDs, test counts, secrets or scheduler history are added to AGENTS.md.

Follow-up adds one browser-teardown lesson: capture completed/pending public requests before closing a failed page, distinguish that observation from internal network-idle state, and retain the external-request guard without speculative blame. A native assertion verified that this single added line leaves all previous guidance byte-identical. The bounded diagnostic behind the lesson is recorded with existing browser owner #380; no product fix or acceptance claim is added here.

Verification

  • Follow-up head0c69908a adds one dependency-provenance lesson after the installed Playwright module matched the exact registry module. Native assertions proved all prior guidance byte-identical after removing that single new line; whitespace checks passed. This does not claim an upstream fix or full acceptance.

  • Native Node assertions passed: the complete existing authority suffix is byte-identical; each added section occurs once; all documented pnpm scripts and the separate browser lock exist; visual/failed-command/secret-access boundaries are present; only AGENTS.md changed.

  • git diff --check passed. Normal signed-off commit; no force, amend, reset, self-approval or policy bypass.

  • Base is protected main at0b88c16f14f51b54a87eb7164f0edfb06dd60902. A complete live open-PR file inventory found no existing AGENTS.md writer before this branch was created.

  • This is scoped documentation verification, not full unit/browser/Office or hosted acceptance.

Automatic publication boundary

The user authorized automatic deployment when feasible. The protected release workflow currently publishes npm and PyPI through OIDC, not a new token fallback. There is no protected Rust crate to publish. Repository-level secret listing returned zero entries; organization listing was denied, so organization-secret availability is unverified rather than absent. No credential values were read or copied.

At the read-only inspection, the current protected main had four failed Office checks and the existing Office repair remained unmerged. No tag, registry publication or release was attempted. Issue #118 and then-current protected release acceptance remain the authority; the existence of keys does not bypass those gates.

Summary by CodeRabbit

  • 문서
    • 패키지 관리자 버전 및 잠금 파일 사용 지침을 추가했습니다.
    • 커밋 기여자 표기와 허위 기여 방지 규정을 명확히 했습니다.
    • 유지보수, 브라우저 오류 진단, 릴리스 워크플로 준수 등 운영 지침을 보강했습니다.
    • 외부 에이전트 스크래치 데이터와 설치 검증 범위를 구체화했습니다.

Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 84833f1e-3fb8-436f-8c73-cb319d25a5a9

📥 Commits

Reviewing files that changed from the base of the PR and between 77b761a and f5288e4.

📒 Files selected for processing (1)
  • AGENTS.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • AGENTS.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

AGENTS.md에 패키지 관리자 사용, 커밋 귀속, 유지보수 기록, 브라우저 진단 및 릴리스 검증 지침을 추가했습니다.

Changes

저장소 운영 지침

Layer / File(s) Summary
개발 및 유지보수 지침
AGENTS.md
체크인된 pnpm과 잠금 파일 사용 규칙을 추가했습니다. 정확한 Co-Authored-By 귀속과 허구의 기여 금지를 규정했습니다. 증거 수집, 실패 진단, 편집기 검사, 결함 라우팅, 브라우저 종료, 보호된 릴리스 워크플로 지침을 추가했습니다.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to f5288

This documentation-only change adds maintenance guidance without identified runtime, release, dependency, or product behavior risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 AGENTS.md에 재사용 가능한 유지보수 교훈을 추가하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/maintenance-evidence-lessons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae seonghobae added documentation Improvements or additions to documentation priority: medium Normal-priority or P2 work type: docs Documentation, ADR, PRD, or technical writing labels Sep 7, 2026 — with ChatGPT Codex Connector
seonghobae and others added 3 commits September 7, 2026 13:22
Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>
Co-Authored-By: Codex <noreply@openai.com>
Signed-off-by: Seongho Bae <me@seonghobae.me>

@cwl-noema-review cwl-noema-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noema LLM review

Documentation-only change to AGENTS.md adding maintainer field notes, package manager usage, commit attribution, and release acceptance guidance. No executable or dependency changes. The new sections are internally consistent with existing authority guidance. Two probes falsified regression hypotheses: no executable changes and no contradictions.

Reviewed changed lines

  • AGENTS.md:3 (RIGHT): Added 'Package manager' section is accurate for a pnpm-based repo and uses standard frozen-lockfile workflows. No mismatch with existing AGENTS.md content.
  • AGENTS.md:4 (RIGHT): Guidance to keep browser dependencies under separate lock is consistent with repo structure and does not alter behavior.
  • AGENTS.md:5 (RIGHT): Commit attribution rule ensures accurate credit, no change to Git behavior.
  • AGENTS.md:6 (RIGHT): Prohibiting invented attribution is good practice, no regression.
  • AGENTS.md:7 (RIGHT): Maintainer field notes guidance is concise and links to external references; no executable impact.
  • AGENTS.md:8 (RIGHT): Rule to avoid accumulating transient data is maintainability improvement.
  • AGENTS.md:9 (RIGHT): Freezing sources and record evidence is process guidance only.
  • AGENTS.md:10 (RIGHT): Distinguishing failed attempts from full acceptance is clear and actionable.
  • AGENTS.md:11 (RIGHT): Serializing heavy builds under contention is sensible operational advice.
  • AGENTS.md:12 (RIGHT): Inspecting packed editor in host composition is thorough testing guidance.
  • AGENTS.md:13 (RIGHT): Geometry assertions are not sufficient for full acceptance is a valid note.
  • AGENTS.md:14 (RIGHT): Routing shared defects to source owner avoids duplicate fixes.
  • AGENTS.md:15 (RIGHT): Keeps inherited repairs and evidence, no contradiction.
  • AGENTS.md:16 (RIGHT): Scoping ignores to checkout root is a clear operational rule.
  • AGENTS.md:17 (RIGHT): Verifying ignore boundary with git check-ignore is concrete and correct.
  • AGENTS.md:18 (RIGHT): Capturing request counts before teardown is diagnostic guidance.
  • AGENTS.md:19 (RIGHT): Zero outstanding requests does not prove idle state is a valid caveat.
  • AGENTS.md:20 (RIGHT): Comparing pinned module with registry artifact is proper diagnosis.
  • AGENTS.md:21 (RIGHT): Keeping private state probes diagnostic-only is safe practice.
  • AGENTS.md:22 (RIGHT): Release acceptance guidance aligns with existing issue and workflow.

Adversarial validation

  • AGENTS.md:3 (RIGHT) falsified: The added documentation could introduce an executable or dependency change that breaks CI or package management. — The diff touches only AGENTS.md and adds prose. No source, test, or config files are changed; therefore no behavioral regression is possible.
  • AGENTS.md:7 (RIGHT) falsified: The new maintainer field-notes guidance could contradict the existing canonical product and architecture authority section, leading to conflicting instructions. — The added lines complement the existing section and do not introduce conflicting instructions. Both encourage following established processes. No contradictions found.
  • Residual risk: Low; documentation-only, no behavioral impact expected.

Findings

  • No blocking findings.
  • Result: APPROVE
  • Head SHA: f5288e44e9be5b3d17303824900d763db508b501
  • Reviewer credential: noema-review-github-app-refresh
  • Actor: cwl-noema-review[bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation priority: medium Normal-priority or P2 work type: docs Documentation, ADR, PRD, or technical writing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant