feat(diagnostics): add collaborative writing-guidance parity - #281
Draft
seonghobae wants to merge 35 commits into
Draft
feat(diagnostics): add collaborative writing-guidance parity#281seonghobae wants to merge 35 commits into
seonghobae wants to merge 35 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…actions' into feat/writing-diagnostics-collaboration Signed-off-by: Seongho Bae <me@seonghobae.me>
Contributor
Author
|
#281 was restacked onto the current #280 head b415d36. Exact head: 37203e6 Verification on that tree:
Checks are queued before runner assignment. @codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…actions' into feat/writing-diagnostics-collaboration
…actions' into feat/writing-diagnostics-collaboration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack authority
This Draft is the existing collaborative writing-diagnostics parity lane stacked on current #280
feat/writing-diagnostics-editor-actions@d8749ec18578b256d36b8dc52ba0eb5bbe1b5a29. Current exact head isfeat/writing-diagnostics-collaboration@14a01a8c95b4dcdc14bbcb04c4c5ed0476a857ba. Protected shipped truth remainsmain@3b38ead2d00f44eb578d0689087b9293b3dabe1e; release issue #118 continues to freezev0.6.0publication.The parent-only Semgrep-classification repair in
src/components/CwlEditor.writingDiagnosticApply.test.tsxwas synchronized non-destructively into this existing branch. Fresh comparison resolves merge base exactly to current #280 and reports this branch ahead 32 / behind 0; this lane's effective child delta remains its seven collaboration/workflow paths. Earlier synchronization SHAs and their evidence are predecessor lineage only.Included behavior
This lane provides collaborative parity for already-verified host diagnostics: host-supplied props, accessible guidance panel and imperative Focus / Apply / Ignore / Dismiss / Explain methods; exact strong-revision verification before local Apply; plain-text replacement through an ordinary collaborative ProseMirror/Yjs transaction; immediate stale-all invalidation for local or remote changes; two-client convergence and collaborative undo/redo; no fabricated remote action events; read-only Apply prevention; stable editor identity/latest callback ownership; race rejection when remote updates arrive during verification or pending Apply digest; awareness privacy; and host ownership of supplied
Y.Doclifecycle.Inkspan performs no semantic inference and calls no LLM/model provider/network reviewer/database/persistence service. Diagnostic identifiers, titles, explanations, replacements, revisions, provenance and authored text are not written into awareness state.
Exact-current-head evidence
At the latest pre-write refetch:
14a01a8c95b4dcdc14bbcb04c4c5ed0476a857ba;d8749ec18578b256d36b8dc52ba0eb5bbe1b5a29and is the merge base;Waiting for the existing stacked-PR CI owner path (#298/#299) blocks only this evidence lane. #282 owns the framework-independent package subpath.
Integration boundary
Keep Draft behind #280. Before any lifecycle transition independently refetch current parent/head ancestry, live governance, all applicable exact-head workflows, formal reviews and threads, then respect #118's protected release boundary. Pending/queued/skipped/cancelled/absent/neutral/failed/stale/predecessor/status-only/model-only evidence is non-passing. Do not self-approve, force-push, destructively rebase, transfer predecessor evidence, weaken gates, create a tag/release, claim host semantic/model authority, or add transport/persistence/credential/model authority.