Skip to content

reliability: bound ignored Rust subprocess deadlines - #740

Merged
seonghobae merged 17 commits into
mainfrom
fix/ignored-rust-subprocess-deadlines
Aug 11, 2026
Merged

reliability: bound ignored Rust subprocess deadlines#740
seonghobae merged 17 commits into
mainfrom
fix/ignored-rust-subprocess-deadlines

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Why

Ignored Rust statistical-study shards and Cargo metadata lookups can hang without process-group cleanup. This lands bounded, operation-specific deadlines with fail-closed timeout evidence.

What

  • scripts/_subprocess_deadlines.py and ignored Rust shard runner integration
  • POSIX process-group reaping (SIGTERM→SIGKILL)
  • Tests for edges, group leak, and ignored-shard timeouts
  • APA doctoring + changelog fragment

Rebased onto current main with re-rendered CHANGELOG (reopens closed #578 work).

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: cc497605-c0e7-4e2a-9d29-460aae73eaf8

📥 Commits

Reviewing files that changed from the base of the PR and between d8412c1 and d7f82f5.

📒 Files selected for processing (11)
  • CHANGELOG.md
  • docs/changelog.d/555-operation-specific-subprocess-deadlines.md
  • docs/doctoring/operation-specific-subprocess-deadlines.md
  • docs/superpowers/plans/2026-08-09-ignored-rust-subprocess-deadlines.md
  • scripts/_subprocess_deadlines.py
  • scripts/run_ignored_rust_shard.py
  • tests/test_ignored_rust_subprocess_deadlines.py
  • tests/test_subprocess_deadline_bounded_reap.py
  • tests/test_subprocess_deadline_edges.py
  • tests/test_subprocess_deadline_process_group_leak.py
  • tests/test_subprocess_deadlines.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as draft August 11, 2026 16:38
After SIGTERM/SIGKILL, communicate with PROCESS_REAP_TIMEOUT_SECONDS so a
stuck child cannot hang the parent. Align deadline tests with the bounded
reap contract from the fail-first cleanup regression.
@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 16:54
@seonghobae
seonghobae merged commit 98157ff into main Aug 11, 2026
34 checks passed
@seonghobae
seonghobae deleted the fix/ignored-rust-subprocess-deadlines branch August 11, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant