Skip to content

test(config): reject unsupported bifactor JMLE during preflight - #711

Closed
seonghobae wants to merge 2 commits into
mainfrom
test/bifactor-jmle-config-red-643
Closed

seonghobae wants to merge 2 commits into
mainfrom
test/bifactor-jmle-config-red-643

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Fail-first slice for #643

Protected main at branch creation: 56967deceafeb7ecd0ff08a98f196282a6ec81a3.

The public FitConfig currently advertises both jmle and mmle for every VALID_MODELS identity, while BIFAC2PLM + jmle is not an implemented fitting path. This Draft adds only the smallest intentional RED at configuration validation:

  • BIFAC2PLM + jmle must raise a bounded ValueError during FitConfig.validate() and identify mmle as the supported estimator;
  • BIFAC2PLM + mmle remains valid.

The current protected implementation is expected to fail the first test because validation accepts the unsupported pair. Setup/import/fixture/changelog failures are not valid RED.

After exact-head CI proves that boundary, implement the narrowest compatibility policy in python/fast_mlsirm/config.py, add the complete current VALID_MODELS × VALID_ESTIMATORS compatibility matrix, remove or demote any normal-path late NotImplementedError, preserve all implemented JMLE/MMLE numerics, add authoritative changelog/doctoring, and run all required same-head gates. Do not widen into a new bifactor JMLE estimator, numerical formulas, dependencies/workflows, release/version work, or canonical #604 documentation.

Keep Draft until RED→GREEN history and current-head review/gates are complete. Advances #643.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e346783c-32cb-497b-8ab6-8af9aa7ab161

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Superseded: BIFAC2PLM+JMLE fail-closed at FitConfig.validate restored on main via #713 (test_model_estimator_compatibility).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant