Skip to content

test(reliability): bound release-index Git metadata lookup - #708

Merged
seonghobae merged 2 commits into
mainfrom
fix/release-evidence-git-metadata-timeout-20260811
Aug 11, 2026
Merged

test(reliability): bound release-index Git metadata lookup#708
seonghobae merged 2 commits into
mainfrom
fix/release-evidence-git-metadata-timeout-20260811

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Reliability defect

Protected main aa5e84963e428aaa8c2900138bb36b07b8d649a7 bounds git rev-parse HEAD in several release/evidence builders through #704, but scripts/build_release_evidence_index.py::_source_commit still invokes Git with no timeout and maps all exceptions to unknown. Because this index is part of acquisition/release evidence, a hung local Git child can still stall the evidence pipeline indefinitely.

Intentional RED

Exact test-only head: 2b817e9889ed37ce75d63fffbefdfd44a34d949a, directly based on the protected head above.

tests/test_release_evidence_git_metadata_timeout.py substitutes a deterministic subprocess.TimeoutExpired and requires _source_commit to pass a package-owned deadline and fail closed with stable non-reflective RuntimeError("source commit lookup timed out").

The current implementation has no GIT_METADATA_TIMEOUT_SECONDS and no timeout=, so this is expected RED at the production boundary rather than setup/import/fixture failure.

Minimum GREEN after RED proof

  • add the same short named Git metadata deadline used by sibling evidence builders;
  • pass it to this git rev-parse HEAD call;
  • catch subprocess.TimeoutExpired before the generic fallback and raise the stable timeout error;
  • preserve ordinary non-timeout Git-unavailable fallback behavior unless focused evidence proves a stronger contract;
  • add only meaningful branch/docstring/changelog evidence required by repository policy;
  • run focused release-index tests, then full applicable CI/Security/SAST on one unchanged head.

No release-evidence schema semantics, artifact hashes, dependencies/workflows/version/release, numerical code, or canonical #604/#621 documentation belongs in this slice.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 12cae3a0-19ca-46ea-8390-e10cb8236dcb

📥 Commits

Reviewing files that changed from the base of the PR and between d2301dc and 9c2f965.

📒 Files selected for processing (3)
  • docs/changelog.d/708-release-evidence-git-metadata-timeout.md
  • scripts/build_release_evidence_index.py
  • tests/test_release_evidence_git_metadata_timeout.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

seonghobae added a commit that referenced this pull request Aug 11, 2026
@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 08:34
@seonghobae
seonghobae force-pushed the fix/release-evidence-git-metadata-timeout-20260811 branch from aaab3af to 682f0ce Compare August 11, 2026 08:36

Copy link
Copy Markdown
Contributor Author

Superseded by clean current-main replacement #715. This PR preserves the original fail-first lineage and predecessor-head evidence, but its source head 682f0cecb8225fef37d0095967a9d07facab5711 is based on protected main c8c834ed... and no longer carries current-base acceptance. #715 was rebuilt directly from protected main d2301dcc... with only the three bounded release-index timeout paths. Checks/reviews do not transfer; merge only the replacement after its own exact-head/current-base gates.

@seonghobae seonghobae closed this Aug 11, 2026
Fail closed when git rev-parse hangs during release evidence indexing.
@seonghobae seonghobae reopened this Aug 11, 2026
@seonghobae
seonghobae force-pushed the fix/release-evidence-git-metadata-timeout-20260811 branch from 88e307e to 8d5747f Compare August 11, 2026 08:44
@seonghobae
seonghobae merged commit 640de7d into main Aug 11, 2026
32 of 33 checks passed
@seonghobae
seonghobae deleted the fix/release-evidence-git-metadata-timeout-20260811 branch August 11, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant