Repository navigation
fix(changelog): render pending fragments and fail CI on block drift (#2289) - #2355
Open
seonghobae wants to merge 1 commit into
Open
seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2289. Covers part 2 of #2127.
Problem
On main (a0d7958),
python scripts/render_changelog_fragments.py --check CHANGELOG.mdexits 1 because the authoritative block is stale. Four fragments indocs/changelog.d/were never rendered: license-evidence-0.11.5, fail-closed-allowlist-ci-lanes, release-source-checkout-authority and semgrep-red-gate. Main has no hand-written duplicate license heading, so the fragment text is authoritative as-is.Change
--update. That added 88 lines, all inside the marker block. The text above the block and every released section are byte-identical.python-matrixjob inci.ymlnow runspython scripts/render_changelog_fragments.py --check CHANGELOG.mdright after setup-python. The step uses the stdlib only and adds no new job, permission or action.--checkand is replaced, not kept and not stripped. This is test(changelog): cover the empty-inventory marker-stripping branch in render_changelog_fragments.py #2127 part 2.####heading appears once under each. That matches the renderer's existing behaviour.Verification (local)
--check: exit 1 before the change, exit 0 after.tests/test_changelog_fragment_contract.py: 13 passed. Before the fix it was 2 failed, 11 passed.--checknever fails; the CI step is removed; main's stale CHANGELOG is restored.actionlint .github/workflows/ci.yml: exit 0.Not in this PR
#2127 part 1 (an empty inventory strips the markers) depends on the code from #2126, which is still open, and should follow once it merges.