🎨 Palette: Improve pointer focus outline suppression using :not(:focus-visible) - #1309
seonghobae wants to merge 2 commits into
Conversation
Replaces `:focus` with `:focus:not(:focus-visible)` when suppressing outlines on semantic containers (like `main`, `.table-wrap`, and `.export-block pre`). This ensures mouse clicks do not trigger outlines, while preserving a fallback focus indicator for keyboard users on older browsers that do not support `:focus-visible`. Update the relevant unit tests to match and document the learning.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Replaces `:focus` with `:focus:not(:focus-visible)` when suppressing outlines on semantic containers (like `main`, `.table-wrap`, and `.export-block pre`). This ensures mouse clicks do not trigger outlines, while preserving a fallback focus indicator for keyboard users on older browsers that do not support `:focus-visible`. Update the relevant unit tests to match and document the learning.
|
Closing this unmerged as a duplicate report-accessibility writer. Fresh comparison against current PR #1002 ( |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
💡 What
Replaced
:focus { outline: none; }with:focus:not(:focus-visible) { outline: none; }on semantic containers (main,.table-wrap, and.export-block pre).🎯 Why
Using
:focus { outline: none; }completely removes the outline for all focus states if a browser does not support:focus-visible. Using:not(:focus-visible)ensures that we suppress outlines for mouse users while providing a safe fallback that keeps the default outline for keyboard users in older browsers.📸 Before/After
No visual change for users on modern browsers. On older browsers, keyboard users will now see the default browser focus ring instead of no focus ring at all.
♿ Accessibility
This change guarantees that keyboard focus indicators are never entirely hidden on older user agents, maintaining WCAG 2.4.7 Focus Visible compliance even in fallback scenarios.
PR created automatically by Jules for task 9551641770627077229 started by @seonghobae