Skip to content

🎨 Palette: Improve pointer focus outline suppression using :not(:focus-visible) - #1309

Closed
seonghobae wants to merge 2 commits into
mainfrom
palette-pointer-focus-suppression-9551641770627077229
Closed

seonghobae wants to merge 2 commits into
mainfrom
palette-pointer-focus-suppression-9551641770627077229

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

💡 What
Replaced :focus { outline: none; } with :focus:not(:focus-visible) { outline: none; } on semantic containers (main, .table-wrap, and .export-block pre).

🎯 Why
Using :focus { outline: none; } completely removes the outline for all focus states if a browser does not support :focus-visible. Using :not(:focus-visible) ensures that we suppress outlines for mouse users while providing a safe fallback that keeps the default outline for keyboard users in older browsers.

📸 Before/After
No visual change for users on modern browsers. On older browsers, keyboard users will now see the default browser focus ring instead of no focus ring at all.

♿ Accessibility
This change guarantees that keyboard focus indicators are never entirely hidden on older user agents, maintaining WCAG 2.4.7 Focus Visible compliance even in fallback scenarios.


PR created automatically by Jules for task 9551641770627077229 started by @seonghobae


Open in Devin Review

Replaces `:focus` with `:focus:not(:focus-visible)` when suppressing outlines on semantic containers (like `main`, `.table-wrap`, and `.export-block pre`). This ensures mouse clicks do not trigger outlines, while preserving a fallback focus indicator for keyboard users on older browsers that do not support `:focus-visible`. Update the relevant unit tests to match and document the learning.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 1 minute.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 67a6783f-7ae6-48ab-9dec-e5164db42b21

📥 Commits

Reviewing files that changed from the base of the PR and between 04d0bc2 and 95f1185.

📒 Files selected for processing (4)
  • .jules/palette.md
  • python/fast_mlsirm/report.py
  • tests/test_report.py
  • tests/test_report_focus_contrast.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Replaces `:focus` with `:focus:not(:focus-visible)` when suppressing outlines on semantic containers (like `main`, `.table-wrap`, and `.export-block pre`). This ensures mouse clicks do not trigger outlines, while preserving a fallback focus indicator for keyboard users on older browsers that do not support `:focus-visible`. Update the relevant unit tests to match and document the learning.

Copy link
Copy Markdown
Contributor Author

Closing this unmerged as a duplicate report-accessibility writer. Fresh comparison against current PR #1002 (36e0bdd71535e56fe1329f31c2cd74d0749c64d8) shows #1002 already owns and tests the same production selectors in python/fast_mlsirm/report.py: main, .table-wrap, and .export-block pre use :focus:not(:focus-visible) while explicit keyboard :focus-visible styling remains; #1002 additionally covers disclosure <summary> focus and report-title trust. #1309 exact head 95f1185de6167e41511280598fa7cb8f5e8f5259 repeats that production change and includes unrelated formatting churn in the same source file plus a .jules/palette.md note. Under single-writer-by-conflicting-scope, keep #1002 as the report-surface landing unit and do not land this duplicate independently.

@seonghobae seonghobae closed this Aug 24, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing this unmerged as a duplicate report-accessibility writer. Fresh comparison against current PR #1002 (36e0bdd71535e56fe1329f31c2cd74d0749c64d8) shows #1002 already owns and tests the same production selectors in python/fast_mlsirm/report.py: main, .table-wrap, and .export-block pre use :focus:not(:focus-visible) while explicit keyboard :focus-visible styling remains; #1002 additionally covers disclosure <summary> focus and report-title trust. #1309 exact head 95f1185de6167e41511280598fa7cb8f5e8f5259 repeats that production change and includes unrelated formatting churn in the same source file plus a .jules/palette.md note. Under single-writer-by-conflicting-scope, keep #1002 as the report-surface landing unit and do not land this duplicate independently.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant