fix(judge): make weighted criterion evidence authoritative - #1239
seonghobae wants to merge 3 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Superseded by live parent implementation
This successor originally carried #1235/#1238 on top of
fix-assert-validations-7577214956643354730@4163bbb42763282c0b7729c37e8b919895141a5f.During concurrent development, that exact parent branch advanced to
e4d170040ed2230bef8133855826fbdfaec29b86and independently implemented the same two bounded defects inllm_judge.py: aggregate criterion-weight overflow now fails before transport, and the direct/plain result derives its authoritative score/decision from validated weighted criterion evidence while retaining top-level score validation. Fresh tests on the parent cover both regressions, and its repository-local CI/Security/SAST/CodeQL are exact-head green.Because this branch is now 3 commits ahead / 1 behind the live parent with overlapping implementations of the same mutable source and issue scope, retaining it would create a competing writer rather than add distinct product value. No rebase, force-push, or duplicate merge is performed. The live implementation is adopted in PR #1019, whose body now closes #1235 and #1238 and documents the expanded scope.
Historical lineage retained for audit only:
4ee40e6b139da203194dafaeabed6a9d2550ecfae52c79be5126eb00eecfe59addf98f099afdaff174da6ae89b9e2b787a85e72b0df091c1f84bec3bClosed without merge as superseded; no product requirement is being dropped.