Skip to content

fix(model-comparison): replay casewise trust boundary on current review workflow - #1009

Merged
seonghobae merged 7 commits into
mainfrom
fix/model-comparison-current-review-990
Aug 24, 2026
Merged

seonghobae merged 7 commits into
mainfrom
fix/model-comparison-current-review-990

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Supersedes #990 without changing its corrected product tree.

Exact source head: f59c74f79cd5a37e8c1bd74e1f83a1924a11b508. Repository CI, Security Scan, CodeQL, and Semgrep are terminal-success on this SHA, with no unresolved review threads.

The public nonnested-model comparison boundary rejects arbitrary numeric protocols/subclasses without dispatch while preserving exact built-in and supported NumPy scalars. Python validates and marshals only; casewise log-likelihood-ratio mean, omega, BIC correction, Vuong z, and p-value arithmetic remain compiled-Rust owned.

#990's formal OpenCode CHANGES_REQUESTED is solely central coverage-evidence run 32167081903. This successor creates a fresh pull-request event for the current central workflow without source churn, force-push, review dismissal, or gate weakening.


Open in Devin Review

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 40 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f66a3474-b3da-4f42-9333-74abc94f2cdb

📥 Commits

Reviewing files that changed from the base of the PR and between 04d0bc2 and 4c4a22d.

📒 Files selected for processing (4)
  • docs/changelog.d/608-model-comparison-casewise-trust-boundary.md
  • python/fast_mlsirm/model_comparison.py
  • tests/test_model_comparison_input_error_boundary.py
  • tests/test_model_comparison_numeric_callback_safety.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

@opencode-agent @cwl-noema-review Please independently review exact current head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 against live main. Exact-head CI 32207659456, Security Scan 32207659452, CodeQL 32207659450, and SAST Semgrep 32207659467 are terminal-success and inline review threads are empty. Verify the public nonnested-comparison boundary rejects caller numeric protocols/subclasses without callback dispatch while preserving exact trusted built-in/NumPy scalars, and that casewise LLR mean, omega, BIC correction, Vuong z, and p-value arithmetic remain compiled-Rust owned. Do not transfer #990 predecessor evidence.

@opencode-agent opencode-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508.

  • Head SHA: f59c74f79cd5a37e8c1bd74e1f83a1924a11b508

  • Workflow run: 32213331140

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Docs: 608-model-comparison-casewise-trust-boundary.md"]
  S1 --> I1["operator or user guidance"]
  I1 --> R1["Review risk: Docs: 608-model-comparison-casewise-trust-boundary.md"]
  R1 --> V1["docs review"]
  Evidence --> S2["Changed file: model_comparison.py"]
  S2 --> I2["repository behavior"]
  I2 --> R2["Review risk: Changed file: model_comparison.py"]
  R2 --> V2["required checks"]
  Evidence --> S3["Test (2 files)"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test (2 files)"]
  R3 --> V3["targeted test run"]
Loading

@opencode-agent

Copy link
Copy Markdown
Contributor

OpenCode Review Overview

  • Head SHA: f59c74f79cd5a37e8c1bd74e1f83a1924a11b508
  • Workflow run: 32213331140
  • Workflow attempt: 1
  • Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

  • Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

  • Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

  • Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

  • Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

  • Result: REQUEST_CHANGES

  • Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508.

  • Head SHA: f59c74f79cd5a37e8c1bd74e1f83a1924a11b508

  • Workflow run: 32213331140

  • Workflow attempt: 1

Coverage evidence

Coverage evidence job did not run or did not publish coverage evidence.

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Docs: 608-model-comparison-casewise-trust-boundary.md"]
  S1 --> I1["operator or user guidance"]
  I1 --> R1["Review risk: Docs: 608-model-comparison-casewise-trust-boundary.md"]
  R1 --> V1["docs review"]
  Evidence --> S2["Changed file: model_comparison.py"]
  S2 --> I2["repository behavior"]
  I2 --> R2["Review risk: Changed file: model_comparison.py"]
  R2 --> V2["required checks"]
  Evidence --> S3["Test (2 files)"]
  S3 --> I3["regression suite"]
  I3 --> R3["Review risk: Test (2 files)"]
  R3 --> V3["targeted test run"]
Loading

@opencode-agent
opencode-agent Bot disabled auto-merge August 19, 2026 04:58

Copy link
Copy Markdown
Contributor Author

@opencode-agent review
@cwl-noema-review review

Fresh re-review request: ContextualWisdomLab/.github#1136 has merged, fixing the central coverage-evidence bug (_install_trusted_uv() target-triple validation) that caused the prior REQUEST_CHANGES verdict on this PR. Please re-review exact current head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 — the underlying infrastructure blocker is now resolved on .github main. Do not transfer evidence from any prior head.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

@opencode-agent Please re-review unchanged exact head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 against live main@04d0bc21a2a20693bcf16108cd76d394fe844d23. Repository CI, Security Scan, CodeQL, and Semgrep are terminal-success on this exact head and inline review threads are empty. The formal CHANGES_REQUESTED is central coverage run 32213331140, created before .github main advanced to 9e9f59f3ac1e96a960c021b131d768c238f4c21a (fix(ci): verify trusted uv target-triple output (#1136), 2026-08-19T09:24:32Z), which repairs the trusted-uv materialization boundary. Please regenerate same-head coverage/formal review evidence under the current central contract.

@seonghobae
seonghobae enabled auto-merge (squash) August 19, 2026 13:21
@opencode-agent
opencode-agent Bot disabled auto-merge August 19, 2026 13:59

Copy link
Copy Markdown
Contributor Author

@opencode-agent review
@cwl-noema-review review

Re-dispatch unchanged exact head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 under central .github@bbedc1a51ec1a2421f129955c629b3cd0507a4ec. Repository CI, Security Scan, CodeQL, and Semgrep are terminal-success and inline threads are empty. The sole formal CHANGES_REQUESTED came from central coverage run 32213331140 before #1136 corrected trusted-uv verification; central main now also includes #1140's OIDC permission repair for scheduler callers. Generate fresh same-head coverage/formal review evidence without transferring the old infrastructure verdict.

@seonghobae seonghobae closed this Aug 19, 2026
@seonghobae seonghobae reopened this Aug 19, 2026
@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 02:59
@opencode-agent
opencode-agent Bot disabled auto-merge August 20, 2026 03:42
@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review
@cwl-noema-review review

Please re-review exact current head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 against protected main@04d0bc21a2a20693bcf16108cd76d394fe844d23. Focused casewise numeric trust-boundary and input-error tests pass locally (12 passed). Current repository CI/security evidence is terminal; coverage/OpenCode/GPU entries reflect the earlier central/Apt infrastructure boundary. Verify exact built-in/NumPy scalar admission, callback-free rejection, redacted package errors, and Rust ownership of Vuong arithmetic without transferring #990 evidence.

@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 04:21
@opencode-agent
opencode-agent Bot disabled auto-merge August 20, 2026 04:47
@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 04:55
@opencode-agent
opencode-agent Bot disabled auto-merge August 20, 2026 06:24
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head review for f59c74f: required checks are terminal-success on this exact head. Existing formal review state predates the current evidence or was tied to an earlier coverage-evidence attempt; no source failure is shown. Please reacquire approval against this exact head. @opencode-agent review @cwl-noema-review review

@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 07:27

Copy link
Copy Markdown
Contributor Author

@opencode-agent review

Re-evaluate exact unchanged head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 under the current central coverage-evidence contract. The earlier formal verdict on this same source head failed at the central coverage-evidence boundary; repository CI, Security Scan, CodeQL, and Semgrep are terminal-success. Re-fetch the live base and all required exact-head evidence, then issue a fresh formal verdict without transferring the prior infrastructure failure as source evidence.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review\n@cwl-noema-review review\n\nPlease review exact current head f59c74f. Bind every review and approval decision to this SHA and current main. Existing review state is not sufficient evidence for this head; use current Checks and changed-file evidence only.

@opencode-agent
opencode-agent Bot disabled auto-merge August 20, 2026 07:53
@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head re-review request for f59c74f79cd5a37e8c1bd74e1f83a1924a11b508 against protected main. The prior REQUEST_CHANGES verdict cited predecessor or superseded coverage evidence; re-fetch the exact current-head coverage-evidence result and review the complete current diff. Do not transfer predecessor-head findings or approvals. @opencode-agent review @cwl-noema-review review

@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 17:55
@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review @cwl-noema-review review

Please re-review exact current HEAD f59c74f against current protected main; do not transfer predecessor coverage verdicts.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current-head re-review request for f59c74f. The existing REQUEST_CHANGES cites superseded central coverage-evidence infrastructure; current repository checks are terminal-success. Bind any new decision to this exact HEAD and live central workflow; no source patch is warranted without a current-head finding.

@opencode-agent
opencode-agent Bot disabled auto-merge August 20, 2026 19:53
@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 20:04

Copy link
Copy Markdown
Contributor Author

@opencode-agent @cwl-noema-review Re-review the exact current head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508.

The prior current-head REQUEST_CHANGES only reported unavailable/failed coverage evidence from an earlier run. Current CI, Security Scan, SAST Semgrep, and CodeQL runs for this exact head are terminal-success. Re-evaluate this head and publish independent approvals only from fresh evidence; do not reuse prior-head reviews. Protected merge policy remains unchanged.

@opencode-agent
opencode-agent Bot disabled auto-merge August 20, 2026 22:12
@seonghobae
seonghobae enabled auto-merge (squash) August 20, 2026 22:44

Copy link
Copy Markdown
Contributor Author

@opencode-agent Please perform a review-only formal review of exact current PR head f59c74f79cd5a37e8c1bd74e1f83a1924a11b508. Re-check changed-file scope, current-head findings, unresolved threads, mergeability, and every required Check. Do not reuse a stale review, mutate the branch, self-approve, or merge.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Current-head fix for 4c4a22d:

  • Added docstrings to every new callback-safety fixture method and nested test callback so the focused documentation gate is 100%.
  • Focused tests: 23 passed; Ruff, compileall, and git diff --check passed; focused docstring coverage is 100%.
  • The production trust-boundary change remains unchanged: exact built-in and concrete NumPy real scalars are admitted, arbitrary float protocols and subclasses are rejected before conversion callbacks.
  • Normal squash auto-merge is enabled; fresh hosted checks and the independent formal review gate still govern merge.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@opencode-agent opencode-agent Bot added area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: bug Defect or incorrect behavior labels Aug 22, 2026
@seonghobae
seonghobae merged commit 61ba20d into main Aug 24, 2026
38 checks passed
@seonghobae
seonghobae deleted the fix/model-comparison-current-review-990 branch August 24, 2026 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant