fix(ci): repair contract-doc path filtering - #338
Draft
seonghobae wants to merge 16 commits into
Draft
Conversation
📝 WalkthroughWalkthrough테스트 워크플로의 Changes워크플로 경로 필터
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to The workflow now uses supported ordered path filters, but the added safeguard may not detect every future invalid negative paths-ignore pattern. Strengthen the test's YAML handling before relying on it as the contract check. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
September 3, 2026 11:41
seonghobae
changed the base branch from
main
to
fix/release-artifact-windows-namespace-v1
September 3, 2026 12:17
seonghobae
marked this pull request as draft
September 3, 2026 13:10
seonghobae
added a commit
that referenced
this pull request
Sep 4, 2026
Adopt exact #338 non-force while preserving coverage jobs and aligning Test concurrency with the canonical first-attempt PR supersession contract. Signed-off-by: Seongho Bae <me@seonghobae.me>
This was referenced Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DiskSage Test workflow must use GitHub's supported ordered
pathsre-inclusion contract rather than negative re-inclusion underpaths-ignore, while remaining the canonical owner for shared Test-workflow behavior. A leaf runtime PR (#345) also introduced a valid Windows agent-session regression directly in.github/workflows/test.yml; that evidence belongs here, not in the runtime lane.Current exact state — 2026-09-06 KST
main:0e90f9cebadbd7f59606baaec4ca1d2f178c899a;3e33229b4157a084a1985a1c7e952f98a64f25e3;29aaf64c9fea7ffde88fc9a8adcd6f0560c26466;34038386834is non-terminal: Windowswindows-home-resolutionjob101500547096is terminal success and executed the new conditional agent-state step successfully; Ubuntutest101500547141andllm-engine-build101500546979remain runner-unassigned withsteps=[],runner_id=0;34038386863is skipped and is not passing evidence;Review → RED → causal owner repair
The valid #345 Windows regression compiled
src-tauri/src/agent_state_guard.rsdirectly, but placing that step in a leaf-owned shared workflow violated the Test single-writer boundary. Test-firstfe2059645790f3d0a2163cbebb16fcf1763089b2extendssrc/lib/testWorkflowPathFilterContract.test.tsto require that the canonical workflow run the agent-state regression whenever the owner source exists. Its hosted Test was cancelled by the immediate successor, so no hosted RED is claimed.Production
29aaf64c9fea7ffde88fc9a8adcd6f0560c26466adds the Windows step in this canonical workflow with an explicitTest-Path 'src-tauri/src/agent_state_guard.rs'admission. That keeps #338 independently runnable before #345 is integrated while ensuring any descendant carrying the agent-state owner source executes the Windows regression. The check is additive; no existing job, required test, timeout, or failure condition was weakened. Current Windows hosted execution confirms the workflow parses and the conditional step completes successfully on the canonical owner head; #345 must still later prove the source-present branch after normal owner adoption.#345 subsequently restored
.github/workflows/test.ymlto its protected-main blob incbdc760cc8fb733772d718c29b0459d324b852bf, removing the competing leaf writer. #345 must later adopt the canonical Test owner through normal ancestry before using this workflow evidence; no predecessor check is transferred.Existing path-filter contract
Push/pull-request filters include
**, exclude generic docs/root Markdown, then re-include contract-checked documents andCHANGELOG.md. The regression contract prevents comments or inline YAML lists from hiding unsupported negativepaths-ignoreentries.Merge boundary
Keep Draft while #264 is not integrated or any required exact-head gate is non-terminal/non-passing. #264 remains blocked by the canonical
.githubCodeQL metadata-binding owner path. Revalidate protectedmain, live ruleset, review threads, Test/Release/Security/SAST/CodeQL/OSV/Scorecard and central required workflows immediately before Ready/merge. No force-push, destructive rebase, self-approval, gate weakening, administrative bypass, or predecessor-evidence transfer.Latest owner update — conditional macOS cache regressions
Current head:
dad7832cbc20acf8b709b6ed28e06e3db6319b12(Draft). Earlier exact-head status above is historical and does not establish this head's hosted checks.The canonical Test owner now carries the macOS job setup, pinned actions, and Corepack/permanent-Gradle regression intent from PR #295 head
b7fbf6f58e196ff7c4b059477af6d450c41373a1, with the generated-cache staging regression added. Each target runs only when its test source exists. An absent source prints an explicit skip stating that no runtime regression executed. No test implementation was copied into this owner.Validation: the focused Vitest workflow contract passed 4/4 tests; the previous canonical workflow failed the new assertion (3 passed, 1 failed). The shell fixture verifies absent-source skips, exact Cargo dispatch for present source, and failure propagation. Actionlint and
git diff --checkpass. These are workflow/dispatch checks, not Rust runtime execution. All three cache test sources are absent on this canonical head, so its macOS job cannot establish their runtime correctness.Protected owner adoption remains pending. PR #295's existing workflow delta remains unchanged until successor ancestry and coverage are verified; duplicate-owner reconciliation must follow that adoption. No consumer workflow was edited, no PR was merged, and no prior hosted result transfers to this head.