fix: retain temporary Cargo data without producer evidence - #325
Draft
seonghobae wants to merge 11 commits into
Draft
fix: retain temporary Cargo data without producer evidence#325seonghobae wants to merge 11 commits into
seonghobae wants to merge 11 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as draft
September 6, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A matching temporary folder name and an empty Cargo lock file previously admitted arbitrary contents to a cleanup plan. A synthetic folder containing a sole source copy and Claude session reproduced an approval-ready plan with no blockers. The producer test creates a predictable target path but records no source binding or ownership receipt.
Current head
2069d649dbbb9222d49fc0fcaac2965653478f72rejects this temporary-Cargo candidate before reading its contents for a fingerprint. Existing candidate/wire recognition is retained, but it grants no actionable cleanup plan. Re-enabling requires producer-bound retained-source and target identity evidence, correct native Cargo target/build-directory confinement, and the shared session/concurrency prerequisites. Folder names and empty lock files are insufficient.Validation: the new regression fails against the prior implementation by receiving an unblocked plan; after repair, 19 actual-module/integration tests and 3 CLI tests pass on macOS. The source and session sentinels remain intact. This is controlled-boundary regression evidence, not universal false-positive or physical-capacity proof. No user data was deleted. The PR remains Draft; protected checks, independent review, and prerequisite integration are outstanding.
The normal parent merge includes PR322
fa1e8db4abcba6d76463f7611b52062e3fbb7dcfand preserves parent identity, original-command association, self-PID filtering, and symlink-manifest behavior. The unsafe former ownership assertion is superseded by this explicit producer-evidence gate.Prior proposal and preserved context
The earlier proposal below records historical intent and evidence. Any assertion that matching temporary Cargo names are already safe to reclaim is superseded by the current behavior above.
Outcome
Live evidence
Validation
cargo test --manifest-path src-tauri/Cargo.toml generated_cache_reclaim::tests::disksage_owned_temporary_cargo_target_is_regenerable_but_neighbors_are_not --lib(1 passed)git diff --checkProtected prerequisite status
This PR remains Draft while the generated-cache owner PR #295 and its protected safety prerequisites remain Proposed and unmerged. Parent-handle checks reduce a reproduced gap; they do not prove exclusion of arbitrary late writers. Atomic no-replace restoration and current-head validation remain acceptance work. Unique changes are preserved through normal non-force parent integration; this status change is not a close or a shipped-safety claim.