fix: audit cache symlinks without traversal - #320
Draft
seonghobae wants to merge 14 commits into
Draft
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…im-v1' into codex/pr320-merge # Conflicts: # src-tauri/src/generated_cache_reclaim.rs
There was a problem hiding this comment.
Devin Review found 1 new potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ Partial deletions appear unexecuted
When an exact-delete command removes some candidates before returning nonzero, executed becomes false despite the completed mutations. Audit consumers can treat a destructive attempt as harmless failure.
seonghobae
marked this pull request as draft
September 6, 2026 15:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo test --manifest-path src-tauri/Cargo.toml generated_cache_reclaim::tests:: --lib(11 passed)git diff --checkNo live cache, cloud-provider, Photos, container, or VM mutation was performed.
Protected prerequisite status
This PR remains Draft while the generated-cache owner PR #295 and its protected safety prerequisites remain Proposed and unmerged. Parent-handle checks reduce a reproduced gap; they do not prove exclusion of arbitrary late writers. Atomic no-replace restoration and current-head validation remain acceptance work. Unique changes are preserved through normal non-force parent integration; this status change is not a close or a shipped-safety claim.