feat: separate inconclusive provider and reclaim evidence - #318
feat: separate inconclusive provider and reclaim evidence#318seonghobae wants to merge 7 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true📝 WalkthroughWalkthrough네이티브 제공자 프로브의 타임아웃과 빈 출력을 제한형 keep-local 영수증으로 처리합니다. 회수 진행률은 전역 APFS 변화와 완료 작업의 귀속 바이트를 분리합니다. UI는 다음 동작을 우선 표시하고 진단 정보를 감사 상세에 배치합니다. Changes제공자 증거와 회수 진행률
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to Partial provider timeouts can omit the keep-local receipt, so users may not receive the intended rescan guidance and audit reason even though unsafe copy or cleanup remains blocked; the PR is mergeable with explicit owner follow-up to make timeout responses consistent. Sequence Diagram(s)sequenceDiagram
participant 사용자
participant CloudArchive
participant ProviderGlobalSyncReport
participant NativeProviderProbe
사용자->>CloudArchive: 보관 상태 확인
CloudArchive->>NativeProviderProbe: 공급자 동기화 프로브 실행
NativeProviderProbe-->>CloudArchive: 완료 결과, 타임아웃 또는 빈 출력
CloudArchive->>ProviderGlobalSyncReport: 프로브 결과 보고서 조회
ProviderGlobalSyncReport-->>CloudArchive: 다음 동작과 감사 세부 정보
CloudArchive-->>사용자: 로컬 유지 또는 재검사 안내
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 16 functions across 7 files. (5 skipped: 5 unsupported.) ✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Outcome
Safety
Verification
cargo test --locked --manifest-path src-tauri/Cargo.toml provider_global_sync::tests --lib(17 passed)cargo test --locked --manifest-path src-tauri/Cargo.toml volume_pressure::tests --lib(12 passed)npm test -- --run src/lib/cloudArchiveAdmissionContract.test.ts src/lib/api.test.ts(15 passed)npm run check(0 errors, 0 warnings)git diff --checkSummary by CodeRabbit
새로운 기능
개선 사항
문서