fix: verify Windows release artifact namespace - #307
Conversation
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Verified succession audit against current protected |
Purpose
Repair the PR-executable release artifact verifier after the merged
actions/download-artifactv8 compatibility line exposed an exact platform-namespace mismatch.Exact failure and root cause
On PR #214 exact head
a6cfd32e1c56ea12bddcfdd3f5caff9d6f95e9f6, Release run32936765719built and uploaded Linux, Windows, and macOS artifact sets successfully. Thedownload-artifact-pr-compatjob98083412428downloaded the v8 artifact family successfully and then failed only inVerify downloaded release artifact contract.The release matrix uploads artifacts under
release-disksage-${{ matrix.os }}-${{ github.run_attempt }}and the Windows matrix key iswindows-2022. The verifier instead requiredrelease-disksage-windows-latest-${run_attempt}, so a correct downloaded artifact set could never satisfy the directory contract.Test-first repair
ubuntu-22.04,windows-2022,macos-latest) and executes the source-controlled Bash verifier..github/scripts/verify-release-artifacts.shfromwindows-latesttowindows-2022.The verifier's exact file cardinality, bundle types, six operational CLI artifacts, six adjacent SHA-256 records, checksum validation, non-regular-path rejection, and read-only PR compatibility authority remain unchanged.
Authority boundary
This adds no tag, release-publication, package-publication, attestation, secret, or write authority to pull requests. It only repairs the read-only compatibility proof already introduced by the merged #230 line.
Addresses #242.
Required before integration
Keep Draft until the unchanged exact head proves the real
download-artifact-pr-compatjob succeeds on the downloaded Linux/Windows/macOS release artifacts, all applicable current Test/Release/Security/SAST and central required workflows are terminal-success, current valid findings are addressed, live review/ruleset requirements are satisfied, and repository-wide exact production coverage requirements are not weakened. Pending, skipped-required, failed, stale, predecessor, status-only, or synthetic evidence is non-passing.Summary by CodeRabbit
개선 사항
테스트