fix: make audit CLI help successful and bounded - #215
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueNo actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough두 감사 CLI가 Changes감사 CLI 인자 처리
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: ⚪ Minimal · up to The PR makes help a successful terminal action and bounds invalid-argument diagnostics for two audit commands without changing audit behavior. No actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head05569ea9fe0cab608a37b268c78a81e047f5d991. -
Head SHA:
05569ea9fe0cab608a37b268c78a81e047f5d991 -
Workflow run: 32148583820
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (3 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (3 files)"]
R1 --> V1["required checks"]
|
05569ea to
931bdd0
Compare
|
Current head |
|
@OpenCode review current exact head |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…espace-v1' into HEAD
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Pull request was converted to draft
| [--private-output ABSOLUTE_NEW_FILE.json]\n\ | ||
| 다음 단계: 누락되거나 중복된 분할 조각을 검토하세요. 이 명령은 파일을 이동하거나 삭제하지 않습니다." |
There was a problem hiding this comment.
📝 Info: Read-only claim remains accurate
The audit path never moves or deletes files. Optional private output only creates a new evidence file.
Was this helpful? React with 👍 or 👎 to provide feedback.
…r sidecar pin fix The previous noema/strix/opencode-review failures used the pre-fix sidecar pin (b2164511). .github main now vendors the fixed commit, so re-running should populate the review verdicts. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
1 participant
Purpose
Make
disksage-multipart-archive-auditanddisksage-incomplete-download-auditexpose a sole--help/-has a successful terminal action while keeping invalid input non-zero, diagnostics bounded, and native filesystem path operands outside UTF-8 protocol coercion.Exact current state
main:79067c1160ddedf7fc962cbf8067ce7e83c4564a7c5423164417a8fbd9922cabe32cdab7c0c18d9fsrc-tauri/src/bin/disksage-incomplete-download-audit.rssrc-tauri/src/bin/disksage-multipart-archive-audit.rssrc-tauri/tests/cli_help_audit_batch_exit.rsNo predecessor check, review, approval, synthetic merge result, remembered SHA, or stale PR-body statement transfers to this head.
Test-first behavior
The process contract builds and launches the real feature-gated audit binaries and requires:
--help/-h=> exit 0, stable usage on stdout, empty stderr;OsString/PathBuf;The production changes are deliberately narrow. Audit bounds, archive/incomplete-download inspection, private create-new evidence behavior, filesystem-read authority, and normal JSON output semantics remain unchanged.
Exact-head evidence
For unchanged head
7c5423164417a8fbd9922cabe32cdab7c0c18d9f:32966981289— success;32966981280— success;32966981249— success;32966981248— failure in the shared release-artifact verifier dependency, not in this PR's three-file audit-help source delta.Release artifact verification is canonically owned by #264. Do not add an audit-CLI-local verifier workaround. Ready-for-review means independent review can proceed while that dependency is integrated; it is not merge authorization.
Live governance / remaining gates
The inherited
CWL Central required workflowsruleset currently requires one approving review, stale-review dismissal on push, review-thread resolution, its unattributed-change approval rule, and the configured central required workflows;require_last_push_approvalis currentlyfalse.Repository-wide exact non-vacuous 100% owned-production region/statement-equivalent, branch, function, and line coverage remains materially unsatisfied on canonical owner #156. Feature-local success does not substitute for that gate.
Required before merge
Do not merge unless one unchanged exact integration head satisfies every applicable native and central required workflow, the #264 release-verifier dependency is integrated or otherwise proven on that exact lineage, zero valid current findings remain, live review/ruleset requirements are satisfied, fresh protected-main ancestry remains valid, package/SBOM/provenance requirements are complete where applicable, and repository-wide exact 100% owned-production coverage is proven without exclusions or threshold weakening. Pending, queued, skipped-required, failed, stale, predecessor, synthetic, diagnostic-only, status-only, model-only, no-source, rate-limited, or infrastructure-only evidence is non-passing.