fix: surface bounded scan and navigation failures

[seonghobae]

Purpose

Own the primary scan/navigation UI boundary: keep backend failures bounded and visible, prevent stale async navigation/result publication, and make successful zero-result scans render the TopFiles empty-state surface without changing filesystem or cleanup authority.

Current authority — 2026-09-05 KST

• protected main: 0e90f9cebadbd7f59606baaec4ca1d2f178c899a;
• canonical release/Test parent fix: verify Windows release artifact namespace #264: 3e33229b4157a084a1985a1c7e952f98a64f25e3;
• exact fix: surface bounded scan and navigation failures #202 head: 060229015b4b81bb1d574a6827c8fb8c69fd7cdc;
• non-force restacked onto exact current fix: verify Windows release artifact namespace #264 after inspecting its two contract-test-only changes;
• semantic delta remains exactly five page-owned files: src/routes/+page.svelte plus focused scan/navigation/error/empty-state contracts. Release/Test foundation is inherited, not copied;
• Draft. Exact-head gates must be reacquired; predecessor evidence does not transfer.

Scan/navigation contract

+page.svelte projects root-discovery, scan-event, scan-start, post-scan-load, and navigation failures through bounded path-free messages. Scan/navigation generations reject stale async publication. A successful zero-result scan mounts TopFiles only after the paired current-generation node/result state is accepted, so empty-state guidance does not appear during initial/loading/error states.

All #202-owned review findings remain resolved. Real-browser interaction acceptance remains owned by issue #340 and descendant #203.

Required before integration

Keep Draft until #264 is integrated or equivalently present on protected lineage and this unchanged exact head satisfies every applicable native/central Test/Release/Security/SAST/coverage/package/SBOM/provenance gate, all valid current review findings are resolved, and live ruleset/review requirements are satisfied. No self-approval, force-push, destructive rebase, gate weakening, or predecessor-evidence transfer.

[coderabbitai]

📝 Walkthrough

Walkthrough

페이지는 루트 조회, 스캔, 폴더 탐색 및 경로 이동의 실패를 화면 내 한국어 오류 메시지로 표시합니다. 스캔 결과는 노드와 상위 파일을 병렬로 조회합니다. 관련 오류 표시와 API 호출 계약 테스트를 추가했습니다.

Changes

페이지 오류 피드백

Layer / File(s)	Summary
비동기 작업 오류 처리 src/routes/+page.svelte	루트 조회, 스캔 시작·완료, 폴더 열기 및 경로 이동의 실패를 operationError 상태로 관리합니다. 스캔 완료 후 노드와 상위 파일을 병렬로 조회합니다.
오류 표시 및 계약 검증 src/routes/+page.svelte, src/routes/pageErrorFeedbackContract.test.ts	role="alert" 오류 문단과 .error 스타일을 추가했습니다. 고정 한국어 오류 문구, 임의 예외 노출 방지, 주요 API 호출을 소스 기반 테스트로 검증합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Mergeability Score: 🟡 Moderate · up to 682a6

A new scan can still be overwritten by an older navigation request, causing users to see stale folder results or breadcrumbs from the previous location. This localized correctness issue should be fixed or explicitly accepted before merge.

Sequence Diagram(s)

sequenceDiagram
  participant Browser as 브라우저
  participant Page as +page.svelte
  participant API as 조회·스캔 API
  Browser->>Page: 스캔 또는 탐색 요청
  Page->>API: 루트·스캔·노드·상위 파일 조회
  API-->>Page: 결과 또는 오류
  Page->>Page: operationError 갱신
  Page-->>Browser: 오류 메시지 또는 결과 표시

Loading

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 스캔 및 탐색 실패를 사용자에게 표시하는 이번 변경의 핵심을 명확하고 간결하게 설명합니다.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/scan-navigation-error-feedback-v1

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@coderabbitai review

[coderabbitai]

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[seonghobae]

@coderabbitai review

Please re-review the unchanged current exact head c50fdd3a1e4b2dfc6e624910ac81f7dea8e831b9. The predecessor review was anchored to 682a694ae3299924b371315f63c20f5a2b626a48; the current head now increments navSeq before scan reset and scopes the source-contract assertions to onMount, scan, open, and jump. Do not transfer predecessor findings if they are no longer reproducible.

[coderabbitai]

@seonghobae I will re-review exact head c50fdd3a1e4b2dfc6e624910ac81f7dea8e831b9. I will only report findings that reproduce on this head. I will check the scoped assertions for onMount, scan, open, and jump.

⚠️ Action not completed

Review rate limited.

---

Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 1 minute.

[opencode-agent]

OpenCode Review Overview

• Head SHA: c50fdd3a1e4b2dfc6e624910ac81f7dea8e831b9
• Workflow run: 31863590966
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (exit 0)

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (3 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (3 files)"]
  R1 --> V1["required checks"]

Loading

[seonghobae]

@opencode-agent review
@cwl-noema-review review

Re-review exact current head 669f71cd684a556c922e360da2212dad7ae70766 only. The prior OpenCode P2 thread on predecessor head c50fdd3a1e4b2dfc6e624910ac81f7dea8e831b9 requested bounded payload-free diagnostics; current head implements those fixed-string diagnostics in every affected failure path, the focused contract asserts them, and that thread is now resolved. Current-head repository Test, Release, Security Scan, and SAST Semgrep workflows are terminal-success. Do not transfer predecessor-head review evidence; reacquire current-head coverage/review evidence under the live central contract.

Dismissing: this REQUEST_CHANGES (removed failure diagnostics) was addressed by commit 669f71c 'fix: retain bounded scan diagnostics', pushed after this review, which adds console.error(...) bounded diagnostics to every catch path (scan(), onScanDone inner catch, open(), jump(), and the onMount catches) while keeping the bounded user-facing operationError text. Verified: current head's catch blocks contain console.error calls and coverage-evidence passes. Both prior review threads are resolved. Re-request review to re-validate.

[seonghobae]

The bounded scan/navigation failure-feedback slice is ready for review at exact head 1d005586b270ca1fcad445970cf44bf5e7268425; no unresolved review threads remain. Protected checks/approvals are still required.