ci: attest release artifacts before publication - #154
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthrough릴리스 빌드 전에 세 manifest와 Git 태그의 버전을 검증한다. 플랫폼별 산출물을 공통 artifact로 업로드한다. 태그 릴리스는 allowlist·checksum 검증과 attestation을 완료한 뒤 GitHub Release에 게시한다. Changes릴리스 무결성
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions as GitHub Actions
participant BuildJobs as build jobs
participant ArtifactStore as artifact store
participant AttestRelease as attest-release
participant PublishRelease as publish-release
participant GitHubRelease as GitHub Release
GitHubActions->>BuildJobs: manifest·태그 검증 및 플랫폼 빌드
BuildJobs->>ArtifactStore: 공통 release artifact 업로드
AttestRelease->>ArtifactStore: artifact 다운로드
AttestRelease->>AttestRelease: allowlist·파일 수·SHA-256 검증
AttestRelease->>ArtifactStore: build provenance 생성
PublishRelease->>ArtifactStore: 검증된 artifact 다운로드
PublishRelease->>GitHubRelease: 전체 artifact 게시
Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
|
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head4f116c883f42286e7a70086f7dc03270cc19256d. -
Head SHA:
4f116c883f42286e7a70086f7dc03270cc19256d -
Workflow run: 31361408478
-
Workflow attempt: 1
Coverage evidence
Coverage Decision
- Result: FAIL
- Test evidence: not proven passing
- Docstring evidence: not proven passing when configured
- Failure count: 1
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: release.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: release.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (6 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (6 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Docs (2 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (2 files)"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: release-version.mjs"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: release-version.mjs"]
R4 --> V4["bash -n plus Strix self-test"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage Decision
Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Workflow: release.yml"]
S1 --> I1["GitHub Actions review job"]
I1 --> R1["Review risk: Workflow: release.yml"]
R1 --> V1["actionlint plus required checks"]
Evidence --> S2["Changed file (6 files)"]
S2 --> I2["repository behavior"]
I2 --> R2["Review risk: Changed file (6 files)"]
R2 --> V2["required checks"]
Evidence --> S3["Docs (2 files)"]
S3 --> I3["operator or user guidance"]
I3 --> R3["Review risk: Docs (2 files)"]
R3 --> V3["docs review"]
Evidence --> S4["CI script: release-version.mjs"]
S4 --> I4["review and security gate shell path"]
I4 --> R4["Review risk: CI script: release-version.mjs"]
R4 --> V4["bash -n plus Strix self-test"]
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/release.yml:
- Around line 153-158: Update the “Upload release artifact set” name in
.github/workflows/release.yml (lines 153-158) to include github.run_attempt, and
update the attest-release/publish-release download patterns there to match only
that attempt’s artifacts. Extend src/lib/releaseWorkflowRetryContract.test.ts
(lines 14-18) to verify both artifact names and download patterns include
github.run_attempt.
In `@scripts/ci/release-version.mjs`:
- Around line 18-23: Update the manifest parsing validation before accessing
parsed.version in the release-version loader to reject parsed === null and any
non-object value with the existing stable manifest error. Preserve the current
non-empty string validation for object manifests, and add a regression test in
releaseVersionContract.test.ts covering a JSON null manifest.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: f3adbc37-5cf4-4d98-9a5d-d5bdeb230516
📒 Files selected for processing (10)
.github/workflows/release.ymlCHANGELOG.mddocs/doctoring/release-artifact-provenance.mddocs/doctoring/release-version-contract.mdpackage.jsonscripts/ci/release-version.mjssrc/lib/releaseArtifactAllowlistContract.test.tssrc/lib/releaseProvenanceContract.test.tssrc/lib/releaseVersionContract.test.tssrc/lib/releaseWorkflowRetryContract.test.ts
1 participant
Purpose
Current-protected-main reconstruction of the release-provenance and exact release-version slice from stale/non-mergeable #151, which itself preserves the release-owned work from stacked #138. No old checks, reviews, approvals, or merge-tree evidence transfer.
Reconstruction boundary
Exact protected base at reconstruction start:
7a86b3dae0c941bc59edfde146c9d7498a0c75a0.Only release-owned semantics are being reconstructed: least-privilege build/attest/publish authority separation, exact 17-file artifact admission, adjacent operational-CLI checksum validation, unflattened artifact namespaces, retry-safe release concurrency, exact cross-manifest SemVer/tag admission, deterministic tests, authoritative doctoring, and changelog entries. Generic Test/coverage workflow ownership remains separate (#152). Canonical acquisition documentation remains separate (#149).
Keep Draft until reconstruction is complete, exact-current-head Test/Release/security/SAST and applicable coverage/package/provenance evidence pass, all valid current-head findings are addressed, and live repository/governance policy is satisfied.
Summary by CodeRabbit
개선 사항
문서
테스트