-
Notifications
You must be signed in to change notification settings - Fork 1
fix: negotiate unsupported temperature capability on current orchestration line #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
seonghobae
merged 10 commits into
fix/auto-reasoning-effort-contract-rebased
from
fix/provider-temperature-capability-negotiation-on-765-v2
Aug 20, 2026
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
4a5cc7a
fix: negotiate unsupported temperature capability
seonghobae beb15a7
test(protocol): preserve 4xx evidence and negotiated retry state
seonghobae cf4a450
fix: preserve negotiated temperature capability
seonghobae 995effd
merge: integrate automatic embedding selection with temperature negot…
seonghobae 5a6f563
docs: assign unique sampling capability ADR number
seonghobae 41c0c87
feat: opt in to client-owned tool loops (#787)
seonghobae dbf46e5
fix: reject streaming responses tool loops
seonghobae 157ea94
merge: reconcile stacked provider changes with current base
seonghobae ef7b1fb
fix: enforce total inbound body deadline
seonghobae 5774e1d
test: keep static checks clean
seonghobae File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import json | ||
| import os | ||
| import socket | ||
| import threading | ||
| import urllib.error | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Fully received requests can be rejected as timed out
A complete request body is rejected as timed out (
raise RequestError(408,...)atcontextual_orchestrator/server.py:5999-6001) after the final chunk that completes the body is read, so a valid, fully-received request is thrown away as an error.Impact: On a slow connection whose last byte arrives right around the deadline, a request whose entire body was already received is returned a 408 error instead of being processed.
Deadline re-check runs even once the body is complete
The loop condition is
while len(chunks) < body_size(contextual_orchestrator/server.py:5990). The deadline check at the top of the loop (5991-5993) correctly only fires when more data is still needed. However, the second check added afterchunks.extend(chunk)(5999-6001) runs unconditionally after each read — including the read that completes the body. Iftime.monotonic() >= read_deadlineat that moment, a 408 is raised even thoughlen(chunks) == body_sizeand the full body is available inchunks. The top-of-loop check already covers the incomplete case on the next iteration, so the post-extend check only adds the spurious rejection of an already-complete body. Guarding it withlen(chunks) < body_sizeavoids discarding a fully-read request.Was this helpful? React with 👍 or 👎 to provide feedback.