Skip to content

test(routing): align mixed quota recovery regression with main - #1289

Draft
seonghobae wants to merge 1 commit into
mainfrom
fix/mixed-quota-regression-contract
Draft

seonghobae wants to merge 1 commit into
mainfrom
fix/mixed-quota-regression-contract

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Repair an inherited test-contract failure on protected main, separately from #1249. Clean main aaa4dfd fails the unchanged mixed-failure regression after 167.93 seconds: it expects the earlier no-recovery behavior, while the recovery contract merged in #1222 retries the 429-rejected candidate and retains the final quota taxonomy.

Advance the fake clock during simulated sleeps and assert the current safety boundaries: non-quota candidate called exactly once; only the rejected candidate retried; bounded quota waiting; honest assumed provenance; no quota health penalty. Production code and security gates are unchanged.

Verification

28 provider-error taxonomy tests pass. Baseline failure and introducing revisions d90a8f8/b1b2bc2d0 are recorded in docs/doctoring/mixed_quota_retry_regression_contract.md. Current-head hosted checks and independent approval remain required.

Summary by CodeRabbit

  • 테스트
    • 여러 후보에서 혼합 오류가 발생할 때 할당량이 거부된 후보만 재시도하는 동작을 검증합니다.
    • 재시도 횟수, 대기 시간, 회로 차단기 등록 여부를 확인하는 검증을 추가했습니다.
  • 문서
    • 관련 회귀 테스트의 조건과 검증 항목, 실행 방법 및 결과를 기록했습니다.

@coderabbitai

coderabbitai Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: afa51872-f99e-4503-a8df-8aea81aeef46

📥 Commits

Reviewing files that changed from the base of the PR and between aaa4dfd and 9d66898.

📒 Files selected for processing (2)
  • docs/doctoring/mixed_quota_retry_regression_contract.md
  • tests/test_provider_error_taxonomy.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

혼합 실패 테스트가 할당량 거부 후보만 재시도하는 동작을 확인하도록 변경됐습니다. 최종 비율 제한 오류와 쿨다운 예산, 후보별 호출 횟수, 회로 차단기 상태를 검증합니다. 회귀 계약 문서도 추가됐습니다.

Changes

혼합 할당량 실패

Layer / File(s) Summary
후보별 재시도 회귀 계약
tests/test_provider_error_taxonomy.py, docs/doctoring/mixed_quota_retry_regression_contract.md
테스트가 기본 후보의 반복 호출과 백업 후보의 1회 호출을 확인합니다. 최종 오류가 예산 내 쿨다운 대기를 포함한 재시도 가능한 비율 제한 오류인지, 기본 후보가 회로 차단기에 등록되지 않는지도 검증합니다. 문서는 테스트 조건과 기준선 결과를 기록합니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 9d668

This change updates the mixed-quota regression test and documents its contract; no production behavior change or concrete defect is identified. Merge risk is minimal, subject to normal checks.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 혼합 할당량 복구 회귀 테스트를 main 브랜치 동작에 맞추는 주요 변경을 정확하고 간결하게 설명합니다.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head admission correction — 9d66898c8785a33171c4c0555038c9a993410560

Ready is review admission only. Fresh audit against base aaa4dfdd9d3744f303436ae23e67cf0e06536347 found:

  • mergeability=false on current base
  • latest terminal workflow blockers: CodeQL PR 36317235054=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:14

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant