Repository navigation
test(routing): align mixed quota recovery regression with main - #1289
seonghobae wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough혼합 실패 테스트가 할당량 거부 후보만 재시도하는 동작을 확인하도록 변경됐습니다. 최종 비율 제한 오류와 쿨다운 예산, 후보별 호출 횟수, 회로 차단기 상태를 검증합니다. 회귀 계약 문서도 추가됐습니다. Changes혼합 할당량 실패
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to This change updates the mixed-quota regression test and documents its contract; no production behavior change or concrete defect is identified. Merge risk is minimal, subject to normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 1 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-head admission correction — Ready is review admission only. Fresh audit against base
This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed. |
Summary
Repair an inherited test-contract failure on protected main, separately from #1249. Clean main aaa4dfd fails the unchanged mixed-failure regression after 167.93 seconds: it expects the earlier no-recovery behavior, while the recovery contract merged in #1222 retries the 429-rejected candidate and retains the final quota taxonomy.
Advance the fake clock during simulated sleeps and assert the current safety boundaries: non-quota candidate called exactly once; only the rejected candidate retried; bounded quota waiting; honest assumed provenance; no quota health penalty. Production code and security gates are unchanged.
Verification
28 provider-error taxonomy tests pass. Baseline failure and introducing revisions d90a8f8/b1b2bc2d0 are recorded in docs/doctoring/mixed_quota_retry_regression_contract.md. Current-head hosted checks and independent approval remain required.
Summary by CodeRabbit