Skip to content

fix: close trace HTTP test response and listener resources - #1152

Merged
seonghobae merged 4 commits into
mainfrom
codex/trace-http-resource-successor-20260913
Sep 17, 2026
Merged

seonghobae merged 4 commits into
mainfrom
codex/trace-http-resource-successor-20260913

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Scope and ownership

Stacked on #1140 at 38c0603. This preserves its production response-lifecycle delta and adds only trace HTTP test-resource ownership plus documentation. Production authentication, routing, retries, and response bodies are unchanged.

The test client's urllib HTTPError is separate from the server's serialized authorization failure. Both test request helpers now close that response after decoding while preserving primary decoding errors if cleanup raises OSError. All 23 test listener teardown paths close their sockets after shutdown/join. No warning suppression or global cleanup is introduced.

Evidence

  • Parent trace singleton: 1 failed under warnings-as-errors.
  • RED checkpoint a9de9de: 8 explicit ownership regressions failed.
  • Tested source e885621: trace strict 31 passed; related strict 126 passed; full default 3670 passed, 2 skipped.
  • Full strict remains RED: 1173 failed, 2494 passed, 2 skipped, 13 errors. No target-module failure appears in the aggregate failure list; this does not establish the remaining failures' causes or a causal percentage improvement.
  • Independent read-only review found no actionable finding and reproduced 31 strict passes. This is not required GitHub approval.
  • Final head b9ad721 adds documentation only after tested e885621; tests are not relabeled as executed at this later head.

Visual inspection and limits

At b9ad721, the changed runbook, Gap baseline, AGENTS and CLAUDE sections were rendered in a real browser at 1265 x 712, English, and screenshots directly inspected. New paragraphs and the complete evidence table were readable without overlap or horizontal clipping. This is a bounded documentation inspection, not full product UI, responsive, or multilingual acceptance.

Exact-head commands, logs and limitations are in docs/doctoring/http_test_resource_lifecycle.md. Cleanup injection covers OSError after underlying close, not arbitrary exception classes or a close that cannot complete. No measured customer accuracy or decision-latency improvement is claimed. Remains Draft pending full strict remediation, required hosted checks and independent review; no merge or deployment is requested.

@coderabbitai

coderabbitai Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 16 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c7671162-f9e2-46cf-9e90-186c14e64def

📥 Commits

Reviewing files that changed from the base of the PR and between 957b174 and 3a821bf.

📒 Files selected for processing (5)
  • AGENTS.md
  • CLAUDE.md
  • docs/doctoring/http_test_resource_lifecycle.md
  • docs/product-technical-gap-baseline.md
  • tests/test_chat_include_orchestration_trace_http_honesty.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae

Copy link
Copy Markdown
Contributor Author

Restacked on the updated base branch (a675e7a9; merged codex/stream-error-resource-lifecycle-20260912 after #1140 took current main — clean, no conflicts). Local: tests/test_chat_include_orchestration_trace_http_honesty.py 31 passed, api-contract/self-check 9 passed, interrogate 100%. Still draft; carried by this session since the Codex writer went inactive 2026-09-13.

🤖 Addressed by Claude Code

Base automatically changed from codex/stream-error-resource-lifecycle-20260912 to main September 17, 2026 16:06
@seonghobae
seonghobae force-pushed the codex/trace-http-resource-successor-20260913 branch from a675e7a to 4d2f47e Compare September 17, 2026 18:31
seonghobae and others added 4 commits September 18, 2026 03:33
Main introduced test_split_token_mode without server_close; apply the PR's
listener ownership pattern so strict ResourceWarning checks stay green.

Co-authored-by: Cursor <cursoragent@cursor.com>
@seonghobae
seonghobae force-pushed the codex/trace-http-resource-successor-20260913 branch from 4d2f47e to 3a821bf Compare September 17, 2026 18:38
@seonghobae
seonghobae marked this pull request as ready for review September 17, 2026 18:43
@seonghobae
seonghobae merged commit e35bc35 into main Sep 17, 2026
21 of 25 checks passed
@seonghobae
seonghobae deleted the codex/trace-http-resource-successor-20260913 branch September 17, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant