fix(gateway): land unbounded timeout prerequisite without unfinished policy changes - #1118
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthrough기본 Changes타임아웃 동작 조정
릴리스 변경 기록
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant EmbeddingsAPI
participant contextual_orchestrator.server
participant ProviderEmbeddingBatchBackend
participant ProviderRunner
EmbeddingsAPI->>contextual_orchestrator.server: timeout 또는 None 전달
contextual_orchestrator.server->>ProviderEmbeddingBatchBackend: remaining timeout 또는 None 전달
ProviderEmbeddingBatchBackend->>ProviderRunner: provider 작업 대기
ProviderRunner-->>ProviderEmbeddingBatchBackend: 완료된 임베딩 반환
ProviderEmbeddingBatchBackend-->>EmbeddingsAPI: 임베딩 결과 반환
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Resolve the shared Fixed-section insertion conflict without choosing one runtime change over another. Keep main@9c83530f5860aaee6e324f9a84e7ce3107eeba92 CHANGELOG blob 5adce93 and move only #1118's three-line note into CHANGELOG.d/unbounded_model_timeout_prerequisite.md. All production-source blobs remain those of parent 661ce8d. No #1053 policy delta is deleted or claimed complete.
Normal two-parent integration of PR #1072 db83c06 and protected main 314645d. Base the result on the complete current main tree 05f219e and apply only the original three runner-label replacements, their two assertions/public test docstring, and the release-note fragment. This explicitly preserves #1066 trigger/admission/concurrency and all #1118/#1105/#1082 runtime changes. No force push, valid-delta discard, or transferred integrated-main test claim.
Incident prerequisite — exact head 93d56cd
The user explicitly authorized bypass merge to repair stalled contextual-orchestrator infrastructure. This PR extracts the original default-timeout repair from #1053 without also importing five unresolved findings in its later administrator-policy implementation. #1053 remains open with all later commits and findings preserved; this is a prerequisite, not a complete successor.
Provenance and conflict repair
284447fcee372437370ca86b5f6760c47f044dd2.661ce8db75460c9f5752ba1493aad026e01f5316, which already incorporates protectedmain@414f22973658c4ddc3d4320fcf7acd9b4e8ba991and retains the same eight-file +129/-29 prerequisite delta.93d56cdb79d74186ce92059883531070fb3d525a.main@9c83530f5860aaee6e324f9a84e7ce3107eeba92.CHANGELOG.mdat blob5adce934a08db3199ce9ca89cbfd7e179f2569a3and moves only the prerequisite note intoCHANGELOG.d/unbounded_model_timeout_prerequisite.md. All production-source blobs remain those of661ce8db; no runtime fix was chosen over or discarded against another.force=false. GitHub now reports mergeable. Normal merge must preserve the newer main changes, including fix(deps): pin fast-mlsirm to an immutable commit #1111, fix(gateway): keep virtual selectors on Fugu route/conduct #1094, perf(tests): stop paying the 0.5s serve_forever poll on every teardown #1078, fix(server): correlate error responses with safe request logs #1105 and fix(passthrough): record and classify ambiguous transport failures instead of leaking a 500 #1082.Bounded behavior
ModelClient and local-provider admission default to
None, rather than an implicit 90-second timeout. Equivalent-endpoint races preserveNone. Synchronous embeddings wait for provider completion without an implicit finite deadline. Durable claim leases retain a positive default independently of model waiting. Explicit caller limits and the existing discovery, readiness-probe, retention and benchmark boundaries are unchanged.No model-specific administrator policy/API, retry-policy redesign, dependency change or provider-credential change is extracted. All five unresolved finite-policy/retry findings remain in #1053.
Evidence and remaining conditions
The complete original prerequisite diff and conflict-only documentation change were reviewed. The existing ancestor had successful Security and Quality
33861876310, Security Scan33861876480and SAST33861876350, but these historical results are not integrated-main acceptance.Fresh exact-head runs are queued: Security and Quality
34420128565, Security Scan34420128552, SAST34420128631, CodeQL PR34420128617. There are no inline review threads. Queued does not mean passing; no independent approval, fresh local test run or all-checks-green result is claimed. An exception merge requires fresh post-merge integrated CI and immutable release/adoption evidence before incident restoration can be declared.Central collector compatibility #1978 and #2053 is merged. The review-sidecar runtime pin is a separate consumer change; merging this owner PR alone does not prove that deployed review requests have stopped using the older owner revision.
Summary by CodeRabbit