docs: append cross-session agent know-how on nim_benchmark date gates and review sidecar gap

[seonghobae]

Summary

Documentation-only. Appends two new AGENTS.md sections (with a pointer bullet in CLAUDE.md):

Recurring bug class: hardcoded review-cadence dates. nim_benchmark.py's fail-closed evidence gates (ACTUAL_COST_EVIDENCE["valid_until_date"], and any pricing-scenario's own valid_until_date) are deliberately literal calendar dates meant to lapse and force a human re-review — never "fix" a lapsed date by rewriting the production literal, that defeats the gate. This exact bug class has now bitten three separate test files this cycle (tests/test_nim_benchmark.py, tests/test_spend_analytics.py, tests/test_nim_benchmark_release_acceptance.py — #1070/#1071/#1075). The established fix pattern is documented: an opt-in, not autouse, current_actual_cost_evidence fixture requested by name only from tests that need to get past the gate.

Central review sidecar/egress gap (tracked, not yet closed). scripts/ci/contextual_orchestrator_review_sidecar.sh (vendored by .github's four review-pipeline consumers) still injects all five raw provider secrets, clones and builds this repo fresh on the calling runner per invocation, and runs discovery in-process there. Citations: #1041 comment 5550412102 (six requirements for the immutable release this needs), ContextualWisdomLab/.github#1759.

See the companion ContextualWisdomLab/.github PR for the shared, org-wide half of this same effort (Codex-liveness, the GitHub Project-protocol MCP capability gap, and the @openai/codex CLI-invocation finding).

Verification

• python -m pytest tests/test_nim_benchmark.py tests/test_nim_benchmark_release_acceptance.py tests/test_conventions.py -q and python -m interrogate -f 100 contextual_orchestrator/nim_benchmark.py both pass clean on this diff.
• git diff against main is strictly additive to AGENTS.md/CLAUDE.md/CHANGELOG.md; no existing line touched. No code, workflow, or test file changed.

Related

• ContextualWisdomLab/contextual-orchestrator#1041 (claimed the six-point gateway-contract work in a separate comment), #1070, #1071, #1072, #1075.
• ContextualWisdomLab/.github#1759, ContextualWisdomLab/.github#1884.

---

🤖 Generated with Claude Code

https://claude.ai/code/session_01KPmJErfkcHer4UVEgrQxUX

---

Generated by Claude Code

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}