docs(api): define durable shape evidence prerequisite - #1051
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ADR number collision:
|
| PR | File (status added) |
PR created |
|---|---|---|
| #1030 | docs/planning/adrs/0129-canonical-immutable-release.md |
2026-09-02T19:20:57Z |
| #1051 (this PR) | docs/planning/adrs/0129-durable-upstream-api-shape-evidence.md |
2026-09-04T07:53:35Z |
0129 does not exist on main, so both are genuinely new claims on the same number.
Suggested resolution — a rename, not a redesign. Two things point the same way: #1030 claimed the number first, and its PR title embeds the number (canonical immutable GitHub Release mechanism (ADR 0129)), so renumbering that one would also mean retitling it. The next free number in this series is 0130 (0124–0129 occupied).
Nothing in this PR's content is in question — only the filename and any in-document self-reference.
Note that #1030 is currently a draft. That does not change the analysis: the rule is scoped to every open PR, and a draft is open. If #1030 is later closed without merging, 0129 frees up and this PR could reclaim it.
Method / limitations, so this is checkable rather than taken on faith. ADR filenames were collected via pulls/{n}/files for every open PR and intersected by four-digit prefix; only status != "removed" entries counted. No open PR exceeds 100 changed files, so single-page pagination did not truncate the scan. main itself is clean — 38 ADRs, zero duplicate numbers. The only other collision found org-wide was 0042 (#911 vs #972), reported separately.
|
Adjudication evidence (host 1 session, 2026-09-06 KST; full report with commands in #1080). Nothing here closes, flips, or retargets anything — the decision is the opener's. ADR |
Summary
Dependency
Stacked on #1012 (
feat/chat-responses-shape-translation). This PR is a proposed prerequisite contract only and must not be treated as proof that active detection is implemented. The implementation follow-up requires the provider-catalog schema, refresh integration, agent evidence linkage, and endpoint tests listed in ADR 0129.Validation