Repository navigation
π¨ Palette: [λλκ·Έ μ€ λλ‘ μκ°μ νΌλλ°± μΆκ°] - #720
seonghobae wants to merge 1 commit into
Conversation
λλκ·Έ μ€ λλ‘ μμμ `dropEffect`λ₯Ό μΆκ°νμ¬ μ¬μ©μκ° νμΌμ λλκ·Έν λ μ ν¨ν λλ‘ λμμμ λͺ ννκ² μκ°μ μΌλ‘ μΈμ§ν μ μλλ‘ κ°μ νμ΅λλ€.
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review info
π Walkthrough
Merge Risk: βͺ Minimal Β· up to Valid drop targets retain the copy effect, while drags elsewhere receive none. No user-facing feedback regression is established, and no merge-blocking risk remains. Pre-merge checks |
|
| if (e.dataTransfer) { | ||
| e.dataTransfer.dropEffect = 'copy'; | ||
| } |
There was a problem hiding this comment.
π‘ Non-file drags show a false copy target
Dragging text over either zone makes dropEffect advertise a copy. The drop handlers ignore drags with no files, so dropping that text does nothing.
Learn more
The two upload zones accept dropped files and populate their file inputs from dataTransfer.files in the single-file drop handler and batch drop handler. A text selection or link has no files, yet its dragover event now gets the same copy cursor as a file drag. This cursor promises a successful drop where neither handler performs any action.
Example: Drag the text meeting notes from another tab onto the batch zone. The cursor displays copy, but releasing it leaves the batch input empty.
Recommended fix: Set dropEffect to copy only when the drag contains file items, using dataTransfer.items or types during dragover because external drags may not expose files until drop. Use none for other drags and keep the file drop handlers unchanged.
Was this helpful? React with π or π to provide feedback.
π‘ What: λλκ·Έ μ€ λλ‘ μμμ
dropEffect = 'copy'λ₯Ό, λ°λ μμμλdropEffect = 'none'μ μΆκ°νμ¬ λλκ·Έ μ€μΈ νμΌμ λν λͺ νν μκ°μ νΌλλ°±μ μ 곡νμ΅λλ€.π― Why: μ¬μ©μκ° νμΌμ λλ‘ μμμΌλ‘ λλκ·Έν λ μ ν¨ν λλ‘ λμμμ λνλ΄λ OS 컀μ λ³κ²½μ΄ μμ΄ νΌλμ μ€ μ μκΈ° λλ¬Έμ λλ€.
πΈ Before/After: ν΄λΉ μμ (λμ λ³κ²½).
βΏ Accessibility: λλκ·Έ μ€ λλ‘ λμμ μκ°μ λͺ νμ±μ κ°μ νμ¬ μ κ·Όμ±κ³Ό μ¬μ©μ±μ ν₯μμμΌ°μ΅λλ€.
PR created automatically by Jules for task 14524392133444402546 started by @seonghobae
Summary by CodeRabbit