Skip to content

πŸ§ͺ [ν…ŒμŠ€νŠΈ] hits.py의 μ˜ˆμ™Έ 처리 경둜 ν…ŒμŠ€νŠΈ μΆ”κ°€ #814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 2 commits into from
Closed

πŸ§ͺ [ν…ŒμŠ€νŠΈ] hits.py의 μ˜ˆμ™Έ 처리 경둜 ν…ŒμŠ€νŠΈ μΆ”κ°€ #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab0975f
ν…ŒμŠ€νŠΈ: hits.py의 μ˜ˆμ™Έ 처리 κ²½λ‘œμ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μΆ”κ°€
seonghobae Aug 9, 2026
7bd4649
ν…ŒμŠ€νŠΈ: hits.py의 μ˜ˆμ™Έ 처리 κ²½λ‘œμ— λŒ€ν•œ ν…ŒμŠ€νŠΈ μΆ”κ°€ 및 μ˜μ‘΄μ„± μ—…λ°μ΄νŠΈ
seonghobae Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/desktop/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"class-variance-authority": "^0.7.1",
"clsx": "^2.1.1",
"lucide-react": "^1.24.0",
"pdfjs-dist": "6.1.200",
"pdfjs-dist": "^6.2.108",
"react": "^19.2.4",
"react-dom": "^19.2.7",
"sonner": "^2.0.7",
Expand Down
46 changes: 10 additions & 36 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 10 additions & 0 deletions services/analysis-engine/tests/test_hits.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

from __future__ import annotations

from unittest.mock import patch

import numpy as np
from numpy.typing import NDArray

Expand Down Expand Up @@ -138,3 +140,11 @@ def test_detect_shared_hits_safe_failure_inputs() -> None:
assert detect_shared_hits({"vocals": _tone(1.0)}, 0) == []
# Non-numeric array must not raise.
assert detect_shared_hits({"vocals": np.array(["boom"])}, SR) == [] # type: ignore[dict-item]


def test_detect_shared_hits_catches_unexpected_exceptions() -> None:
"""Unexpected exceptions during shared-hit detection are caught and yield []."""
with patch(
"bandscope_analysis.temporal.hits._detect_shared_hits", side_effect=RuntimeError("Boom")
):
assert detect_shared_hits({"vocals": _tone(1.0)}, SR) == []
Loading