🎨 Palette: 향상된 접근성을 위해 아이콘 버튼에 툴팁 및 aria-disabled 적용

CHANGELOG.md

@@ -12,6 +12,7 @@
 
 - Consolidated Bandit, dependency audits, supplemental secret checks, and Trivy into one trusted-branch security backstop, delegated CodeQL to GitHub default setup, and removed duplicate local PR security and release-preflight runs.
 - Pinned npm `10.9.9` as the approved lockfile generator, activated it through Node-bundled Corepack before dependency consumption, and fail closed unless its bundled `tar` is at least `7.5.19`; primary CI still consumes the committed lock only through frozen `npm ci` validation, rejects mutable npm resolution in the lock gate, requires integrity evidence for public-registry lock entries, and preserves generator-sensitive root `@esbuild/*` peer metadata.
+- Keep unavailable Add/Open/Remove score actions and PDF pagination controls keyboard-focusable, expose their unavailable state and recovery copy to assistive technology, and prevent project-missing, pagination-boundary, or repeated in-flight attach activation at the action boundary.
 
 ### Fixed
 

apps/desktop/src/features/score/ScoreView.disabled-action-accessibility.test.tsx

@@ -0,0 +1,57 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+import type { RehearsalSong } from "@bandscope/shared-types";
+import { invoke } from "@tauri-apps/api/core";
+import { ScoreView } from "./ScoreView";
+
+vi.mock("@tauri-apps/api/core", () => ({
+  invoke: vi.fn()
+}));
+
+vi.mock("./ScoreViewer", () => ({
+  ScoreViewer: () => <div data-testid="score-viewer" />
+}));
+
+vi.mock("../../i18n", () => ({
+  createTranslator: () => (key: string) =>
+    ({
+      scoreViewTitle: "Score",
+      scoreViewSubtitle: "Attach validated PDF scores to the current song.",
+      scoreListTitle: "Attached scores",
+      scoreAttach: "Add score",
+      scoreRemove: "Remove",
+      scoreOpen: "Open score",
+      scoreRequiresProject: "Scores attach to the active analysis project.",
+      scoreNavDisabledHint: "Analyze or open a song first"
+    })[key] ?? key,
+  detectPreferredLocale: () => "en"
+}));
+
+const song = {
+  id: "song-1",
+  title: "Late Night Set",
+  scoreAttachments: [{ id: "score-1", fileName: "opener.pdf" }]
+} as RehearsalSong;
+
+describe("ScoreView unavailable action accessibility", () => {
+  it("links focusable unavailable actions to localized recovery copy and blocks activation", () => {
+    render(<ScoreView song={song} projectId={null} onSongUpdate={vi.fn()} />);
+
+    const requirement = screen.getByText("Scores attach to the active analysis project.");
+    const addButton = screen.getByRole("button", { name: "Add score" });
+    const openButton = screen.getByRole("button", { name: "Open score: opener.pdf" });
+    const removeButton = screen.getByRole("button", { name: "Remove: opener.pdf" });
+
+    for (const button of [addButton, openButton, removeButton]) {
+      expect(button).toHaveAttribute("aria-disabled", "true");
+      expect(button).toHaveAttribute("aria-describedby", requirement.id);
+      expect(button).toHaveAttribute("title", "Analyze or open a song first");
+      expect(button).not.toBeDisabled();
+    }
+
+    fireEvent.click(addButton);
+    fireEvent.click(openButton);
+    fireEvent.click(removeButton);
+    expect(vi.mocked(invoke)).not.toHaveBeenCalled();
+  });
+});

apps/desktop/src/features/score/ScoreView.enabled-action-tooltips.test.tsx

@@ -0,0 +1,39 @@
+import { render, screen } from "@testing-library/react";
+import { describe, expect, it, vi } from "vitest";
+import type { RehearsalSong } from "@bandscope/shared-types";
+import { ScoreView } from "./ScoreView";
+
+vi.mock("@tauri-apps/api/core", () => ({
+  invoke: vi.fn()
+}));
+
+vi.mock("./ScoreViewer", () => ({
+  ScoreViewer: () => <div data-testid="score-viewer">Mock Viewer</div>
+}));
+
+vi.mock("../../i18n", () => ({
+  createTranslator: () => (key: string) =>
+    ({
+      scoreOpen: "Open score",
+      scoreRemove: "Remove"
+    })[key] ?? key,
+  detectPreferredLocale: () => "en"
+}));
+
+describe("ScoreView enabled action tooltips", () => {
+  it("exposes localized pointer tooltips for enabled open and remove actions", () => {
+    const song = {
+      id: "song-1",
+      title: "Test",
+      scoreAttachments: [{ id: "doc1", fileName: "opener.pdf" }]
+    } as RehearsalSong;
+
+    render(<ScoreView song={song} projectId="project-1-2" onSongUpdate={vi.fn()} />);
+
+    expect(screen.getByRole("button", { name: "Open score: opener.pdf" })).toHaveAttribute("title", "Open score: opener.pdf");
+    expect(screen.getByRole("button", { name: "Remove: opener.pdf" })).toHaveAttribute(
+      "title",
+      "Remove: opener.pdf"
+    );
+  });
+});

apps/desktop/src/features/score/ScoreView.error-privacy.test.tsx

@@ -0,0 +1,68 @@
+import { fireEvent, render, screen } from "@testing-library/react";
+import type { RehearsalSong } from "@bandscope/shared-types";
+import { beforeEach, expect, it, vi } from "vitest";
+
+import { ScoreView } from "./ScoreView";
+import { attachScorePdf } from "./scoreStorage";
+
+vi.mock("./scoreStorage", () => ({
+  attachScorePdf: vi.fn(),
+  readScorePdf: vi.fn(),
+  removeScorePdf: vi.fn()
+}));
+
+vi.mock("./ScoreViewer", () => ({
+  ScoreViewer: () => <div data-testid="score-viewer" />
+}));
+
+vi.mock("../../i18n", () => ({
+  createTranslator: () => (key: string) =>
+    ({
+      scoreViewTitle: "Score",
+      scoreViewSubtitle: "Attach validated PDF scores to the current song.",
+      scoreListTitle: "Attached scores",
+      scoreListEmpty: "No scores attached to this song yet.",
+      scoreAttach: "Add score",
+      scoreAttaching: "Attaching...",
+      scoreRemove: "Remove",
+      scoreRemoveConfirm: "Remove {fileName} from this song?",
+      scoreOpen: "Open score",
+      scoreOpening: "Opening score PDF...",
+      scoreAttachFailed: "Could not attach the score PDF.",
+      scoreReadFailed: "Could not open the score PDF.",
+      scoreRemoveFailed: "Could not remove the score PDF.",
+      scoreRequiresProject: "Scores attach to the active analysis project.",
+      scoreNavDisabledHint: "Open an active project first."
+    })[key] ?? key,
+  detectPreferredLocale: () => "en"
+}));
+
+const mockAttachScorePdf = vi.mocked(attachScorePdf);
+
+function makeSong(): RehearsalSong {
+  return {
+    id: "song-1",
+    title: "Late Night Set",
+    sections: [],
+    exportSummary: { format: "cue-sheet", headline: "", focusSections: [] }
+  } as RehearsalSong;
+}
+
+beforeEach(() => {
+  mockAttachScorePdf.mockReset();
+});
+
+it("does not render dependency-controlled score bridge secrets or local paths", async () => {
+  mockAttachScorePdf.mockRejectedValueOnce(
+    new Error("Failed to open /Users/Alice/private-score.pdf token=super-secret")
+  );
+
+  render(<ScoreView song={makeSong()} projectId="project-1-2" onSongUpdate={vi.fn()} />);
+  fireEvent.click(screen.getByRole("button", { name: "Add score" }));
+
+  const alert = await screen.findByRole("alert");
+  expect(alert).toHaveTextContent("Could not attach the score PDF.");
+  expect(alert).not.toHaveTextContent("/Users/Alice");
+  expect(alert).not.toHaveTextContent("private-score.pdf");
+  expect(alert).not.toHaveTextContent("token=super-secret");
+});

apps/desktop/src/features/score/ScoreView.test.tsx

@@ -1,4 +1,4 @@
-import { act, fireEvent, render, screen, waitFor } from "@testing-library/react";
+import { act, createEvent, fireEvent, render, screen, waitFor } from "@testing-library/react";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import type { RehearsalSong, ScoreAttachment } from "@bandscope/shared-types";
 import { invoke } from "@tauri-apps/api/core";
@@ -90,17 +90,103 @@ describe("ScoreView", () => {
     expect(mockInvoke).not.toHaveBeenCalled();
   });
 
-  it("disables score storage actions when no project workspace is active", () => {
+  it("ignores clicks while attaching", async () => {
+    const song = makeSong([]);
+    render(<ScoreView song={song} projectId="123" onSongUpdate={vi.fn()} />);
+    const addBtn = screen.getByRole("button", { name: "Add score" });
+
+    // In our mock, attachScorePdf returns a promise.
+    // We can mock it to not resolve immediately, simulating a pending attach
+    let resolveAttach: (val: unknown) => void;
+    mockInvoke.mockReturnValueOnce(new Promise((resolve) => {
+        resolveAttach = resolve;
+    }));
+
+    await act(async () => {
+        fireEvent.click(addBtn);
+    });
+
+    // Second click should hit `!isAttaching` branch and do nothing
+    await act(async () => {
+        fireEvent.click(addBtn);
+    });
+
+    expect(mockInvoke).toHaveBeenCalledTimes(1);
+
+    // Resolve the promise to cleanup
+    await act(async () => {
+        resolveAttach({ id: "new-score", fileName: "new.pdf" });
+    });
+  });
+
+  it("keeps unavailable score storage actions focusable when no project workspace is active", () => {
     const song = makeSong([{ id: SCORE_ID, fileName: "opener.pdf" }]);
     render(<ScoreView song={song} projectId={null} onSongUpdate={vi.fn()} />);
 
     expect(screen.getByText("Scores attach to the active analysis project.")).toBeInTheDocument();
-    expect(screen.getByRole("button", { name: "Add score" })).toBeDisabled();
-    expect(screen.getByRole("button", { name: "Open score: opener.pdf" })).toBeDisabled();
-    expect(screen.getByRole("button", { name: "Remove: opener.pdf" })).toBeDisabled();
 
-    fireEvent.click(screen.getByRole("button", { name: "Open score: opener.pdf" }));
+    const addBtn = screen.getByRole("button", { name: "Add score" });
+    expect(addBtn).toHaveAttribute("aria-disabled", "true");
+    expect(addBtn).toHaveAttribute("aria-describedby");
+    expect(addBtn).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");
+    expect(addBtn).toHaveAttribute("title", "scoreNavDisabledHint");
+    expect(addBtn).not.toBeDisabled();
+
+    const openBtn = screen.getByRole("button", { name: "Open score: opener.pdf" });
+    expect(openBtn).toHaveAttribute("aria-disabled", "true");
+    expect(openBtn).toHaveAttribute("aria-describedby");
+    expect(openBtn).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");
+    expect(openBtn).toHaveAttribute("title", "scoreNavDisabledHint");
+
+    const removeBtn = screen.getByRole("button", { name: "Remove: opener.pdf" });
+    expect(removeBtn).toHaveAttribute("aria-disabled", "true");
+    expect(removeBtn).toHaveAttribute("aria-describedby");
+    expect(removeBtn).toHaveClass("aria-disabled:cursor-not-allowed", "aria-disabled:opacity-60");
+    expect(removeBtn).toHaveAttribute("title", "scoreNavDisabledHint");
+
+    const addClickEvent = createEvent.click(addBtn);
+    fireEvent(addBtn, addClickEvent);
+    expect(addClickEvent.defaultPrevented).toBe(true);
+    expect(mockInvoke).not.toHaveBeenCalled();
+
+    const openClickEvent = createEvent.click(openBtn);
+    fireEvent(openBtn, openClickEvent);
+    expect(openClickEvent.defaultPrevented).toBe(true);
     expect(mockInvoke).not.toHaveBeenCalled();
+
+    const clickEvent = createEvent.click(removeBtn);
+    fireEvent(removeBtn, clickEvent);
+    expect(clickEvent.defaultPrevented).toBe(true);
+  });
+
+  it("blocks repeated attach activation while an attach is already pending", async () => {
+    let resolveAttach!: (value: unknown) => void;
+    mockInvoke
+      .mockImplementationOnce(() => new Promise((resolve) => { resolveAttach = resolve; }))
+      .mockResolvedValueOnce([1, 2, 3]);
+    const onSongUpdate = vi.fn();
+
+    render(<ScoreView song={makeSong()} projectId="project-1-2" onSongUpdate={onSongUpdate} />);
+
+    const addBtn = screen.getByRole("button", { name: "Add score" });
+    fireEvent.click(addBtn);
+
+    await waitFor(() => {
+      expect(addBtn).toHaveAttribute("aria-disabled", "true");
+    });
+
+    const repeatedClick = createEvent.click(addBtn);
+    fireEvent(addBtn, repeatedClick);
+    expect(repeatedClick.defaultPrevented).toBe(true);
+    expect(mockInvoke).toHaveBeenCalledTimes(1);
+
+    resolveAttach(attachResponse());
+
+    await waitFor(() => {
+      expect(screen.getByTestId("score-viewer")).toHaveTextContent("bytes:3:opener.pdf");
+    });
+    expect(mockInvoke).toHaveBeenCalledTimes(2);
+    expect(onSongUpdate).toHaveBeenCalledTimes(1);
   });
 
   it("attaches a score, persists the metadata, and opens the new PDF", async () => {