⚡ Bolt: Use O(1) dictionary for deduplication in chart export

[seonghobae]

💡 What: The optimization replaces O(N^2) list membership checks (if x not in lst: lst.append(x)) with O(N) dictionary assignments.
🎯 Why: Iterating over an array to check for membership adds unnecessary complexity inside of loops. Using dictionary keys for deduplication takes advantage of O(1) hash map lookups. Since Python 3.7+ guarantees dictionary insertion order, this is a 1-to-1 functional replacement.
📊 Impact: Reduces algorithmic complexity from O(N^2) to O(N) for extracting unique role IDs, names, cues, and priorities in the chart export functions.
🔬 Measurement: Verified via unit tests (uv run pytest). Code execution maintains original output order while utilizing faster memory lookups.

---

PR created automatically by Jules for task 17521815069165649247 started by @seonghobae

Summary by CodeRabbit

• 성능 개선

  • 분석 처리 중 중복 항목을 정리하는 작업의 효율성이 향상되었습니다.
  • 데이터가 많거나 반복 처리가 필요한 경우 처리 시간이 줄어들 수 있습니다.
  • 기존 결과의 내용과 표시 순서는 변경되지 않았습니다.

• 문서화

  • Python 환경에서 목록 중복 제거를 효율적으로 처리하는 방법에 대한 학습 자료가 추가되었습니다.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: a74d8d89-92c1-4694-9cb0-bc067f9a433c

📥 Commits

Reviewing files that changed from the base of the PR and between 889d782 and b67f287.

📒 Files selected for processing (2)

• .jules/bolt.md
• services/analysis-engine/src/bandscope_analysis/exports/chart.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

차트 내보내기 헬퍼 3개의 중복 제거 로직을 사전 키 기반 방식으로 변경했다. 삽입 순서와 출력값은 유지된다. 동일한 알고리즘 원리를 .jules/bolt.md에 기록했다.

Changes

중복 제거 알고리즘 최적화

Layer / File(s)	Summary
사전 키 기반 중복 제거 구현 및 기록 .jules/bolt.md, services/analysis-engine/src/bandscope_analysis/exports/chart.py	활성 역할 ID, 역할 이름, 섹션 큐, 우선순위 항목을 사전 키로 중복 제거하도록 변경했다. list(...keys())로 기존 삽입 순서와 출력값을 유지한다. 해당 O(N) 패턴을 학습 문서에 추가했다.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to b67f2

Chart exports now deduplicate role and priority values more efficiently while preserving output order and content. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 chart export에서 목록 기반 중복 제거를 dictionary 기반 방식으로 변경하는 핵심 내용을 명확하게 요약합니다. 변경 목적과 대상이 모두 포함되어 있습니다.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 6 functions across 1 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch bolt-optimize-chart-export-17521815069165649247

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Consolidating this micro-PR into canonical chart-export owner #1076 rather than creating a second writer.

Exact comparison at #1161 head b67f287c7208545c9bfea488d629be88235869fb shows the production delta is the same four list→insertion-ordered-dict substitutions already owned by #1076. #1076 has now been non-force restacked onto protected develop@889d782e88b4df28dcbb4ae3cfd6d99ef85d9844 at exact head b0d403ee0e9b7849b74ac5e8afe3e42d424106c2, behind_by=0.

The #1161 form is not a safe successor by itself: it puts arbitrary str subclasses directly into dict keys and still evaluates caller-controlled string-subclass truthiness. The canonical branch normalizes through _hashable_text and carries regressions for unhashable string subclasses, hashable subclasses, truthiness-overriding subclasses, duplicate role ids/display names/cues/priorities, plus the Unreleased changelog entry. #1076 also already contains the .jules/bolt.md learning note for order-preserving dictionary de-duplication, so #1161 has no remaining unique documentation/evidence delta.

No #1161 checks, reviews, or other head-bound receipts transfer to #1076. Closing unmerged as complete semantic succession, not as a discard of valid product behavior.

[google-labs-jules]

Consolidating this micro-PR into canonical chart-export owner #1076 rather than creating a second writer.

Exact comparison at #1161 head b67f287c7208545c9bfea488d629be88235869fb shows the production delta is the same four list→insertion-ordered-dict substitutions already owned by #1076. #1076 has now been non-force restacked onto protected develop@889d782e88b4df28dcbb4ae3cfd6d99ef85d9844 at exact head b0d403ee0e9b7849b74ac5e8afe3e42d424106c2, behind_by=0.

The #1161 form is not a safe successor by itself: it puts arbitrary str subclasses directly into dict keys and still evaluates caller-controlled string-subclass truthiness. The canonical branch normalizes through _hashable_text and carries regressions for unhashable string subclasses, hashable subclasses, truthiness-overriding subclasses, duplicate role ids/display names/cues/priorities, plus the Unreleased changelog entry. #1076 also already contains the .jules/bolt.md learning note for order-preserving dictionary de-duplication, so #1161 has no remaining unique documentation/evidence delta.

No #1161 checks, reviews, or other head-bound receipts transfer to #1076. Closing unmerged as complete semantic succession, not as a discard of valid product behavior.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.