Skip to content

feat(workspace): open tonight's first part from the range card - #1142

Open
seonghobae wants to merge 1 commit into
feat/workspace-find-first-range-sectionfrom
feat/workspace-open-first-range-part
Open

feat(workspace): open tonight's first part from the range card#1142
seonghobae wants to merge 1 commit into
feat/workspace-find-first-range-sectionfrom
feat/workspace-open-first-range-part

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Product outcome

The ready map already names tonight's first playable range. Players still had to hunt RoleSwitcher to hear that part. From the full-band view, the range card now offers Open {role} on the map. That control selects the named part so the player can hear it, then the existing instrument-check copy remains the next action.

Exact head: aa604734baebec68b25134397fd215b7a0b64e4d on feat/workspace-open-first-range-part, based on develop@749511c3ad4000090048718f685c6bee6b3d2c25.

This slice is UI-only. It does not mix:

Behavior

  • firstRangeOpenPart returns the squeeze only when the named role exists in the switcher and is not already selected.
  • Missing span, missing role, or already-selected role: fail closed (no button).
  • English: Open {roleName} on the map
  • Korean: 지도에서 {roleName} 열기

Tests

npm --workspace @bandscope/desktop exec --force -- vitest run firstRangeSqueeze.test.ts Workspace.test.tsx — 2 files, 34 tests passed.

Security Notes

UI-only. No file paths, URLs, subprocesses, or new network. Does not change the #783 npm HIGH baseline. Does not suppress Dependabot.

i18n

EN + KO keys for the open-part control. Customer-facing copy names the part and enables the next action.

Do not self-approve. Merge only with an independent non-author APPROVE on this exact head plus required-gate success. Queue/pending/skipped/cancelled is non-passing.


Devin Review

The ready map already names tonight's first playable range. A player
still had to hunt that part in the role switcher before they could
check the span. Offer one control that opens the named part, then keep
the instrument check as the next action.
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

Next included review available in 18 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 42bdf9bd-8d37-4bae-a37b-2b316360740f

📥 Commits

Reviewing files that changed from the base of the PR and between 749511c and aa60473.

📒 Files selected for processing (10)
  • AGENTS.md
  • ARCHITECTURE.md
  • CHANGELOG.md
  • CLAUDE.md
  • apps/desktop/src/features/workspace/Workspace.test.tsx
  • apps/desktop/src/features/workspace/Workspace.tsx
  • apps/desktop/src/features/workspace/firstRangeSqueeze.test.ts
  • apps/desktop/src/features/workspace/firstRangeSqueeze.ts
  • apps/desktop/src/locales/en/common.json
  • apps/desktop/src/locales/ko/common.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

@seonghobae seonghobae added enhancement New feature or request priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: feature New or expanded product capability labels Sep 2, 2026 — with ChatGPT Codex Connector
@seonghobae
seonghobae changed the base branch from develop to feat/workspace-find-first-range-section September 2, 2026 15:42

Copy link
Copy Markdown
Collaborator Author

Preservation child of canonical first-range navigation owner #1143. The base is intentionally retargeted to feat/workspace-find-first-range-section@ce6c8fcf11b4191c2925324f7b8ac2a1b086484f so this sibling cannot be integrated independently as another same-boundary writer.

Keep the unique firstRangeOpenPart / RoleSwitcher behavior, its fail-closed admission cases, EN/KO copy, and focused tests until #1143 (or its verified successor) actually contains equivalent production behavior and regression evidence. Current overlapping-file conflicts are repair findings, not grounds to drop this delta or close the PR. Predecessor checks/reviews do not transfer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work status: needs-review Open pull request requiring current-head review or checks type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant