Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# AGENTS.md

## Project overview
- BandScope is a local-first desktop app for rehearsal prep: a practical song view with likely harmony by section and by instrument or vocal role, form and groove cues, stems, playable ranges, simplification guidance, transposition or setup cues, part-overlap cues, visible confidence, and rehearsal priorities.
- BandScope is a local-first desktop app for rehearsal prep: a practical song view with likely harmony by section and by instrument or vocal role, form and groove cues, stems, playable ranges, simplification guidance, transposition or setup cues, part-overlap cues, visible confidence (including tonight's first confidence change and the next ear check), and rehearsal priorities.
- Authoritative delivery rules live in `ARCHITECTURE.md`, `docs/plans/`, and the root verification scripts.
- Brand, tone, UX copy, and prioritization rules live in `docs/brand-story.md` and must be applied to PRDs, TRDs, UI copy, onboarding, empty states, and error messages.
- App security rules live in `docs/security/app-security.md` and must be applied to file handling, URL intake, subprocesses, IPC, WebView usage, model loading, updates, logging, cache handling, and export behavior.
Expand Down
2 changes: 1 addition & 1 deletion ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ Last updated: 2026-03-11
- groove and timing cues relevant to locking the band together
- playable ranges and density or overlap warnings, with the ready workspace naming tonight's first span and the next instrument check
- simplification, transposition, capo, tuning, or setup cues where applicable
- role-specific rehearsal priorities and confidence flags
- role-specific rehearsal priorities and confidence flags, with the ready workspace naming tonight's first confidence change and the next ear check
- cue-sheet or chart-style exports that summarize the analysis in rehearsal-friendly form

## Confidence, edits, and provenance
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Added

- Name tonight's first playable range on the ready rehearsal map and tell the player to check that span on their instrument before the section.
- Name tonight's first confidence change on the ready rehearsal map and tell the player to confirm that section by ear before counting in.
- Display the analyzed song tempo (BPM) as a badge in the rehearsal workspace.
- 각 합주 역할(Role)별 개인 연습 진행도를 0~100% 범위로 기록 및 시각화할 수 있는 연습 진척도(`practiceProgress`) 트래커 기능 추가. UI 컨트롤(슬라이더 및 +/- 버튼)과 한/영 다국어 지원 포함.

Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ BandScope is a local-first desktop app for rehearsal prep: it turns a song into

Three layers, decoupled through shared contracts:

- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and the next instrument check, plus tonight's first confidence change and the next ear check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
- `apps/desktop/src-tauri/src/main.rs` — the Rust orchestration boundary. Tauri commands (`start_analysis_job`, `get_analysis_job_status`, `select_local_audio_source`, `import_youtube_url`) validate untrusted input (project IDs, file paths, URLs) and spawn the Python engine as a subprocess. There is no loopback HTTP listener and no network path for local analysis.
- `services/analysis-engine` — Python package `bandscope_analysis` (librosa/numpy). Entry point `cli.py` reads a JSON job request on stdin and prints a structured job-status JSON envelope on stdout (`--progress-jsonl` streams progress lines). `api.py` orchestrates the pipeline across the `separation`, `sections`, `roles`, `chords`, `ranges`, `temporal`, `transcription`, and `youtube` modules.

Expand Down
41 changes: 41 additions & 0 deletions apps/desktop/src/features/workspace/SectionRoadmap.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,47 @@ describe("SectionRoadmap", () => {
expect(screen.getAllByText("음역").length).toBeGreaterThan(0);
expect(screen.getByText("C#2 — E3")).toBeTruthy();
expect(screen.getAllByText("verse 들어가기 전에 이 음역을 악기로 확인해 보세요.").length).toBeGreaterThan(0);
expect(screen.getByText("verse 들어가기 전에 이 중간 읽기를 귀로 확인해 보세요.")).toBeTruthy();
});

it("names the next ear check on the section where confidence changes", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
const verse = song.sections[0]!;
song.sections = [
verse,
{
...verse,
id: "chorus-1",
label: "chorus",
confidence: { ...verse.confidence, level: "low" },
roles: verse.roles.map((role) => ({ ...role, id: `${role.id}-chorus` }))
}
];

render(<SectionRoadmap song={song} activeRole={null} />);

expect(screen.queryByTestId("confidence-next-action-verse-1")).toBeNull();
expect(screen.getByTestId("confidence-next-action-chorus-1")).toHaveTextContent(
"Confirm this section by ear before chorus."
);
});

it("marks only the destination card when consecutive sections share a label", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
const verse = song.sections[0]!;
song.sections = [
{ ...verse, id: "verse-a", label: "verse", confidence: { ...verse.confidence, level: "medium" } },
{ ...verse, id: "verse-b", label: "verse", confidence: { ...verse.confidence, level: "low" } }
];

render(<SectionRoadmap song={song} activeRole={null} />);

expect(screen.queryByTestId("confidence-next-action-verse-a")).toBeNull();
expect(screen.getByTestId("confidence-next-action-verse-b")).toHaveTextContent(
"Confirm this section by ear before verse."
);
});

it("omits the range row when both notes are unnamed", () => {
Expand Down
10 changes: 10 additions & 0 deletions apps/desktop/src/features/workspace/SectionRoadmap.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useId, useMemo } from "react";
import { createTranslator, detectPreferredLocale } from "../../i18n";
import { ConfidenceBadge } from "./ConfidenceBadge";
import { fillRangeCopy, playableRange } from "./firstRangeSqueeze";
import { confidenceWordKey, fillConfidenceCopy, firstConfidenceChange, isConfidenceChangeTarget } from "./firstConfidenceChange";
import { Card, CardContent, CardHeader } from "@/components/ui/card";
import { Badge } from "@/components/ui/badge";
import { Separator } from "@/components/ui/separator";
Expand All @@ -19,6 +20,7 @@ export function SectionRoadmap({ song, activeRole, onSongUpdate }: SectionRoadma
const sectionRoadmapTitleId = useId();
const locale = useMemo(() => detectPreferredLocale(), []);
const t = useMemo(() => createTranslator(locale), [locale]);
const confidenceChange = useMemo(() => firstConfidenceChange(song), [song]);

/** Documented. */
const editChordLabel = (role: RehearsalRole, sectionLabel: string): string => {
Expand Down Expand Up @@ -120,6 +122,14 @@ export function SectionRoadmap({ song, activeRole, onSongUpdate }: SectionRoadma
<span className="mr-2 text-[0.65rem] font-bold uppercase tracking-wider text-slate-400">{t("sectionGrooveLabel")}</span>
{section.groove}
</div>
{confidenceChange && isConfidenceChangeTarget(confidenceChange, section.id) ? (
<p className="mt-2 text-xs font-medium text-amber-200" data-testid={`confidence-next-action-${section.id}`}>
{fillConfidenceCopy(
t(confidenceChange.kind === "change" ? "sectionConfidenceNextActionChange" : "sectionConfidenceNextActionHold"),
{ sectionLabel: section.label, level: t(confidenceWordKey(confidenceChange.toLevel)) }
)}
</p>
) : null}
</CardHeader>

<CardContent className="p-4 space-y-4">
Expand Down
48 changes: 48 additions & 0 deletions apps/desktop/src/features/workspace/Workspace.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,41 @@ describe("Workspace", () => {
);
});

it("names tonight's held confidence and the next ear check when the form does not change", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();

render(<Workspace song={song} />);

const callout = screen.getByTestId("first-confidence-change");
expect(callout).toHaveTextContent("Tonight's first confidence change");
expect(callout).toHaveTextContent(
"Tonight's confidence stays medium through the form. Confirm the verse by ear before you count in."
);
});

it("names tonight's first confidence change and the next ear check", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
const verse = song.sections[0]!;
song.sections = [
verse,
{
...verse,
id: "chorus-1",
label: "chorus",
confidence: { ...verse.confidence, level: "low" },
roles: verse.roles.map((role) => ({ ...role, id: `${role.id}-chorus` }))
}
];

render(<Workspace song={song} />);

expect(screen.getByTestId("first-confidence-change")).toHaveTextContent(
"Confidence changes at chorus: low, after verse's medium. Confirm the chorus by ear before you count in."
);
});

it("asks for an ear check when the selected part has no named span", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
Expand Down Expand Up @@ -325,5 +360,18 @@ describe("Workspace", () => {
expect(screen.getByText("스템")).toBeTruthy();
expect(screen.getByText("합주 우선순위")).toBeTruthy();
expect(screen.getByText("역할과 화성")).toBeTruthy();
expect(screen.getByText("오늘 먼저 바뀌는 확신")).toBeTruthy();
});

it("asks for an ear check when no named section confidence exists", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
song.sections[0] = { ...song.sections[0]!, label: " ", confidence: { ...song.sections[0]!.confidence, level: "ready" as "low" } };

render(<Workspace song={song} />);

expect(screen.getByTestId("first-confidence-change")).toHaveTextContent(
"Tonight's first confidence change still needs an ear check. Confirm how sure the first two sections are before you count in."
);
});
});
24 changes: 24 additions & 0 deletions apps/desktop/src/features/workspace/Workspace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { SectionRoadmap } from "./SectionRoadmap";
import { GrooveMap } from "./GrooveMap";
import { PracticeProgress } from "./PracticeProgress";
import { fillRangeCopy, firstRangeSqueeze } from "./firstRangeSqueeze";
import { confidenceWordKey, fillConfidenceCopy, firstConfidenceChange } from "./firstConfidenceChange";
import { createTranslator, detectPreferredLocale } from "../../i18n";
import { generateCueSheetCsv, generateChartSummaryJson, generateMetadataHandoffJson, sanitizeFilename } from "../../lib/export";
import { Button } from "@/components/ui/button";
Expand Down Expand Up @@ -163,6 +164,20 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
}
)
: t("workspaceFirstRangeMissing");
const firstConfidence = useMemo(() => firstConfidenceChange(song), [song]);
const firstConfidenceCopy = firstConfidence
? firstConfidence.kind === "change"
? fillConfidenceCopy(t("workspaceFirstConfidenceChange"), {
fromSection: firstConfidence.fromSectionLabel,
fromLevel: t(confidenceWordKey(firstConfidence.fromLevel)),
toSection: firstConfidence.toSectionLabel,
toLevel: t(confidenceWordKey(firstConfidence.toLevel))
})
: fillConfidenceCopy(t("workspaceFirstConfidenceHold"), {
sectionLabel: firstConfidence.toSectionLabel,
level: t(confidenceWordKey(firstConfidence.toLevel))
})
: t("workspaceFirstConfidenceMissing");

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Empty songs request nonexistent sections

When a song has no sections, the fallback asks users to compare the first two. The workspace presents an impossible rehearsal action.

Prompt for agents
Make the missing-confidence fallback in apps/desktop/src/features/workspace/Workspace.tsx distinguish an empty form from forms with unusable confidence evidence. Add localized English and Korean copy for the empty-form case that does not reference nonexistent sections, and cover the zero-section Workspace state with a regression test.
Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.


/** Handle the practice progress change internally by immutably updating the song state. */
const handlePracticeProgressChange = (newProgress: number) => {
Expand Down Expand Up @@ -310,6 +325,15 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
<p className="mt-2 text-sm leading-6 text-slate-100">{firstRangeCopy}</p>
</section>

<section
className="rounded-2xl border border-amber-300/20 bg-amber-300/[0.07] p-4"
data-testid="first-confidence-change"
aria-label={t("workspaceFirstConfidenceTitle")}
>
<p className="text-xs font-black uppercase tracking-[0.24em] text-amber-200">{t("workspaceFirstConfidenceTitle")}</p>
<p className="mt-2 text-sm leading-6 text-slate-100">{firstConfidenceCopy}</p>
</section>

<div className="grid gap-4 md:grid-cols-2 xl:grid-cols-4">
<section className="rounded-2xl border border-cyan-300/20 bg-cyan-300/[0.06] p-4 md:col-span-2">
<p className="text-xs font-black uppercase tracking-[0.24em] text-cyan-300">{t("workspaceSongTimelineLabel")}</p>
Expand Down
Loading
Loading