Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
90b8023
feat(workspace): name tonight's first leftover last-return on the map
seonghobae Aug 31, 2026
50438af
chore: write-scope probe (delete after)
seonghobae Aug 31, 2026
79b02ec
chore: remove write-scope probe
seonghobae Aug 31, 2026
681b071
chore: write-probe (delete immediately)
seonghobae Aug 31, 2026
538139e
chore: remove write-probe (no product change)
seonghobae Aug 31, 2026
4b8dd2e
test(workspace): cover leftover last-return ambiguity
seonghobae Aug 31, 2026
657e078
test(workspace): reject concurrent dropout on final return
seonghobae Aug 31, 2026
dcc69fc
fix(workspace): disambiguate leftover last-return tracking
seonghobae Aug 31, 2026
ae11170
fix(workspace): preserve later last-return search
seonghobae Aug 31, 2026
35a34df
test(workspace): reject internal last-return jargon
seonghobae Aug 31, 2026
ae4f9a2
test(workspace): reject transient dropouts during remaining return
seonghobae Aug 31, 2026
9e126dd
fix(workspace): invalidate transient dropouts during final re-entry
seonghobae Aug 31, 2026
7de9948
test(workspace): align selected-role transient-dropout contract
seonghobae Aug 31, 2026
28dc156
docs(workspace): define transient-dropout final re-entry contract
seonghobae Aug 31, 2026
716d42b
fix(i18n): use rehearsal-facing final re-entry copy
seonghobae Aug 31, 2026
0215a7f
fix(i18n): align Korean final re-entry action copy
seonghobae Aug 31, 2026
4f2d999
test(i18n): align Korean final re-entry title
seonghobae Aug 31, 2026
09b32bf
test(workspace): align final re-entry rehearsal copy
seonghobae Aug 31, 2026
837204d
test(workspace): make tied-return fixture use real roles
seonghobae Aug 31, 2026
fcf201a
test(workspace): preserve unrelated-return scenario with valid roles
seonghobae Aug 31, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# AGENTS.md

## Project overview
- BandScope is a local-first desktop app for rehearsal prep: a practical song view with likely harmony by section and by instrument or vocal role, form and groove cues, stems, playable ranges, simplification guidance, transposition or setup cues, part-overlap cues, visible confidence, and rehearsal priorities.
- BandScope is a local-first desktop app for rehearsal prep: a practical song view with likely harmony by section and by instrument or vocal role, form and groove cues, stems, playable ranges, leftover last-return cues after remaining leftover, simplification guidance, transposition or setup cues, part-overlap cues, visible confidence, and rehearsal priorities.
- Authoritative delivery rules live in `ARCHITECTURE.md`, `docs/plans/`, and the root verification scripts.
- Brand, tone, UX copy, and prioritization rules live in `docs/brand-story.md` and must be applied to PRDs, TRDs, UI copy, onboarding, empty states, and error messages.
- App security rules live in `docs/security/app-security.md` and must be applied to file handling, URL intake, subprocesses, IPC, WebView usage, model loading, updates, logging, cache handling, and export behavior.
Expand Down
2 changes: 1 addition & 1 deletion ARCHITECTURE.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ Last updated: 2026-03-11
- likely harmony by section and by role
- section roadmap with entries, dropouts, pickups, stops, tags, and handoffs
- groove and timing cues relevant to locking the band together
- playable ranges and density or overlap warnings, with the ready workspace naming tonight's first span and the next instrument check
- playable ranges and density or overlap warnings, with the ready workspace naming tonight's first span and tonight's first leftover last-return after remaining leftover
- simplification, transposition, capo, tuning, or setup cues where applicable
- role-specific rehearsal priorities and confidence flags
- cue-sheet or chart-style exports that summarize the analysis in rehearsal-friendly form
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

### Added

- Name tonight's first leftover last-return on the ready rehearsal map and tell the leftover part to come in last, or the band to count that leftover part in, after remaining leftover.
- Name tonight's first playable range on the ready rehearsal map and tell the player to check that span on their instrument before the section.
- Display the analyzed song tempo (BPM) as a badge in the rehearsal workspace.
- 각 합주 역할(Role)별 개인 연습 진행도를 0~100% 범위로 기록 및 시각화할 수 있는 연습 진척도(`practiceProgress`) 트래커 기능 추가. UI 컨트롤(슬라이더 및 +/- 버튼)과 한/영 다국어 지원 포함.
Expand Down
2 changes: 1 addition & 1 deletion CLAUDE.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ BandScope is a local-first desktop app for rehearsal prep: it turns a song into

Three layers, decoupled through shared contracts:

- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and the next instrument check. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
- `apps/desktop` — Tauri 2 + Vite + React 19 shell (Tailwind 4, Base UI, Storybook). Feature screens live in `src/features/` (home, workspace, chords, ranges, player, settings). The ready workspace names tonight's first playable range and tonight's first leftover last-return after remaining leftover. `src/lib/analysis.ts` and `src/lib/job_runner.ts` call typed Tauri IPC commands, with a browser fallback that serves demo data when not running inside Tauri.
- `apps/desktop/src-tauri/src/main.rs` — the Rust orchestration boundary. Tauri commands (`start_analysis_job`, `get_analysis_job_status`, `select_local_audio_source`, `import_youtube_url`) validate untrusted input (project IDs, file paths, URLs) and spawn the Python engine as a subprocess. There is no loopback HTTP listener and no network path for local analysis.
- `services/analysis-engine` — Python package `bandscope_analysis` (librosa/numpy). Entry point `cli.py` reads a JSON job request on stdin and prints a structured job-status JSON envelope on stdout (`--progress-jsonl` streams progress lines). `api.py` orchestrates the pipeline across the `separation`, `sections`, `roles`, `chords`, `ranges`, `temporal`, `transcription`, and `youtube` modules.

Expand Down
128 changes: 127 additions & 1 deletion apps/desktop/src/features/workspace/Workspace.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,132 @@ describe("Workspace", () => {
expect(screen.getByText(/Verse harmony pass/i)).toBeTruthy();
});

it("names tonight's first leftover last-return after remaining leftover", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
const verse = song.sections[0]!;
song.sections = [
{
...verse,
partGraph: verse.partGraph.map((node) =>
node.role_id === "bass-guitar" ||
node.role_id === "keys-right" ||
node.role_id === "lead-vocal"
? { ...node, is_active: false }
: node
)
},
{
...verse,
id: "chorus-1",
label: "chorus",
timeRange: { start: verse.timeRange.end, end: verse.timeRange.end + 20 },
partGraph: verse.partGraph.map((node) =>
node.role_id === "keys-right" || node.role_id === "lead-vocal"
? { ...node, is_active: false }
: node
)
},
{
...verse,
id: "bridge-1",
label: "bridge",
timeRange: {
start: verse.timeRange.end + 20,
end: verse.timeRange.end + 40
},
partGraph: verse.partGraph.map((node) =>
node.role_id === "lead-vocal" ? { ...node, is_active: false } : node
)
},
{
...verse,
id: "outro-1",
label: "outro",
timeRange: {
start: verse.timeRange.end + 40,
end: verse.timeRange.end + 60
}
}
];

render(<Workspace song={song} />);

const callout = screen.getByTestId("first-leftover-last-return");
expect(callout).toHaveTextContent("Tonight's first final re-entry");
expect(callout).toHaveTextContent(
"Lead Vocal is the last part back at outro; the others started returning at bridge. Count Lead Vocal in from the top of outro."
);
});

it("tells the leftover last-return to come in from the leftover last-return", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
const verse = song.sections[0]!;
song.sections = [
{
...verse,
partGraph: verse.partGraph.map((node) =>
node.role_id === "bass-guitar" ||
node.role_id === "keys-right" ||
node.role_id === "lead-vocal"
? { ...node, is_active: false }
: node
)
},
{
...verse,
id: "chorus-1",
label: "chorus",
timeRange: { start: verse.timeRange.end, end: verse.timeRange.end + 20 },
partGraph: verse.partGraph.map((node) =>
node.role_id === "keys-right" || node.role_id === "lead-vocal"
? { ...node, is_active: false }
: node
)
},
{
...verse,
id: "bridge-1",
label: "bridge",
timeRange: {
start: verse.timeRange.end + 20,
end: verse.timeRange.end + 40
},
partGraph: verse.partGraph.map((node) =>
node.role_id === "lead-vocal" ? { ...node, is_active: false } : node
)
},
{
...verse,
id: "outro-1",
label: "outro",
timeRange: {
start: verse.timeRange.end + 40,
end: verse.timeRange.end + 60
}
}
];

render(<Workspace song={song} />);
fireEvent.click(screen.getByRole("tab", { name: "Lead Vocal" }));

expect(screen.getByTestId("first-leftover-last-return")).toHaveTextContent(
"Lead Vocal is the last part back at outro; the others started returning at bridge. Come in from the top of outro."
);
});

it("asks the player to confirm the leftover last-return when every part stays active", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();

render(<Workspace song={song} />);

expect(screen.getByTestId("first-leftover-last-return")).toHaveTextContent(
"No final re-entry is confirmed yet. Before the first section, check which part returns last after the band begins coming back in."
);
});

it("names tonight's first playable range and the next instrument check", () => {
setNavigatorLanguage("en-US");
const song = createDemoRehearsalSong();
Expand Down Expand Up @@ -326,4 +452,4 @@ describe("Workspace", () => {
expect(screen.getByText("합주 우선순위")).toBeTruthy();
expect(screen.getByText("역할과 화성")).toBeTruthy();
});
});
});
27 changes: 27 additions & 0 deletions apps/desktop/src/features/workspace/Workspace.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { SectionRoadmap } from "./SectionRoadmap";
import { GrooveMap } from "./GrooveMap";
import { PracticeProgress } from "./PracticeProgress";
import { fillRangeCopy, firstRangeSqueeze } from "./firstRangeSqueeze";
import { firstLeftoverLastReturn } from "./firstLeftoverLastReturn";
import { createTranslator, detectPreferredLocale } from "../../i18n";
import { generateCueSheetCsv, generateChartSummaryJson, generateMetadataHandoffJson, sanitizeFilename } from "../../lib/export";
import { Button } from "@/components/ui/button";
Expand Down Expand Up @@ -163,6 +164,24 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
}
)
: t("workspaceFirstRangeMissing");
const namedLeftoverLastReturn = useMemo(
() => firstLeftoverLastReturn(song, activeRole),
[activeRole, song]
);
const firstLeftoverLastReturnCopy = namedLeftoverLastReturn
? fillRangeCopy(
t(
activeRole && activeRole === namedLeftoverLastReturn.lastRoleId
? "workspaceFirstLeftoverLastReturnComeIn"
: "workspaceFirstLeftoverLastReturnNamed"
),
{
lastRoleName: namedLeftoverLastReturn.lastRoleName,
sectionLabel: namedLeftoverLastReturn.sectionLabel,
remainingSectionLabel: namedLeftoverLastReturn.remainingSectionLabel
}
)
: t("workspaceFirstLeftoverLastReturnMissing");

/** Handle the practice progress change internally by immutably updating the song state. */
const handlePracticeProgressChange = (newProgress: number) => {
Expand Down Expand Up @@ -309,6 +328,14 @@ export function Workspace({ song, sourceBootstrap = null, onSongUpdate }: Worksp
<p className="text-xs font-black uppercase tracking-[0.24em] text-fuchsia-200">{t("workspaceFirstRangeTitle")}</p>
<p className="mt-2 text-sm leading-6 text-slate-100">{firstRangeCopy}</p>
</section>
<section
className="rounded-2xl border border-orange-300/20 bg-orange-300/[0.07] p-4"
data-testid="first-leftover-last-return"
aria-label={t("workspaceFirstLeftoverLastReturnTitle")}
>
<p className="text-xs font-black uppercase tracking-[0.24em] text-orange-200">{t("workspaceFirstLeftoverLastReturnTitle")}</p>
<p className="mt-2 text-sm leading-6 text-slate-100">{firstLeftoverLastReturnCopy}</p>
</section>

<div className="grid gap-4 md:grid-cols-2 xl:grid-cols-4">
<section className="rounded-2xl border border-cyan-300/20 bg-cyan-300/[0.06] p-4 md:col-span-2">
Expand Down
Loading
Loading