feat(workspace): name tonight's first breakdown plan on the map

[seonghobae]

Buyer-visible next action

This PR names tonight's first breakdown plan on the rehearsal map when an active part stays in after a density drop: previous graph ≥3 distinct sources, current graph 1–2 of those same staying sources, no new entrance, not a full stop. Open scrolls that rendered map section so the staying part can hold the sparse texture until the drop.

Breakdown is a corroborated density drop that keeps playing. Dropout is a leaving part. Cutoff is a stop-time. Pickup is rest-then-enter. Turnaround is shared continuation at section end. Heuristic-only topology stays unnamed.

Exact current identity

• Protected base: develop@749511c3ad4000090048718f685c6bee6b3d2c25 (fix(security): establish canonical npm, PDF.js, Nanoid, and Undici baseline #783 integrated, feat(workspace): name tonight's first playable range on the map #957 playable range on develop).
• Exact current head: 18acb454234939551a2ad2cdf72cef4d2b956001.
• Branch: feat/workspace-first-breakdown-plan.
• Distinct from first-dropout (feat(workspace): guide tonight's first dropout on map and player #914), first-cutoff-plan (feat(workspace): name tonight's first cutoff plan on the map #1032), first-stop (feat(workspace): guide tonight's first stop from analyzed audio #934), first-pickup-plan (feat(workspace): name tonight's first pickup plan on the map #1037), first-turnaround-plan (feat(workspace): name tonight's first turnaround plan on the map #1036), first-hit-plan (feat(workspace): name tonight's first hit plan on the map #1031), first-vamp-plan (feat(workspace): name tonight's first vamp plan on the map #1024), first-pad-plan (feat(workspace): name tonight's first pad plan on the map #1021), first-solo-plan (feat(workspace): name tonight's first solo plan on the map #1020), first-hook-plan (feat(workspace): name tonight's first hook plan on the map #1017), and first-fill-plan (feat(workspace): name tonight's first fill plan on the map #1016).
• Do not mix with 🔒 [보안] CLI 무제한 파일 읽기 취약점 수정 #811, test(analysis): govern real YouTube known-stem benchmark #828, or feat(workspace): Storybook tokens for rehearsal components #897.

Current implemented boundary

• Fail-closed own-data / Proxy-safe resolver admits bounded breakdownPlan copy only from owned data properties and snapshots it once before ranking.
• Engine emits Hold this breakdown with {target}; keep it sparse until the drop. (or the solo hold) only when previous graph source count is ≥3, current graph holds 1–2 of those same sources, and no new entrance arrives. Custom role-owned guidance is preserved verbatim unless model provenance is explicit.
• i18n EN/KO next-action copy is particle-safe. Korean Open is {at} {role} 브레이크다운 열기.
• Navigation uses the current song-structure renderer (data-section-index) and fails closed on ambiguous or missing targets. Reduced motion uses behavior: "auto".
• Demo and heuristic topology stay unnamed until real stem activity corroborates the density drop.

Dependency / merge gate

Canonical #783 is protected develop shipped truth. This branch inherits that JavaScript baseline and does not duplicate or suppress it. Inherited npm HIGH must not be suppressed elsewhere.

Keep unmerged until the unchanged then-current head has every applicable repository and central CI/build/release/security/SAST/SBOM/supply-chain/coverage/review gate terminal-success, zero valid unresolved findings, and a qualifying independent non-author last-push approval under live branch protection.

Queued, pending, skipped, cancelled, failed, predecessor-head, protected-base, model-only, self/author, or administrative-bypass evidence is not success.

---

Summary by CodeRabbit

• 새로운 기능
  • 리허설 워크스페이스에서 곡의 첫 번째 브레이크다운 계획을 확인할 수 있습니다.
  • 역할, 섹션, 시작 시간이 표시되며 해당 구간으로 바로 이동할 수 있습니다.
  • 분석 결과 밀도가 크게 줄어드는 구간에만 안내가 제공됩니다.
• 개선 사항
  • 사용자 작성 안내는 원문 그대로 유지됩니다.
  • 영어와 한국어 표시를 지원하며, 정보 없음·탐색 실패 메시지를 제공합니다.
  • 워크스페이스별 탐색 대상과 열림 상태가 분리됩니다.
  • 접근성 설정에 따라 부드러운 스크롤 또는 즉시 이동을 적용합니다.
• 버그 수정
  • 저장된 브레이크다운 계획의 형식과 출처를 검증해 잘못된 안내 표시를 방지합니다.

Contract-hardening verification at f8c051a

• Shared, Rust, and UI now use the same explicit Unicode whitespace and line-separator policy for breakdownPlan; empty, whitespace-only, and multiline values fail closed.
• breakdownPlan and breakdownPlanSource are now required as a pair at both the shared parser and native project-file boundary.
• Local evidence at this exact head: shared-types 48 tests / 100% statements, branches, functions, and lines; breakdown UI 54 tests; Rust core and breakdown contract 24 tests; shared/desktop lint and typecheck; Rust format check.
• Follow-up at this exact head: user-provenance resolver test now confirms long custom guidance remains verbatim; model-owned copy remains bounded separately.

Security Notes

• breakdownPlan is untrusted persisted/model-owned copy. Validation rejects empty or Unicode multiline values before storage or display, bounds displayed copy, and requires explicit model or user provenance.
• The native save/load boundary mirrors the shared contract and fails closed on invalid pairing or text; no new filesystem, network, subprocess, IPC, or dependency path is introduced.
• Navigation remains scoped to the current workspace renderer and reports a safe failure when the map target is absent or ambiguous.

Merge gate

Keep unmerged until the unchanged then-current head has every applicable repository and central CI/build/release/security/SAST/SBOM/supply-chain/coverage/review gate terminal-success, zero valid unresolved findings, and a qualifying independent non-author last-push approval under live branch protection. The previous Strix result is not reused after this push.

Queued, pending, skipped, cancelled, failed, predecessor-head, protected-base, model-only, self/author, or administrative-bypass evidence is not success.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6fd5cc20-9eb9-4e8c-8ece-67d31eaf390f

📥 Commits

Reviewing files that changed from the base of the PR and between 01a3fe7 and d53d635.

📒 Files selected for processing (17)

• apps/desktop/core/src/lib.rs
• apps/desktop/core/tests/breakdown_plan_contract.rs
• apps/desktop/src-tauri/src/main.rs
• apps/desktop/src/features/workspace/FirstBreakdownPlanCallout.memoization.test.tsx
• apps/desktop/src/features/workspace/FirstBreakdownPlanCallout.navigation-failure.test.tsx
• apps/desktop/src/features/workspace/FirstBreakdownPlanCallout.provenance.test.tsx
• apps/desktop/src/features/workspace/FirstBreakdownPlanCallout.reduced-motion.test.tsx
• apps/desktop/src/features/workspace/FirstBreakdownPlanCallout.workspace-scope.test.tsx
• apps/desktop/src/features/workspace/firstBreakdownPlan.continuation.test.ts
• apps/desktop/src/features/workspace/firstBreakdownPlan.inherited-metadata.test.ts
• apps/desktop/src/features/workspace/firstBreakdownPlan.proxy-authority.test.ts
• apps/desktop/src/features/workspace/firstBreakdownPlan.section-label.test.ts
• apps/desktop/src/features/workspace/firstBreakdownPlan.snapshot.test.ts
• apps/desktop/src/features/workspace/firstBreakdownPlan.test.ts
• apps/desktop/src/features/workspace/firstBreakdownPlan.ts
• packages/shared-types/src/index.ts
• packages/shared-types/test/breakdownPlanProvenance.test.ts

🚧 Files skipped from review as they are similar to previous changes (2)

• apps/desktop/src/features/workspace/FirstBreakdownPlanCallout.reduced-motion.test.tsx
• apps/desktop/src/features/workspace/firstBreakdownPlan.proxy-authority.test.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

분석 엔진이 stem 밀도 감소를 기반으로 첫 breakdownPlan을 생성합니다. 공유 타입과 네이티브 직렬화가 provenance 필드를 지원합니다. 데스크톱 워크스페이스가 계획을 검증하고 현지화하며 해당 섹션으로 이동합니다.

Changes

첫 breakdown plan 흐름

Layer / File(s)	Summary
Stem 활동 기반 계획 생성 services/analysis-engine/src/bandscope_analysis/roles/*, services/analysis-engine/tests/test_breakdown_plan.py	이전 source가 3개 이상이고 현재 유지 source가 1–2개인 섹션에서 모델 출처의 계획을 생성합니다. full stop, 새 entrance, 불충분한 밀도, 휴리스틱 토폴로지는 제외합니다.
Breakdown plan 계약과 왕복 처리 packages/shared-types/src/index.ts, packages/shared-types/test/*, apps/desktop/core/src/lib.rs, apps/desktop/core/tests/breakdown_plan_contract.rs, apps/desktop/src-tauri/src/main.rs	RehearsalRole과 RehearsalRolePayload에 계획 및 provenance 필드를 추가합니다. 단일 행 텍스트와 필드 쌍을 검증하고 프로젝트 저장 경로에 검증을 적용합니다.
첫 계획 해석과 방어적 검증 apps/desktop/src/features/workspace/firstBreakdownPlan.ts, apps/desktop/src/features/workspace/firstBreakdownPlan*.test.ts	활성 역할, 시간 범위, 섹션 라벨, 계획 문자열과 런타임 메타데이터를 검증합니다. 시간, 우선순위, 역할 ID로 결과를 안정적으로 선택합니다. 검증 실패와 예외에서는 null을 반환합니다.
워크스페이스 콜아웃과 맵 탐색 apps/desktop/src/features/workspace/FirstBreakdownPlanCallout*, apps/desktop/src/features/workspace/Workspace*.tsx, apps/desktop/src/features/workspace/Workspace.*.test.tsx	계획과 provenance에 따른 안내를 표시합니다. 대상 섹션으로 스크롤하고 reduced-motion, 탐색 실패, 워크스페이스 범위와 상태 유지 동작을 처리합니다.
현지화와 프로젝트 문서 apps/desktop/src/i18n/*, apps/desktop/src/locales/*, AGENTS.md, ARCHITECTURE.md, CHANGELOG.md, CLAUDE.md	섹션 라벨과 영어·한국어 breakdown plan 문구를 추가합니다. 기능 동작과 계획 문구 제약을 문서에 기록합니다.

Estimated code review effort: 4 (Complex) | ~60 minutes

Merge Risk: ⚪ Minimal · up to d53d6

The PR adds bounded breakdown guidance and workspace navigation with fail-closed validation and no identified merge-blocking risk remaining after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant AnalysisEngine
  participant SharedTypes
  participant Workspace
  participant FirstBreakdownPlanCallout
  participant SongStructureGrid
  AnalysisEngine->>SharedTypes: breakdownPlan 및 provenance 포함 역할 생성
  SharedTypes->>Workspace: 검증된 RehearsalSong 전달
  Workspace->>FirstBreakdownPlanCallout: song과 workspaceInstanceKey 전달
  FirstBreakdownPlanCallout->>Workspace: 첫 breakdown plan 해석 요청
  Workspace->>SongStructureGrid: 대상 섹션으로 스크롤

Loading

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 74.12% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 85 functions across 34 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 지도에서 오늘 밤의 첫 번째 breakdown plan을 명명하는 PR의 핵심 변경을 정확하고 간결하게 설명합니다.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/workspace-first-breakdown-plan

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@opencode-agent implement

Work only on canonical branch feat/workspace-first-breakdown-plan if its exact head is still 18acb454234939551a2ad2cdf72cef4d2b956001 against protected develop@749511c3ad4000090048718f685c6bee6b3d2c25; if it moved, inspect/remap the intervening delta first. Apply TDD and do not resolve threads until the successor exact head is GREEN.

Four current-head findings are verified BandScope-owned defects, not report-only notes:

1. Native payload contract / P1 — packages/shared-types/src/index.ts emits optional breakdownPlan / breakdownPlanSource, but apps/desktop/core/src/lib.rs::RehearsalRolePayload has deny_unknown_fields and lacks both. First add a Rust regression that deserializes and round-trips a realistic RehearsalSongPayload containing both fields (and preserves legacy payloads without them), proving current RED. Then add optional Rust mirror fields with camelCase serde behavior. Do not weaken deny_unknown_fields.

2. Generic other stem ownership / P1 — map_stems_to_roles projects one other source onto keys-left, keys-right, and acoustic-guitar; current _build_activity_topology therefore attaches model breakdown ownership to all three, and _activity_breakdown_plan can name one synthetic part as a partner. Add regressions for an other-only surviving breakdown and a named+other surviving breakdown. The other source may corroborate density, but must never imply a specific keys/guitar owner. Model guidance for a named role may refer to a generic accompaniment source if that is the evidence; do not invent a specific part.

3. Project/song instance state leakage / P2 — real analysis uses constant song id analyzed-song, while project load replaces the song without unmounting Workspace. Add a regression opening a breakdown in project/song object A, replacing it with a distinct object B carrying the same id and same breakdown signature, and assert armed/navigation-failure state resets. Use a true loaded-song instance authority rather than broadening object getters or weakening Proxy-safe admission.

4. Custom guidance contradiction after Open / P2 — for user/legacy guidance, clicking Open currently swaps the leading copy to model-specific firstBreakdownPlanArmed even when the owned plan says something else. Add a regression with custom text such as Mute for four bars; after Open, no invented keep sparse until the drop instruction may appear. Preserve owned custom text and keep post-navigation copy neutral unless model provenance authorizes model-specific armed guidance.

Run focused tests first, then repository-pinned format/lint/typecheck, Rust tests, Python tests at exact 100% branch/statement coverage, canonical quickcheck, and leave all protection/security/release gates intact. Resolve only the four addressed threads after exact successor-head verification. Do not touch foreign repositories or unrelated feature lanes.

[seonghobae]

@opencode-agent review

Review exact current head 21bc4d504abb75a7708daafe7524ac558c2f6841 only. Protected base is develop@749511c3ad4000090048718f685c6bee6b3d2c25; the PR is open, non-Draft, mergeable, and fresh inline-thread review now has zero unresolved threads. Re-verify the repaired native breakdown-plan contract, accompaniment-source ownership boundary, workspace-instance state authority, user/custom guidance preservation, and the intentional desktop fail-closed abutment gate. Do not reuse predecessor-head review evidence. If this unchanged head is defect-free and your independent-review policy permits it, submit the qualifying formal review; otherwise anchor any finding to this exact head.

[devin-ai-integration]

Devin Review found 3 new potential issues.

[seonghobae]

@devin-ai review this PR at current HEAD SHA d53d635. Prior review evidence is stale after the push; please re-review the exact current head, with focus on the shared/native breakdownPlan validation boundary and no cross-workspace navigation.

[seonghobae]

@devin-ai review this PR at current HEAD SHA f8c051a. The prior finding was fixed in this exact head; please verify the user-versus-model breakdownPlan rendering boundary and current contract tests.