fix(a11y): hide redundant decorative icons from the accessibility tree - #607
fix(a11y): hide redundant decorative icons from the accessibility tree#607seonghobae wants to merge 6 commits into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough장식용 아이콘과 중복 의미를 가진 로고를 보조 기술에서 숨깁니다. 관련 접근성 지침을 추가합니다. Changes장식 요소 접근성 조정
패키지 오버라이드 갱신
Estimated code review effort: 2 (Simple) | ~10 minutes Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The update prevents redundant screen-reader announcements for decorative logos and icons and updates dependency version constraints. No material outstanding risk is identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 3 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
범위
인접한 시각 텍스트와 동일한 의미의 로고, 그리고 버튼의 이름·상태에 정보를 추가하지 않는 chevron/icon을 accessibility tree에서 제외하는 후보입니다.
org-sidebar.tsx,context-section.tsx,event-list.tsx의 시맨틱 변경 자체와 dependency 변경은 서로 다른 책임입니다.review finding
현재 PR에는 접근성 수정과 인과관계가 없는
package.json/pnpm-lock.yaml대규모 dependency override·Next.js 전환이 함께 들어와 있습니다. accessibility acceptance를 dependency migration에 묶으면 regression 원인과 release evidence가 혼합됩니다. 이 PR에서 dependency delta는 protected base bytes로 되돌리거나 별도 dependency-owner PR로 분리해야 합니다. 해당 delta를 accessibility fix의 선행조건이나 우회책으로 인정하지 않습니다.또한
aria-hidden="true"/alt=""를 추가했다는 source diff만으로 실제 중복 낭독 제거가 검증됐다고 보지 않습니다. 각 button의 accessible name과aria-expanded상태, sidebar logo 인접 텍스트가 실제 AX tree에서 의도대로 계산되는지 current head browser에서 확인해야 합니다.Material UI Delivery Gate
Ready acceptance
package.json과pnpm-lock.yaml의 unrelated dependency delta를 이 PR에서 제거하거나 별도 owner PR로 완전히 분리합니다.aria-expanded전환이 동일하게 유지됩니다.위 acceptance 전에는 merge/release-ready로 보지 않습니다.
Summary by CodeRabbit