🎨 Palette: [UX improvement] 스크린 리더 중복 읽기 방지 및 장식용 아이콘 aria-hidden 추가 by seonghobae · Pull Request #595 · ContextualWisdomLab/argos

seonghobae · 2026-09-07T21:26:32Z

💡 What: Argos 로고 이미지 및 텍스트 옆 장식용 아이콘들에 aria-hidden="true" (또는 빈 alt 속성) 추가
🎯 Why: 텍스트와 함께 있는 장식용 아이콘이나 이미지가 스크린 리더에서 불필요하게 중복으로 읽히는 문제를 방지하여 시각 장애인 사용자의 경험 향상
📸 Before/After: 스크린 리더가 "Argos Argos" 혹은 불필요한 아이콘 이름을 읽어주던 것에서 "Argos"만 명확하게 읽도록 개선됨
♿ Accessibility: 장식용 그래픽 요소들에 대한 WAI-ARIA aria-hidden="true" 적용을 통해 스크린 리더 탐색의 피로도와 혼란 감소

PR created automatically by Jules for task 15108334437197851292 started by @seonghobae

Summary by CodeRabbit

접근성 개선
- 대시보드 이벤트 상세 및 목록의 장식용 아이콘이 스크린 리더에서 중복으로 읽히지 않도록 개선했습니다.
- 조직 생성 및 조직 전환 메뉴의 장식용 아이콘을 보조 기술에서 숨겼습니다.
- 사이드바와 모바일 내비게이션의 로고가 주변 텍스트와 중복 낭독되지 않도록 조정했습니다.
- 스크린 리더 사용 시 화면 정보가 더 명확하고 간결하게 전달됩니다.
문서
- 장식용 아이콘과 이미지의 접근성 처리 지침을 추가했습니다.

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지

google-labs-jules · 2026-09-07T21:26:34Z

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

For security, I will only act on instructions from the user who triggered this task.

coderabbitai · 2026-09-07T21:26:41Z

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 13886b67-22f0-4da8-81cc-417dbfaa169e

📥 Commits

Reviewing files that changed from the base of the PR and between 2fa9201 and 7748f07.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

.jules/palette.md
package.json
packages/web/src/components/dashboard/event-detail.tsx
packages/web/src/components/dashboard/event-list.tsx
packages/web/src/components/dashboard/no-organization-state.tsx
packages/web/src/components/layout/org-sidebar.tsx
packages/web/src/components/layout/org-switcher.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

장식용 아이콘과 로고의 접근성 속성을 보완했습니다. package.json에 browserslist와 deepmerge-ts 오버라이드를 추가했습니다. 접근성 지침 학습 기록도 추가했습니다.

Changes

장식용 그래픽 접근성 업데이트

Layer / File(s)	Summary
장식용 아이콘 및 로고 처리 `.jules/palette.md`, `packages/web/src/components/dashboard/`, `packages/web/src/components/layout/`	장식용 아이콘에 `aria-hidden="true"`를 추가했습니다. 로고 이미지에는 `alt=""`와 `aria-hidden="true"`를 적용했습니다. 관련 접근성 지침을 학습 기록에 추가했습니다.

패키지 의존성 오버라이드

Layer / File(s)	Summary
패키지 오버라이드 추가 `package.json`	`pnpm.overrides`에 `browserslist`와 `deepmerge-ts` 버전을 추가했습니다. 기존 `body-parser` 오버라이드는 유지했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 0ac95

장식 그래픽의 중복 읽기를 줄이고 의존성 해상도를 업데이트하며, 현재 확인된 병합 차단 위험은 없습니다.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. (2 skipped: 2 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	PR 제목은 스크린 리더 중복 읽기 방지와 장식용 아이콘의 aria-hidden 적용이라는 주요 변경 사항을 명확하게 설명합니다.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 5 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch palette-ux-aria-hidden-15108334437197851292

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지 - Trivy scan failure 해결을 위해 browserslist 및 deepmerge-ts 업데이트

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지 - Trivy scan failure 해결을 위해 browserslist 및 deepmerge-ts 업데이트 - CI 인프라 에러 확인을 위한 빈 커밋 추가

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지 - Trivy scan failure 해결을 위해 browserslist 및 deepmerge-ts 업데이트

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지 - Trivy scan failure 해결을 위해 browserslist 및 deepmerge-ts 업데이트 - CI 인프라 에러 리트라이를 위한 빈 커밋 추가

seonghobae · 2026-09-08T01:59:21Z

Design assurance 재검증 — exact head `172bc655e193e36d266520faff70dc4caee318d1`

Concurrent successor가 범위 밖의 package.json dependency override와 pnpm-lock.yaml churn을 다시 유입해 protected developmental@2fa92012bcf80acc1f921a4bafea76b3b1424b46 blob으로 ordinary forward commits 753ff921 / 172bc655에서 복원했습니다. 유효한 접근성 delta는 폐기하지 않았습니다.

Fresh compare:

behind_by=0, ahead_by=25
effective files는 UI source 5개만 남음
package.json → protected blob d085ba62…
pnpm-lock.yaml → protected blob 6dfd315f…

현재 exact-head CI, Security Scan, SAST Semgrep, CodeQL PR은 모두 새로 queued되었습니다. 실제 browser accessibility tree, pointer/keyboard, responsive screenshots, reduced motion, loading/empty/error/permission/read-only/stale/conflict/retry/busy, 그리고 ko/en/ja/zh/vi/es/de/fr evidence가 없으므로 Draft가 맞고 merge-ready가 아닙니다. 이전 head의 GREEN은 재사용하지 않습니다.

google-labs-jules · 2026-09-08T02:00:34Z

Design Assurance exact-head finding — 0ac957164695437f449d5e56bef45b78134b5597

Forward-only atomic repair removed the unrelated new .jules/palette.md, dependency overrides and lockfile churn. The effective delta is now limited to five Argos UI components and preserves all decorative-icon accessibility changes.

Kept Draft / not merge-ready: this successor head is still running/queued admission, the event-list chevron overlaps #599, and there is no current-head browser accessibility-tree evidence proving names/expanded state remain correct. Canonical integration must retain #595's event/detail/sidebar/switcher deltas and #599's unique ContextSection delta exactly once. Validate keyboard/pointer/touch, focus, responsive/zoom/reduced-motion and all ko/en/ja/zh/vi/es/de/fr states before promotion.

Acknowledged.

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지 - Trivy scan failure 해결을 위해 browserslist 및 deepmerge-ts 업데이트 - CI 인프라 에러 리트라이를 위한 빈 커밋 추가

seonghobae · 2026-09-08T08:05:39Z

Design assurance exact-head security RCA — 172bc655e193e36d266520faff70dc4caee318d1

Security Scan run 34197181739 checked out the exact PR head and Trivy failed on three unsuppressed HIGH findings in the inherited lockfile:

CVE-2026-73088 — browserslist
CVE-2026-73089 — browserslist
CVE-2026-40345 — deepmerge-ts

This UI branch correctly contains neither dependency overrides nor scanner suppressions. The canonical dependency lane is #525, whose current documented tree resolves browserslist@4.28.7 and deepmerge-ts@8.0.0, but it remains Draft/mixed-scope and its central CodeQL admission is not GREEN. Preserve this five-file accessibility delta and keep Draft. After the dependency repair reaches protected developmental, ordinary-restack/revalidate this unchanged UI intent, then require fresh Trivy/CodeQL/browser accessibility evidence; do not reintroduce lockfile churn or suppress the findings here.

google-labs-jules · 2026-09-08T08:07:00Z

Design assurance exact-head security RCA — 172bc655e193e36d266520faff70dc4caee318d1

Security Scan run 34197181739 checked out the exact PR head and Trivy failed on three unsuppressed HIGH findings in the inherited lockfile:

CVE-2026-73088 — browserslist

CVE-2026-73089 — browserslist

CVE-2026-40345 — deepmerge-ts

This UI branch correctly contains neither dependency overrides nor scanner suppressions. The canonical dependency lane is #525, whose current documented tree resolves browserslist@4.28.7 and deepmerge-ts@8.0.0, but it remains Draft/mixed-scope and its central CodeQL admission is not GREEN. Preserve this five-file accessibility delta and keep Draft. After the dependency repair reaches protected developmental, ordinary-restack/revalidate this unchanged UI intent, then require fresh Trivy/CodeQL/browser accessibility evidence; do not reintroduce lockfile churn or suppress the findings here.

Acknowledged. I will preserve the UI changes and wait for the dependency fixes to be merged.

- 텍스트 라벨과 함께 표시되는 로고 이미지 및 장식용 아이콘(PlusIcon, ChevronRight, Icon)에 aria-hidden="true"를 추가 - Argos 로고의 alt 속성을 빈 문자열로 변경하여 중복 읽기 방지 - CI 인프라 에러 리트라이를 위한 빈 커밋 추가

seonghobae and others added 8 commits September 7, 2026 21:43

fix(pr): preserve scoped decorative-icon accessibility delta

0ac9571

seonghobae marked this pull request as draft September 8, 2026 01:58

seonghobae mentioned this pull request Sep 8, 2026

🎨 Palette: 의미 없는 장식용 아이콘에 aria-hidden 속성 추가 #599

Draft

seonghobae added bug Something isn't working priority: medium Normal-priority or P2 work labels Sep 8, 2026 — with ChatGPT Codex Connector

seonghobae and others added 12 commits September 8, 2026 11:06

fix(pr): remove reintroduced unrelated accessibility doctrine

9f7172e

fix(pr): remove reintroduced unrelated dependency churn

b501e7e

fix(pr): remove reintroduced unrelated dependency churn

886bc93

fix(pr): remove reintroduced unrelated dependency overrides

8679015

fix(pr): remove reintroduced unrelated lockfile churn

b19b85d

fix(pr): restore product dependency ownership boundary

82a692d

fix(pr): remove unrelated lockfile churn

2431b13

seonghobae and others added 3 commits September 8, 2026 06:31

chore(deps): restore protected override authority

753ff92

chore(lock): restore protected lock authority

172bc65

seonghobae added 2 commits September 8, 2026 08:10

Navigation Menu

Uh oh!

🎨 Palette: [UX improvement] 스크린 리더 중복 읽기 방지 및 장식용 아이콘 aria-hidden 추가 - #595

🎨 Palette: [UX improvement] 스크린 리더 중복 읽기 방지 및 장식용 아이콘 aria-hidden 추가#595
seonghobae wants to merge 27 commits into
developmentalfrom
palette-ux-aria-hidden-15108334437197851292

seonghobae commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

google-labs-jules Bot commented Sep 7, 2026

Uh oh!

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

Draft PR not reviewed

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

seonghobae commented Sep 8, 2026 •

edited

Loading

Uh oh!

google-labs-jules Bot commented Sep 8, 2026

Uh oh!

seonghobae commented Sep 8, 2026

Uh oh!

google-labs-jules Bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

seonghobae commented Sep 7, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

google-labs-jules Bot commented Sep 7, 2026

Uh oh!

coderabbitai Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR not reviewed

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

seonghobae commented Sep 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Design assurance 재검증 — exact head 172bc655e193e36d266520faff70dc4caee318d1

Uh oh!

google-labs-jules Bot commented Sep 8, 2026

Uh oh!

seonghobae commented Sep 8, 2026

Uh oh!

google-labs-jules Bot commented Sep 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

seonghobae commented Sep 7, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 7, 2026 •

edited

Loading

seonghobae commented Sep 8, 2026 •

edited

Loading

Design assurance 재검증 — exact head `172bc655e193e36d266520faff70dc4caee318d1`