Skip to content

validation(erd): bound identifier length pending dialect contract #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 2 commits into
base: developmental
Choose a base branch
from
Draft

validation(erd): bound identifier length pending dialect contract #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bda3811
🛡️ Sentinel: [MEDIUM] ERD 식별자 길이 제한을 통한 ReDoS 취약점 수정
seonghobae Sep 5, 2026
bf44d2e
chore: keep Sentinel guidance scoped to protected baseline
seonghobae Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions packages/web/src/lib/erd.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,14 @@ describe("ERDModel", () => {
).toThrowError("Column 'created__at' must be snake_case.");
});

it("should reject identifiers exceeding length limit", () => {
model.addTable("users");
const longName = "a".repeat(65);
expect(() =>
model.addColumn("users", { name: longName, type: "integer" }),
).toThrowError("Invalid length for Column identifier.");
});

it("should reject invalid SQL default values", () => {
model.addTable("users");
expect(() =>
Expand Down
5 changes: 5 additions & 0 deletions packages/web/src/lib/erd.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,12 @@ function assertSafeSqlDefaultValue(value: string): void {
}
}

const MAX_IDENTIFIER_LENGTH = 64;

function assertSnakeCaseIdentifier(kind: string, name: string): void {
if (name.length === 0 || name.length > MAX_IDENTIFIER_LENGTH) {
throw new Error(`Invalid length for ${kind} identifier.`);
}
if (!SNAKE_CASE_IDENTIFIER.test(name)) {
throw new Error(`${kind} '${name}' must be snake_case.`);
}
Expand Down
Loading