Skip to content

๐ŸŽจ Palette: [UX improvement] ์Šค์บ” ์ƒ์„ธ ๋ณด๊ธฐ ๋‹ซ๊ธฐ ๋ฒ„ํŠผ์— ๋‹จ์ถ•ํ‚ค ์•ˆ๋‚ด ํˆดํŒ ๋ฐ ์ ‘๊ทผ์„ฑ ์†์„ฑ ์ถ”๊ฐ€ - #1409

Open
seonghobae wants to merge 1 commit into
developfrom
palette-ux-close-btn-shortcut-16734918341487939858

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: ์ถ”๊ฐ€์ ์œผ๋กœ scan details ๋ทฐ์˜ ๋‹ซ๊ธฐ ๋ฒ„ํŠผ(.close-btn)์— title="Close (Esc)" ์™€ aria-keyshortcuts="Escape" ์†์„ฑ์„ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ๊ธฐ์กด์—๋Š” Escape ํ‚ค๋ณด๋“œ ๋‹จ์ถ•ํ‚ค๋ฅผ ์ด์šฉํ•ด ๋ทฐ๋ฅผ ๋‹ซ์„ ์ˆ˜ ์žˆ์Œ์—๋„ ๋ถˆ๊ตฌํ•˜๊ณ , ์‚ฌ์šฉ์ž์—๊ฒŒ ์ด๋ฅผ ์•ˆ๋‚ดํ•˜๋Š” ์‹œ๊ฐ์ ์ธ ํˆดํŒ์ด๋‚˜ ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์šฉ ARIA ์†์„ฑ์ด ๋ถ€์กฑํ•˜์—ฌ ์‚ฌ์šฉ์„ฑ๊ณผ ์ ‘๊ทผ์„ฑ์— ์ œํ•œ์ด ์žˆ์—ˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ๋‹ซ๊ธฐ ๋ฒ„ํŠผ์— ๋งˆ์šฐ์Šค๋ฅผ ์˜ฌ๋ฆฌ๋ฉด Close (Esc)๋ผ๋Š” ํˆดํŒ์ด ๋ณด์—ฌ์ง€๊ฒŒ ๋ฉ๋‹ˆ๋‹ค.
โ™ฟ Accessibility: aria-keyshortcuts ์†์„ฑ์„ ํ†ตํ•ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž์—๊ฒŒ๋„ ๋‹จ์ถ•ํ‚ค ์ •๋ณด๋ฅผ ์ œ๊ณตํ•˜๊ฒŒ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 16734918341487939858 started by @seonghobae

Summary by CodeRabbit

  • ์ ‘๊ทผ์„ฑ ๊ฐœ์„ 
    • ์ƒ์„ธ ๋ณด๊ธฐ ๋‹ซ๊ธฐ ๋ฒ„ํŠผ์— Escape ํ‚ค ๋‹จ์ถ•ํ‚ค ์•ˆ๋‚ด๋ฅผ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค.

Adds `title="Close (Esc)"` and `aria-keyshortcuts="Escape"` to the `.close-btn` element in `scanner/dashboard/console.html` to improve accessibility and discoverability of the keyboard shortcut for closing the scan details view.
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Review in Change Stack โ†’

No actionable comments were generated in the recent review. ๐ŸŽ‰

โ„น๏ธ Recent review info
โš™๏ธ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a0125d14-2cb4-46ee-b22a-4bbc84aa0549
๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 2949d30 and 8065fca.

๐Ÿ“’ Files selected for processing (1)
  • scanner/dashboard/console.html

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


๐Ÿ“ Walkthrough

Walkthrough

์ƒ์„ธ ๊ฒฐ๊ณผ์™€ ์˜ค๋ฅ˜ ํ™”๋ฉด์˜ ๋‹ซ๊ธฐ ๋ฒ„ํŠผ์— title="Close (Esc)" ๋ฐ aria-keyshortcuts="Escape" ์†์„ฑ์„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค. ์ƒ์„ธ ๋กœ๋”ฉ๊ณผ ์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ํ๋ฆ„์€ ๋ณ€๊ฒฝํ•˜์ง€ ์•Š์Šต๋‹ˆ๋‹ค.

Changes

๋‹ซ๊ธฐ ๋ฒ„ํŠผ ์ ‘๊ทผ์„ฑ

Layer / File(s) Summary
๋‹ซ๊ธฐ ๋ฒ„ํŠผ ๋‹จ์ถ•ํ‚ค ์•ˆ๋‚ด
scanner/dashboard/console.html
์ƒ์„ธ ๊ฒฐ๊ณผ์™€ ์˜ค๋ฅ˜ ํ™”๋ฉด์˜ ๋‹ซ๊ธฐ ๋ฒ„ํŠผ์— title ๋ฐ aria-keyshortcuts ์†์„ฑ์„ ์ถ”๊ฐ€ํ•ฉ๋‹ˆ๋‹ค.

Priority: โฌ‡๏ธ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Feature

Merge Risk: โšช Minimal ยท up to 8065f

The detail and error views now indicate their existing Escape shortcut; no actionable merge risk remains.

๐Ÿšฅ Pre-merge checks | โœ… 5
โœ… Passed checks (5 passed)
Check name Status Explanation
Description Check โœ… Passed Check skipped - CodeRabbitโ€™s high-level summary is enabled.
Title check โœ… Passed ์ œ๋ชฉ์€ ์Šค์บ” ์ƒ์„ธ ๋ณด๊ธฐ ๋‹ซ๊ธฐ ๋ฒ„ํŠผ์— ํ‚ค๋ณด๋“œ ๋‹จ์ถ•ํ‚ค ํˆดํŒ๊ณผ ์ ‘๊ทผ์„ฑ ์†์„ฑ์„ ์ถ”๊ฐ€ํ•˜๋Š” ์ฃผ์š” ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ์ •ํ™•ํ•˜๊ฒŒ ์„ค๋ช…ํ•ฉ๋‹ˆ๋‹ค.
Docstring Coverage โœ… Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0โ€ฆ
Linked Issues check โœ… Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check โœ… Passed Check skipped because no linked issues were found for this pull request.
โœจ Finishing Touches ๐Ÿ’ก 1
๐Ÿ› ๏ธ Fix failing CI checks ๐Ÿ’ก
  • Commit to this branch
  • Create a new PR
๐Ÿงช Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant