Repository navigation
⚡ Bolt: [성능 개선] 생성자 제너레이터를 컴프리헨션으로 변경하여 C-level 속도 최적화 #1398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -106,10 +106,10 @@ def normalize_findings( | |
| snippet_max_len: int = 400, | ||
| ) -> tuple[dict[str, Any], ...]: | ||
| """Normalize a finding collection into a stable tuple.""" | ||
| return tuple( | ||
| return tuple([ | ||
| normalize_finding(finding, snippet_max_len=snippet_max_len) | ||
| for finding in findings | ||
| ) | ||
| ]) | ||
|
Comment on lines
+109
to
+112
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔍 Normalization duplicates the result container For large scan batches, Was this helpful? React with 👍 or 👎 to provide feedback. |
||
|
|
||
|
|
||
| def severity_counts(findings: Iterable[dict[str, Any]]) -> dict[str, int]: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Performance claim lacks a representative benchmark
The 30–40% speedup claim has no measurement here. Dict comprehensions still evaluate each reference in Python; benchmark typical rule messages before treating this transformation as general performance guidance.
Was this helpful? React with 👍 or 👎 to provide feedback.