refactor(inventory): carried into canonical writer #1292

[seonghobae]

Retired by verified complete successor carryover

• Exact retired head: 732b89e7cb04d019d34ee3ebe2fbba92ae68ecc4
• Canonical successor: refactor(inventory): stream repository aggregation #1292 exact 1cb5668f469629b0932d0d3e7934169e2aaf75f3
• Valid no-materialization aggregation delta: preserved
• Behavioral regression and semantic verification: added at successor
• Duplicate blanket guidance and unmeasured performance claims: rejected, not suppressed
• No predecessor Checks or approvals transferred

See the final conversation comment for the field-by-field carryover proof. This is not a merge or completion claim; #1292 remains Draft/Proposed behind its own exact-head gates.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 186bc07d-2570-417d-b206-84802204e083

📥 Commits

Reviewing files that changed from the base of the PR and between 2949d30 and 732b89e.

📒 Files selected for processing (2)

• .jules/bolt.md
• appguardrail_core/org_intelligence.py

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Walkthrough

build_org_inventory가 저장소 iterable을 한 번 순회하며 인벤토리 및 언어·기본 브랜치 집계를 누적합니다. 지원되지 않는 언어는 정렬해 반환합니다. 단일 패스 최적화 지침도 추가했습니다.

Changes

조직 인벤토리 집계

Layer / File(s)	Summary
저장소 단일 패스 집계 appguardrail_core/org_intelligence.py, .jules/bolt.md	build_org_inventory가 저장소 수, 포크 수, 비포크 수, 비공개 저장소 수와 관련 집계를 한 번의 순회에서 누적합니다. 지원되지 않는 언어에서 "Unknown"을 제외하고, 결과를 정렬해 반환합니다. 활성 저장소 목표 비교는 비포크 저장소 수를 사용하며 >= 조건을 유지합니다. 단일 패스 최적화 지침을 추가했습니다.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Merge Risk: ⚪ Minimal · up to 732b8

No actionable merge-blocking issue is identified; the inventory optimization is mergeable after normal checks.

Architecture Summary

Architecture risk: 🔵 Low · up to 732b8

The change affects 1 system.

Changed systems: appguardrail_core

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

• observed — appguardrail_core (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

• observed — Modified behavior in appguardrail_core/org_intelligence.py: build_org_inventory replaces materializing repos and deriving counts through repeated list traversals with a single pass. It increments inventory and language/branch counts per repository; only non-forks contribute to supported-language counts and unsupported languages, and "Unknown" remains excluded from the unsupported set.
• observed — Modified behavior in appguardrail_core/org_intelligence.py: The returned inventory now uses the accumulated counters and sorted unsupported-language set; the active target comparison uses the non-fork counter and remains >= active_repository_target.
• observed — Modified behavior in .jules/bolt.md: 단일 패스 최적화 항목을 추가했습니다. 여러 리스트 컴프리헨션을 하나의 O(N) 루프로 병합해 반복 횟수와 중간 할당을 줄인다는 학습 내용과, 로컬 변수에 상태를 누적하는 단일 패스를 사용하라는 지침을 기록합니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 build_org_inventory를 단일 O(N) 패스로 최적화하는 주요 변경 사항을 간결하고 구체적으로 설명합니다.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Commit to this branch
• Create a new PR

📝 Generate docstrings

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

[seonghobae]

Verified complete successor carryover before retirement.

• Predecessor exact head: 732b89e7cb04d019d34ee3ebe2fbba92ae68ecc4
• Canonical writer: refactor(inventory): stream repository aggregation #1292 exact head 1cb5668f469629b0932d0d3e7934169e2aaf75f3
• Preserved valid delta: build_org_inventory() now consumes repos directly and accumulates total, fork/non-fork, private, supported-language, unsupported-language, primary-language, and default-branch facts without materializing or retaining the input records.
• Stronger regression: refactor(inventory): stream repository aggregation #1292 RED f0d8fd8e571434ad5f5477e3b4197c66524503e1 observes retention behavior; GREEN 1cb5668… passes the exact fetched behavioral plus semantic suites 5/5, compileall, and conflict-marker scan.
• Intentionally not carried: the duplicate blanket .jules/bolt.md instruction and the unmeasured constant-factor speed/allocation claims. Existing guidance already requires production-hot-path measurement before such claims.
• Review state: this PR has 0 unresolved threads and only a COMMENTED bot review; no approval is being transferred.
• Check state: its six workflows and CodeQL failed before runner execution (steps=[]), so no predecessor Check is transferred.

Closing unmerged is therefore successor carryover, not simple closure or a claim that #1292 is complete. #1292 remains Draft/Proposed until its own unchanged exact head receives executable terminal Checks, representative benchmark evidence for performance claims, and qualifying independent approval.

[google-labs-jules]

Verified complete successor carryover before retirement.

• Predecessor exact head: 732b89e7cb04d019d34ee3ebe2fbba92ae68ecc4
• Canonical writer: refactor(inventory): stream repository aggregation #1292 exact head 1cb5668f469629b0932d0d3e7934169e2aaf75f3
• Preserved valid delta: build_org_inventory() now consumes repos directly and accumulates total, fork/non-fork, private, supported-language, unsupported-language, primary-language, and default-branch facts without materializing or retaining the input records.
• Stronger regression: refactor(inventory): stream repository aggregation #1292 RED f0d8fd8e571434ad5f5477e3b4197c66524503e1 observes retention behavior; GREEN 1cb5668… passes the exact fetched behavioral plus semantic suites 5/5, compileall, and conflict-marker scan.
• Intentionally not carried: the duplicate blanket .jules/bolt.md instruction and the unmeasured constant-factor speed/allocation claims. Existing guidance already requires production-hot-path measurement before such claims.
• Review state: this PR has 0 unresolved threads and only a COMMENTED bot review; no approval is being transferred.
• Check state: its six workflows and CodeQL failed before runner execution (steps=[]), so no predecessor Check is transferred.

Closing unmerged is therefore successor carryover, not simple closure or a claim that #1292 is complete. #1292 remains Draft/Proposed until its own unchanged exact head receives executable terminal Checks, representative benchmark evidence for performance claims, and qualifying independent approval.

Understood. Acknowledging that this work is now obsolete and stopping work on this task. I have reverted my changes as this PR has been superseded by #1292.

[seonghobae]

Carryover successor advanced by ordinary non-force base reconciliation: #1292 now has exact head c12402ee828068b2287bb06594218f3aeb7f2f7c, with functional head 1cb5668f469629b0932d0d3e7934169e2aaf75f3 as its first parent and protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf as its second parent. The production and regression blob SHAs remain unchanged (28f9876…, d0620b3…), so the recorded complete carryover remains valid.

[google-labs-jules]

Carryover successor advanced by ordinary non-force base reconciliation: #1292 now has exact head c12402ee828068b2287bb06594218f3aeb7f2f7c, with functional head 1cb5668f469629b0932d0d3e7934169e2aaf75f3 as its first parent and protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf as its second parent. The production and regression blob SHAs remain unchanged (28f9876…, d0620b3…), so the recorded complete carryover remains valid.

Acknowledged.