Repository navigation
🎨 Palette: 외부 링크 접근성 및 UI 개선 - #1378
seonghobae wants to merge 3 commits into
Conversation
- `target="_blank"` 속성을 가지는 외부 링크에 스크린 리더용 숨김 텍스트(`.sr-only`)와 시각적 안내 아이콘 추가. - 긴 URL로 인해 레이아웃이 깨지는 현상을 방지하기 위해 `.ext-link` 클래스 적용 (`word-break: break-all`).
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| def handle_starttag(self, tag, attrs): | ||
| attrs_dict = dict(attrs) | ||
| if tag == "a" and attrs_dict.get("target") == "_blank": | ||
| classes = attrs_dict.get("class", "") | ||
| self.link_classes = classes.split() | ||
| elif tag == "span" and "sr-only" in attrs_dict.get("class", ""): | ||
| self.has_sr_only = True | ||
| elif tag == "svg" and attrs_dict.get("aria-hidden") == "true": | ||
| self.has_aria_hidden_icon = True |
There was a problem hiding this comment.
🔍 External-link test misses indicator placement
The parser accepts the warning span and icon anywhere in the template, not necessarily inside each link. A rendered-link assertion would catch missing indicators on individual references.
Was this helpful? React with 👍 or 👎 to provide feedback.
Exact-head lifecycle correction — 2026-10-03
Draft / Proposed preserves the accessibility delta while terminal CodeQL and qualifying review remain merge gates. No rerun, bypass, merge, release, or Close is performed. |
- `target="_blank"` 외부 링크에 `.sr-only` 텍스트와 시각적 아이콘(SVG) 추가. - 긴 URL 줄바꿈 문제를 해결하기 위해 `.ext-link` 클래스 적용.
Restore the protected tree while preserving the proposal in ordinary ancestry. Canonical #1361 carries the complete product behavior with safer overflow-wrap:anywhere, noopener, assistive text, a hidden decorative cue, and a focused regression; #1364 carries CHANGELOG and Gap evidence. The word-break:break-all variant and generated guidance add no remaining valid delta.
Verified successor carryover and zero-diff retirement
Complete valid carryover:
Every valid requirement is present in the canonical successors and no effective file remains here. Close is therefore verified complete carryover, not simple retirement, merge, release, or gate bypass. |
Understood. Acknowledging that this work has been carried over to canonical successors and is now obsolete. Stopping work on this task. |
1 participant
Retired — verified complete successor carryover
3e479d8dc94bcea7e7b71114bbb7a13f0266d60fdevelop@2949d30718752ea5915c7713ba227e8c19d9e5bfbc98874b2c8f9349605e1036611692e05adc145e957ac1d0b5dc2bdca507f377d41217c931ad8802#1361 carries every valid behavior with the safer
overflow-wrap:anywherepolicy,rel="noopener", assistive text, hidden decorative cue, and a focused regression. #1364 carries CHANGELOG and Gap evidence. This branch'sword-break:break-allvariant is weaker and its generated journal note is not an independent product delta.The proposal remains in ordinary ancestry. This PR is closed only after exact zero-diff restoration and verified complete successor carryover; it was not merged, released, force-updated, or used to bypass a gate.