Skip to content

🎨 Palette: [UX improvement] 스캔 상세 보기 닫기 버튼 툴팁 및 단축키 접근성 추가 - #1375

Closed
seonghobae wants to merge 2 commits into
developfrom
palette-add-tooltip-close-btn-17398997851884312215
Closed

seonghobae wants to merge 2 commits into
developfrom
palette-add-tooltip-close-btn-17398997851884312215

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Retired duplicate — verified complete successor carryover

#1344 preserves the same console close-button title and aria-keyshortcuts behavior, adds the index-dialog contract and executable regressions, and has nine terminal-success exact-head workflows. It remains Draft/open pending qualifying review; this retirement does not transfer approval or merge readiness.

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: d0871f55-e563-48ed-b6cf-f5bc54006b93

📥 Commits

Reviewing files that changed from the base of the PR and between 2949d30 and d9f82d6.

📒 Files selected for processing (1)
  • scanner/dashboard/console.html

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

성공 상태와 오류 상태의 스캔 상세 닫기 버튼에 Close (Esc) 제목과 Escape 키보드 단축키 속성을 추가했습니다. 기존 Escape 키 처리와 닫기 동작은 변경하지 않았습니다.

Changes

스캔 상세 닫기 버튼

Layer / File(s) Summary
닫기 버튼 단축키 표시
scanner/dashboard/console.html
성공 상태와 오류 상태의 닫기 버튼에 Close (Esc) 제목과 Escape 키보드 단축키 속성을 추가했습니다. 기존 닫기 동작은 유지했습니다.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to d9f82

Both scan-detail close buttons now describe the Escape shortcut. No merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to d9f82

The change affects 1 system.

Changed systems: scanner

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — scanner (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in scanner/dashboard/console.html: The successful detail view’s close button now includes the Close (Esc) title and declares Escape as its keyboard shortcut; the existing detail rendering, click handler, scrolling, and focus behavior remain unchanged.
  • observed — Modified behavior in scanner/dashboard/console.html: The error-state close button now includes the same title and keyboard-shortcut declaration. Error display and existing close-button wiring remain unchanged.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 스캔 상세 보기 닫기 버튼에 툴팁과 단축키 접근성 정보를 추가하는 변경 사항을 정확하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Copy link
Copy Markdown
Contributor Author

Exact-head lifecycle correction — 2026-10-03

  • Exact head: d9f82d678e88647747c6df66bc2a1edba8998a43.
  • Eight non-CodeQL workflows are terminal SUCCESS, but CodeQL run 37020734819 is terminal FAILURE: both actions and python compatibility jobs failed at Release runner or enforce current-head CodeQL verdict.
  • Qualifying APPROVED reviews: 0; unresolved threads: 0.
  • The one-file UI delta also adds no focused regression for the new title / aria-keyshortcuts contract.

Ready cannot represent merge admissibility for this exact head. The valid delta remains open as Draft / Proposed; no rerun, bypass, merge, release, or Close is performed.

@seonghobae
seonghobae marked this pull request as draft October 2, 2026 22:16
PR #1375 carries no unique valid delta beyond #1344. The successor owns the same console close-button title and aria-keyshortcuts behavior, adds the index dialog contract and executable regressions, and passed all nine exact-head workflows at 707ab2e. Restore the protected tree through ordinary ancestry so the duplicate can be retired without losing intent.

Copy link
Copy Markdown
Contributor Author

Duplicate retirement evidence — 2026-10-03

This PR has no unique valid delta after verified complete successor carryover to #1344.

  • predecessor original head: d9f82d678e88647747c6df66bc2a1edba8998a43
  • ordinary restoration child: 220cbbb8a7349493b0154fa102ca2771184b87a0 (no force)
  • protected base: develop@2949d30718752ea5915c7713ba227e8c19d9e5bf
  • final compare: 2 ahead / 0 behind / 0 changed files
  • successor: 🎨 Palette: 닫기 버튼에 aria-keyshortcuts 속성 추가 #1344 exact 707ab2e02cdab1f4187b78302abe154afdcf9fed

#1344 contains the same two console.html success/error close-button changes byte-for-byte, plus the index.html close-button contract and executable regressions in tests/test_console_dashboard_security.py and tests/test_dashboard_core.py. Its exact head has terminal SUCCESS for Tests, CodeQL PR, Security Scan, SAST, Security Process, OpenSSF Evidence Coverage, Retention Audit Coverage, Pinned HTTPS Coverage, and Scan path context coverage (runs 36435663881–36435664356). It remains Draft/open because it has no qualifying approval.

Accordingly, closing #1375 unmerged preserves all valid behavior and test intent in the stronger canonical successor. This is not a gate bypass, evidence transfer to another head, or a claim that #1344 is merge-ready.

@seonghobae seonghobae closed this Oct 3, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Security Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant