Skip to content

๐ŸŽจ Palette: [UX improvement] ์™ธ๋ถ€ ๋งํฌ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  ๋ฐ ์ค„๋ฐ”๊ฟˆ ์ฒ˜๋ฆฌ - #1353

Closed
seonghobae wants to merge 5 commits into
developfrom
palette-ext-link-a11y-13898389422644169412
Closed

seonghobae wants to merge 5 commits into
developfrom
palette-ext-link-a11y-13898389422644169412

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: ๋Œ€์‹œ๋ณด๋“œ ๋‚ด ์™ธ๋ถ€ ๋งํฌ(Reference)์— ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์šฉ ์•ˆ๋‚ด ํ…์ŠคํŠธ์™€ ์‹œ๊ฐ์  ์•„์ด์ฝ˜์„ ์ถ”๊ฐ€ํ•˜๊ณ , ๊ธด URL์ด ๋ ˆ์ด์•„์›ƒ์„ ๋ฒ—์–ด๋‚˜์ง€ ์•Š๋„๋ก ์ค„๋ฐ”๊ฟˆ ์Šคํƒ€์ผ์„ ์ ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: target="_blank" ์†์„ฑ์„ ๊ฐ€์ง„ ์™ธ๋ถ€ ๋งํฌ๋Š” ์‹œ๊ฐ ์žฅ์• ์ธ ๋ฐ ์ผ๋ฐ˜ ์‚ฌ์šฉ์ž์—๊ฒŒ ์ƒˆ ์ฐฝ์ด ์—ด๋ฆฐ๋‹ค๋Š” ์‚ฌ์‹ค์„ ๋ช…ํ™•ํžˆ ์ „๋‹ฌํ•ด์•ผ ํ•˜๋ฉฐ, ๋ณด์•ˆ ๋ฆฌํฌํŠธ์— ํฌํ•จ๋œ ๊ธด URL์ด ํ™”๋ฉด์„ ๊นจ๋œจ๋ฆฌ๋Š” ๋ฌธ์ œ๋ฅผ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•ด์„œ์ž…๋‹ˆ๋‹ค.
โ™ฟ Accessibility: <span class="sr-only">(์ƒˆ ํƒญ์—์„œ ์—ด๋ฆผ)</span>์„ ํ†ตํ•ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž๋ฅผ ์ง€์›ํ•˜๊ณ , aria-hidden="true" ์†์„ฑ์„ ๊ฐ€์ง„ โ†— ์•„์ด์ฝ˜์„ ์ถ”๊ฐ€ํ•˜์—ฌ ์‹œ๊ฐ์ ์ธ ํžŒํŠธ๋ฅผ ์ œ๊ณตํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 13898389422644169412 started by @seonghobae

- ์™ธ๋ถ€ ๋งํฌ๊ฐ€ ์ƒˆ ํƒญ์—์„œ ์—ด๋ฆผ์„ ์‹œ๊ฐ์ (์•„์ด์ฝ˜), ์ฒญ๊ฐ์ (์Šคํฌ๋ฆฐ ๋ฆฌ๋”์šฉ ํ…์ŠคํŠธ)์œผ๋กœ ๋ช…ํ™•ํžˆ ์•ˆ๋‚ด
- ๊ธด URL์ด ๋ ˆ์ด์•„์›ƒ์„ ๊นจ์ง€ ์•Š๋„๋ก `.ext-link` ํด๋ž˜์Šค๋ฅผ ํ†ตํ•ด `word-break: break-all` ์ ์šฉ
- ๋Œ€์‹œ๋ณด๋“œ ์ฝ”์–ด ํ…Œ์ŠคํŠธ์— ์™ธ๋ถ€ ๋งํฌ ์ ‘๊ทผ์„ฑ ๊ฒ€์ฆ ์ฝ”๋“œ ์ถ”๊ฐ€
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head admission correction โ€” c6dc37e7a897f4ceb3a569be53cb860ef591b61f

Ready is review admission only. Fresh audit against base 2949d30718752ea5915c7713ba227e8c19d9e5bf found:

  • latest terminal workflow blockers: CodeQL PR 36616862940=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:31
@google-labs-jules

Copy link
Copy Markdown

Exact-head admission correction โ€” c6dc37e7a897f4ceb3a569be53cb860ef591b61f

Ready is review admission only. Fresh audit against base 2949d30718752ea5915c7713ba227e8c19d9e5bf found:

  • latest terminal workflow blockers: CodeQL PR 36616862940=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

์ฝ”๋“œ ์˜ค๋ฅ˜๋กœ ์ธํ•ด CI๊ฐ€ ์‹คํŒจํ•œ ๋ฌธ์ œ๋ฅผ ํ™•์ธํ–ˆ์Šต๋‹ˆ๋‹ค. ์ •๊ทœ์‹ ๋ฌธ์ž์—ด์˜ ์ด์Šค์ผ€์ดํ”„ ์˜ค๋ฅ˜๋ฅผ ์ˆ˜์ •ํ•˜์—ฌ ์ด์ œ ๋กœ์ปฌ์—์„œ ํ…Œ์ŠคํŠธ๊ฐ€ ํ†ต๊ณผํ•ฉ๋‹ˆ๋‹ค. ๋ณ€๊ฒฝ ์‚ฌํ•ญ์„ ํ‘ธ์‹œํ•˜์—ฌ ์ œ์ถœํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

- ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๋‚ด ์ž˜๋ชป๋œ ์ด์Šค์ผ€์ดํ”„ ๊ตฌ๋ฌธ(`\``) ์ œ๊ฑฐํ•˜์—ฌ CI ์—๋Ÿฌ ํ•ด๊ฒฐ
- `target="_blank"` ์ ‘๊ทผ์„ฑ ์†์„ฑ ์œ ์ง€

Copy link
Copy Markdown
Contributor Author

Verified canonical successor before retirement

Canonical successor: #1361 at bc98874b2c8f9349605e1036611692e05adc145e.

Valid-delta carryover:

Fresh exact-head evidence: #1353 has eight successful non-CodeQL workflows and CodeQL skipped; no approval or unresolved thread exists. #1361 remains Draft/Proposed, and its skipped CodeQL/review/UI gates are not transferred or bypassed.

I will preserve #1353 history and restore its three paths to protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf through ordinary child commits. Closure is allowed only after a fresh zero-file comparison; #1361 and stacked evidence #1364 remain open.

Copy link
Copy Markdown
Contributor Author

Retirement verification

The branch now ends at 5c725eed7b43321c3ed4c6db9fec7186b424ecf4 through ordinary child commits; no Force Push or destructive rebase was used.

Fresh comparison against protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf reports ahead_by: 5, behind_by: 0, and files: []. The effective diff is empty. All valid external-link requirements remain in open canonical successor #1361, while #1353's harmful word-break:break-all recommendation and incomplete one-locale claim were not carried.

Closing #1353 is therefore a verified-complete-carryover retirement. No successor Check, review, or readiness state is transferred.

@seonghobae seonghobae closed this Oct 3, 2026
@google-labs-jules

Copy link
Copy Markdown

Verified canonical successor before retirement

Canonical successor: #1361 at bc98874b2c8f9349605e1036611692e05adc145e.

Valid-delta carryover:

Fresh exact-head evidence: #1353 has eight successful non-CodeQL workflows and CodeQL skipped; no approval or unresolved thread exists. #1361 remains Draft/Proposed, and its skipped CodeQL/review/UI gates are not transferred or bypassed.

I will preserve #1353 history and restore its three paths to protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf through ordinary child commits. Closure is allowed only after a fresh zero-file comparison; #1361 and stacked evidence #1364 remain open.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant