Skip to content

๐ŸŽจ Palette: [์™ธ๋ถ€ ๋งํฌ ์ ‘๊ทผ์„ฑ ๋ฐ UX ๊ฐœ์„ ] - #1348

Closed
seonghobae wants to merge 3 commits into
developfrom
palette-external-links-accessibility-11978019631262255857
Closed

seonghobae wants to merge 3 commits into
developfrom
palette-external-links-accessibility-11978019631262255857

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

๐Ÿ’ก What: target="_blank" ์†์„ฑ์„ ๊ฐ€์ง€๋Š” ์™ธ๋ถ€ ๋งํฌ์— ๋Œ€ํ•ด ๋ณด์กฐ ๊ธฐ๊ธฐ ์‚ฌ์šฉ์ž๋ฅผ ์œ„ํ•œ ์•ˆ๋‚ด ํ…์ŠคํŠธ๋ฅผ ์ถ”๊ฐ€ํ•˜๊ณ , ๋ ˆ์ด์•„์›ƒ ๊นจ์ง์„ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•œ ์Šคํƒ€์ผ์„ ์Šค์ฝ”ํ•‘ํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: ๊ธฐ์กด ์ฝ”๋“œ๋Š” ๊ธด URL ํ…์ŠคํŠธ๋ฅผ ๊ฐ๋‹นํ•˜๊ธฐ ์œ„ํ•ด ์ „์—ญ์œผ๋กœ word-break: break-all์„ ์ ์šฉํ•˜๊ฑฐ๋‚˜ ๋ˆ„๋ฝํ•  ๊ฐ€๋Šฅ์„ฑ์ด ์žˆ์—ˆ๊ณ , ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์ž์—๊ฒŒ ์ƒˆ ํƒญ์ด ์—ด๋ฆฐ๋‹ค๋Š” ์‚ฌ์‹ค์„ ์ „๋‹ฌํ•˜์ง€ ์•Š์•˜์Šต๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ๋ชจ๋‹ฌ ์ฐฝ ๋‚ด References ๋งํฌ์— ์•„์ด์ฝ˜์ด ์ถ”๊ฐ€๋˜๊ณ , ์ง€๋‚˜์น˜๊ฒŒ ๊ธธ์–ด์ง€๋Š” URL ํ…์ŠคํŠธ๊ฐ€ ์ปจํ…Œ์ด๋„ˆ๋ฅผ ๋„˜์–ด๊ฐ€์ง€ ์•Š๋„๋ก ๊ฐœ์„ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.
โ™ฟ Accessibility: ๋ณด์ด์ง€ ์•Š๋Š” ํ…์ŠคํŠธ๋กœ (์ƒˆ ํƒญ์—์„œ ์—ด๋ฆผ)์„ ์ถ”๊ฐ€ํ•˜์—ฌ ์Šคํฌ๋ฆฐ ๋ฆฌ๋” ์‚ฌ์šฉ์„ฑ์„ ๊ฐœ์„ ํ•˜๊ณ , ์•„์ด์ฝ˜์€ aria-hidden="true"๋กœ ์„ค์ •ํ•˜์—ฌ ์ค‘๋ณต ์ฝ๊ธฐ๋ฅผ ๋ฐฉ์ง€ํ–ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 11978019631262255857 started by @seonghobae

์™ธ๋ถ€ ๋งํฌ์— ๋Œ€ํ•œ ์ ‘๊ทผ์„ฑ๊ณผ UI๋ฅผ ๊ฐœ์„ ํ•ฉ๋‹ˆ๋‹ค.

- `target="_blank"` ๋งํฌ์— `.sr-only` ํด๋ž˜์Šค๋กœ "์ƒˆ ํƒญ์—์„œ ์—ด๋ฆผ" ํ…์ŠคํŠธ ์ถ”๊ฐ€
- ์™ธ๋ถ€ ๋งํฌ์ž„์„ ์•Œ๋ฆฌ๋Š” ์•„์ด์ฝ˜ ์‚ฝ์ž… (์‹œ๊ฐ์  ๊ฐœ์„  ๋ฐ `aria-hidden="true"`)
- ๊ธด URL์ด ๋ ˆ์ด์•„์›ƒ์„ ๊นจ๋Š” ๊ฒƒ์„ ๋ฐฉ์ง€ํ•˜๊ธฐ ์œ„ํ•ด `word-break: break-all`์ด ์ „์—ญ์œผ๋กœ ์ ์šฉ๋˜์ง€ ์•Š๊ณ  `.ext-link` ์œ ํ‹ธ๋ฆฌํ‹ฐ ํด๋ž˜์Šค๋กœ ์ œํ•œ๋˜๋„๋ก ์Šค์ฝ”ํ•‘
@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot ยท Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Exact-head admission correction โ€” 4f3373660904f43bc3bbc9ad777d6f77209153bb

Ready is review admission only. Fresh audit against base 2949d30718752ea5915c7713ba227e8c19d9e5bf found:

  • latest terminal workflow blockers: CodeQL PR 36468562755=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

@seonghobae
seonghobae marked this pull request as draft September 30, 2026 05:24
@google-labs-jules

Copy link
Copy Markdown

Exact-head admission correction โ€” 4f3373660904f43bc3bbc9ad777d6f77209153bb

Ready is review admission only. Fresh audit against base 2949d30718752ea5915c7713ba227e8c19d9e5bf found:

  • latest terminal workflow blockers: CodeQL PR 36468562755=failure

This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed.

Understood. Acknowledging that this work is now obsolete due to the exact-head admission correction, and stopping work on this task.

Copy link
Copy Markdown
Contributor Author

Verified canonical successor before retirement

Canonical successor: #1361 at bc98874b2c8f9349605e1036611692e05adc145e.

Valid-delta carryover:

Historical exact-head evidence is preserved here: #1348 had nine successful workflows, including CodeQL run 36468562755. That evidence does not transfer to #1361; #1361 remains Draft/Proposed with CodeQL skipped and outstanding review/UI acceptance gates.

I will restore #1348's two changed paths to protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf through ordinary child commits. Closure is allowed only after a fresh zero-file comparison; #1361 and #1364 remain open.

Copy link
Copy Markdown
Contributor Author

Retirement verification

The branch now ends at 1687847dbef9d228b7587c779930cdff3e2f596d through ordinary child commits; no Force Push or destructive rebase was used.

Fresh comparison against protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf reports ahead_by: 3, behind_by: 0, and files: []. The effective diff is empty. All valid external-link requirements remain in open canonical successor #1361; the historical successful Checks remain documented above and are not transferred.

Closing #1348 is therefore a verified-complete-carryover retirement.

@seonghobae seonghobae closed this Oct 3, 2026
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Security Oct 3, 2026
@google-labs-jules

Copy link
Copy Markdown

Verified canonical successor before retirement

Canonical successor: #1361 at bc98874b2c8f9349605e1036611692e05adc145e.

Valid-delta carryover:

Historical exact-head evidence is preserved here: #1348 had nine successful workflows, including CodeQL run 36468562755. That evidence does not transfer to #1361; #1361 remains Draft/Proposed with CodeQL skipped and outstanding review/UI acceptance gates.

I will restore #1348's two changed paths to protected develop@2949d30718752ea5915c7713ba227e8c19d9e5bf through ordinary child commits. Closure is allowed only after a fresh zero-file comparison; #1361 and #1364 remain open.

Understood. Acknowledging that this PR (#1348) is superseded by #1361, which introduces stricter locale contracts and testing for overflow-wrap:anywhere. I am stopping further work on this task, as the current state is now obsolete and requires a fresh zero-file comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant