Repository navigation
๐จ Palette: [์ธ๋ถ ๋งํฌ ์ ๊ทผ์ฑ ๋ฐ UX ๊ฐ์ ] - #1348
seonghobae wants to merge 3 commits into
Conversation
์ธ๋ถ ๋งํฌ์ ๋ํ ์ ๊ทผ์ฑ๊ณผ UI๋ฅผ ๊ฐ์ ํฉ๋๋ค. - `target="_blank"` ๋งํฌ์ `.sr-only` ํด๋์ค๋ก "์ ํญ์์ ์ด๋ฆผ" ํ ์คํธ ์ถ๊ฐ - ์ธ๋ถ ๋งํฌ์์ ์๋ฆฌ๋ ์์ด์ฝ ์ฝ์ (์๊ฐ์ ๊ฐ์ ๋ฐ `aria-hidden="true"`) - ๊ธด URL์ด ๋ ์ด์์์ ๊นจ๋ ๊ฒ์ ๋ฐฉ์งํ๊ธฐ ์ํด `word-break: break-all`์ด ์ ์ญ์ผ๋ก ์ ์ฉ๋์ง ์๊ณ `.ext-link` ์ ํธ๋ฆฌํฐ ํด๋์ค๋ก ์ ํ๋๋๋ก ์ค์ฝํ
|
๐ Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a ๐ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Exact-head admission correction โ Ready is review admission only. Fresh audit against base
This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed. |
Understood. Acknowledging that this work is now obsolete due to the exact-head admission correction, and stopping work on this task. |
Verified canonical successor before retirementCanonical successor: #1361 at Valid-delta carryover:
Historical exact-head evidence is preserved here: #1348 had nine successful workflows, including CodeQL run I will restore #1348's two changed paths to protected |
Retirement verificationThe branch now ends at Fresh comparison against protected Closing #1348 is therefore a verified-complete-carryover retirement. |
Understood. Acknowledging that this PR (#1348) is superseded by #1361, which introduces stricter locale contracts and testing for |
๐ก What:
target="_blank"์์ฑ์ ๊ฐ์ง๋ ์ธ๋ถ ๋งํฌ์ ๋ํด ๋ณด์กฐ ๊ธฐ๊ธฐ ์ฌ์ฉ์๋ฅผ ์ํ ์๋ด ํ ์คํธ๋ฅผ ์ถ๊ฐํ๊ณ , ๋ ์ด์์ ๊นจ์ง์ ๋ฐฉ์งํ๊ธฐ ์ํ ์คํ์ผ์ ์ค์ฝํํ์ต๋๋ค.๐ฏ Why: ๊ธฐ์กด ์ฝ๋๋ ๊ธด URL ํ ์คํธ๋ฅผ ๊ฐ๋นํ๊ธฐ ์ํด ์ ์ญ์ผ๋ก
word-break: break-all์ ์ ์ฉํ๊ฑฐ๋ ๋๋ฝํ ๊ฐ๋ฅ์ฑ์ด ์์๊ณ , ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์์๊ฒ ์ ํญ์ด ์ด๋ฆฐ๋ค๋ ์ฌ์ค์ ์ ๋ฌํ์ง ์์์ต๋๋ค.๐ธ Before/After: ๋ชจ๋ฌ ์ฐฝ ๋ด References ๋งํฌ์ ์์ด์ฝ์ด ์ถ๊ฐ๋๊ณ , ์ง๋์น๊ฒ ๊ธธ์ด์ง๋ URL ํ ์คํธ๊ฐ ์ปจํ ์ด๋๋ฅผ ๋์ด๊ฐ์ง ์๋๋ก ๊ฐ์ ๋์์ต๋๋ค.
โฟ Accessibility: ๋ณด์ด์ง ์๋ ํ ์คํธ๋ก
(์ ํญ์์ ์ด๋ฆผ)์ ์ถ๊ฐํ์ฌ ์คํฌ๋ฆฐ ๋ฆฌ๋ ์ฌ์ฉ์ฑ์ ๊ฐ์ ํ๊ณ , ์์ด์ฝ์aria-hidden="true"๋ก ์ค์ ํ์ฌ ์ค๋ณต ์ฝ๊ธฐ๋ฅผ ๋ฐฉ์งํ์ต๋๋ค.PR created automatically by Jules for task 11978019631262255857 started by @seonghobae