Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .jules/palette.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,7 @@
## 2026-08-12 - Skip to Content Accessibility
**Learning:** Screen reader and keyboard-only users experience significant friction when forced to navigate through repetitive header controls on every page load.
**Action:** Keep a visible-on-focus skip link as the first interactive element, target a programmatically focusable main container, and give the focused link a high-contrast outline.

## 2026-08-15 - Label-in-name for proxy buttons
**Learning:** When replacing a native file input with a proxy button for better styling, duplicating the `aria-label` on the button when its visible text already perfectly describes the action creates redundant screen reader output. If the proxy button's text is 'Upload findings file', adding `aria-label="Upload findings file"` is unnecessary and violates the label-in-name principle.
**Action:** Rely on the button's visible text for its accessible name, and keep the visually hidden native input hidden from screen readers to prevent duplicate interactive elements.
2 changes: 2 additions & 0 deletions CHANGELOG.d/9999-dashboard-header-upload-btn.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
### Changed
- (Dashboard) 헤더의 기본 파일 업로드 입력을 스타일이 적용된 프록시 버튼으로 교체하여 시각적 일관성과 사용자 경험을 개선했습니다.
5 changes: 4 additions & 1 deletion scanner/dashboard/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
<span class="logo"></span><span class="brand">AppGuardrail</span>
<span class="spacer"></span>
<span class="meta" id="src">no findings loaded</span>
<input type="file" id="file" accept="application/json,.json" aria-label="Upload findings file" style="margin-left:12px">
<button type="button" id="header-upload-btn" class="primary-action" style="margin-left:12px">Upload findings file</button>
<input type="file" id="file" accept="application/json,.json" hidden>
</header>
<p id="findings-summary" class="sr-only" role="status" aria-live="polite" aria-atomic="true"></p>
<main id="app" tabindex="-1"></main>
Expand Down Expand Up @@ -325,6 +326,8 @@ <h1>Dashboard</h1>
}

const fileInput = document.getElementById('file');
const headerBtn = document.getElementById('header-upload-btn');
if (headerBtn) headerBtn.addEventListener('click', () => fileInput.click());
fileInput.addEventListener('change', () => {
const selectedFile = fileInput.files?.[0];
fileInput.value = '';
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dashboard_core.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test_dashboard_rows_are_keyboard_accessible():
assert 'tabindex="0" role="button"' in html
assert 'title="View details for finding"' in html
assert "tbody tr:focus-visible" in html
assert "aria-label=\"Upload findings file\"" in html
assert ">Upload findings file</button>" in html
assert "aria-label=\"Search findings\"" in html
assert "aria-label=\"Filter by severity\"" in html
assert "tr.addEventListener('keydown'" in html
Expand Down
Loading