Skip to content

fix(url): malformed webhook URL에서 empty host를 거부 #1210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
seonghobae wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

fix(url): malformed webhook URL에서 empty host를 거부 #1210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
86fa93b
Fix empty hostname SSRF bypass in URL validation
seonghobae Sep 10, 2026
7d312ba
Fix empty hostname SSRF bypass in URL validation
seonghobae Sep 10, 2026
bb7ea14
Fix empty hostname SSRF bypass in URL validation
seonghobae Sep 10, 2026
56515db
repair(url): preserve empty-host rejection without SSRF overclaim
seonghobae Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions appguardrail_core/controlplane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,8 @@ def _is_safe_url(url: str) -> bool:
return False

host = (parsed.hostname or "").lower()
if not host:
return False
raw = host.split("%", 1)[0].strip("[]")

def is_bad_ip(ip) -> bool:
Expand Down
9 changes: 9 additions & 0 deletions tests/test_controlplane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,3 +505,12 @@ def test_negative_content_length_rejected(server):
resp = conn.getresponse()
assert resp.status == 400
conn.close()

def test_api_set_webhook_ssrf_protection_empty_host(server):
base, key = server
# Invalid empty host
for invalid_url in ["http://", "http://user:pass@", "https://"]:
with pytest.raises(urllib.error.HTTPError) as exc:
_req("POST", f"{base}/api/v1/webhook", key, {"url": invalid_url})
assert exc.value.code == 400
assert json.loads(exc.value.read())["error"] == "invalid webhook url"
Loading