Skip to content

ui(dashboard): retire duplicate findings-picker proxy lane #1203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 4 commits into from
Closed

ui(dashboard): retire duplicate findings-picker proxy lane #1203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0494a2b
🎨 Palette: 파일 업로드 인풋을 일관된 버튼으로 교체하여 접근성 및 UI 개선
seonghobae Sep 10, 2026
8af5772
🎨 Palette: 파일 업로드 인풋을 일관된 버튼으로 교체하여 접근성 및 UI 개선
seonghobae Sep 10, 2026
4e3a7a7
🎨 Palette: 파일 업로드 인풋을 일관된 버튼으로 교체하여 접근성 및 UI 개선
seonghobae Sep 10, 2026
81d857d
docs(ui): remove unverified global file-input proxy doctrine
seonghobae Sep 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scanner/dashboard/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@
<span class="logo"></span><span class="brand">AppGuardrail</span>
<span class="spacer"></span>
<span class="meta" id="src">no findings loaded</span>
<input type="file" id="file" accept="application/json,.json" aria-label="Upload findings file" style="margin-left:12px">
<button type="button" id="header-browse-findings" class="primary-action" style="margin-left:12px">Upload findings file</button>
<input type="file" id="file" accept="application/json,.json" hidden>
</header>
<p id="findings-summary" class="sr-only" role="status" aria-live="polite" aria-atomic="true"></p>
<main id="app" tabindex="-1"></main>
Expand Down Expand Up @@ -325,6 +326,10 @@ <h1>Dashboard</h1>
}

const fileInput = document.getElementById('file');
const headerBrowseFindings = document.getElementById('header-browse-findings');
if (headerBrowseFindings) {
headerBrowseFindings.addEventListener('click', () => fileInput.click());
}
fileInput.addEventListener('change', () => {
const selectedFile = fileInput.files?.[0];
fileInput.value = '';
Expand Down
2 changes: 1 addition & 1 deletion tests/test_dashboard_core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ def test_dashboard_rows_are_keyboard_accessible():
assert 'tabindex="0" role="button"' in html
assert 'title="View details for finding"' in html
assert "tbody tr:focus-visible" in html
assert "aria-label=\"Upload findings file\"" in html
assert "Upload findings file</button>" in html
assert "aria-label=\"Search findings\"" in html
assert "aria-label=\"Filter by severity\"" in html
assert "tr.addEventListener('keydown'" in html
Expand Down
Loading