Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.d/1099-claude-plugin-supply-chain.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,16 @@
`claude-plugin-conda-upload-command`. ``cabal upload`` and
``cabal v2-upload`` fail as `claude-plugin-cabal-upload-command`.
``mvn deploy`` fails as `claude-plugin-mvn-deploy-command`.
``gradle publish`` and ``gradlew publish`` fail as
`claude-plugin-gradle-publish-command`. ``luarocks upload`` fails as
`claude-plugin-luarocks-upload-command`.
Hook comments and
``echo``/``printf`` lookalikes are not those classes.
``terraform plan``, ``helm list``,
``vercel ls``, ``fly status``, ``aws s3 ls``, ``gcloud config list``,
``az account show``, ``npm pack``, ``cargo check``, ``gem list``,
``nuget list``, ``hex info``, ``conda list``, ``cabal list``, and
``mvn package``
``nuget list``, ``hex info``, ``conda list``, ``cabal list``,
``mvn package``, ``gradle tasks``, and ``luarocks list``
stay inventory. Hardcoded
PATs stay `claude-plugin-github-write-token`. Snippets are command
labels, not tokens.
Expand Down
82 changes: 81 additions & 1 deletion appguardrail_core/claude_plugin_detector.py
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,16 @@
"package is write authority on a Maven repository. Remove the command. "
"[CWE-250 - Execution with Unnecessary Privileges]"
)
CLAUDE_PLUGIN_GRADLE_PUBLISH_COMMAND_MESSAGE: Final = (
"Claude plugin hook or manifest runs gradle publish. Publishing a "
"package is write authority on a Maven repository. Remove the command. "
"[CWE-269 - Improper Privilege Management]"
)
CLAUDE_PLUGIN_LUAROCKS_UPLOAD_COMMAND_MESSAGE: Final = (
"Claude plugin hook or manifest runs luarocks upload. Publishing a "
"package is write authority on LuaRocks. Remove the command. "
"[CWE-250 - Execution with Unnecessary Privileges]"
)
CLAUDE_PLUGIN_DOCKER_SOCKET_MESSAGE: Final = (
"Claude plugin hook reaches the host Docker socket. Socket access is host "
"control, not an image push. Remove the socket bind and keep builds "
Expand Down Expand Up @@ -554,6 +564,14 @@
r"\bmvn\s+deploy\b",
re.IGNORECASE,
)
_GRADLE_PUBLISH_COMMAND = re.compile(
r"\b(?P<cli>gradlew?)\s+publish\b",
re.IGNORECASE,
)
_LUAROCKS_UPLOAD_COMMAND = re.compile(
r"\bluarocks\s+upload\b",
re.IGNORECASE,
)
_REPORTING_BUILTINS: Final = frozenset({"echo", "printf", "print"})
_FIRST_SHELL_TOKEN = re.compile(r"\s*([A-Za-z0-9_./+-]+)")
_LITERAL_HEREDOC_OPEN = re.compile(
Expand Down Expand Up @@ -847,7 +865,9 @@
r"mix\s+hex\.publish|hex\s+publish|"
r"(?:conda|anaconda)\s+upload|"
r"cabal\s+(?:v2-)?upload|"
r"mvn\s+deploy)\b",
r"mvn\s+deploy|"
r"gradlew?\s+publish|"
r"luarocks\s+upload)\b",
re.IGNORECASE,
),
),
Expand Down Expand Up @@ -1080,6 +1100,8 @@ def inspect_claude_plugin_file(
hits.extend(_conda_upload_command_hits(content, manifest=manifest))
hits.extend(_cabal_upload_command_hits(content, manifest=manifest))
hits.extend(_mvn_deploy_command_hits(content, manifest=manifest))
hits.extend(_gradle_publish_command_hits(content, manifest=manifest))
hits.extend(_luarocks_upload_command_hits(content, manifest=manifest))
hits.extend(_docker_socket_hits(content))
hits.extend(_browser_profile_hits(content))
hits.extend(_credential_store_hits(content))
Expand Down Expand Up @@ -2734,6 +2756,64 @@ def _mvn_deploy_command_hits(
return ()


def _gradle_publish_command_hits(
content: str, *, manifest: bool = False
) -> tuple[PluginHit, ...]:
"""Return ``gradle publish`` findings with a command label, not task names.

Args:
content: Hook or manifest text.
manifest: When true, only structural command values are scanned.

Returns:
One hit for executable ``gradle publish`` or ``gradlew publish``.
``gradle tasks`` and ``gradle publishToMavenLocal`` are not this
class. ``mvn deploy`` stays the Maven class.
"""
for source, first_line in _hosted_command_sources(content, manifest=manifest):
match = _executable_command_match(source, _GRADLE_PUBLISH_COMMAND)
if match is None:
continue
snippet = match.group("cli").lower() + " publish"
return (
PluginHit(
rule_id="claude-plugin-gradle-publish-command",
line=first_line + source[: match.start()].count("\n"),
snippet=snippet,
message=CLAUDE_PLUGIN_GRADLE_PUBLISH_COMMAND_MESSAGE,
),
)
return ()


def _luarocks_upload_command_hits(
content: str, *, manifest: bool = False
) -> tuple[PluginHit, ...]:
"""Return ``luarocks upload`` findings with a command label, not rock names.

Args:
content: Hook or manifest text.
manifest: When true, only structural command values are scanned.

Returns:
One hit for executable ``luarocks upload``. ``luarocks list`` is
not this class.
"""
for source, first_line in _hosted_command_sources(content, manifest=manifest):
match = _executable_command_match(source, _LUAROCKS_UPLOAD_COMMAND)
if match is None:
continue
return (
PluginHit(
rule_id="claude-plugin-luarocks-upload-command",
line=first_line + source[: match.start()].count("\n"),
snippet="luarocks upload",
message=CLAUDE_PLUGIN_LUAROCKS_UPLOAD_COMMAND_MESSAGE,
),
)
return ()


def _dynamic_eval_hits(content: str) -> tuple[PluginHit, ...]:
"""Return findings for eval/exec/compile/Function on hook surfaces."""
match = _DYNAMIC_EVAL.search(content)
Expand Down
2 changes: 1 addition & 1 deletion docs/TRACEABILITY.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
| structural Semgrep-style `pattern:` execution by lightweight engine | built-in scanner | not implemented unless a real structural matcher is added; fixtures are not execution |
| GitHub Actions transport-only polling loop (#1087, #938 vertical slice) | owned by PR #1088 / issue #1087; YAML rules and RED precision contracts | mapped-family only; this successor does not ship or close the detector |
| Password/database-url/auth-comment precision and test-file context (#1106) | existing `_scan_file` rules `hardcoded-password`, `hardcoded-database-url`, `todo-skip-auth`, `_finding_context` | implemented-branch regression lock |
| Claude plugin marketplace/package supply chain (#1099) | `claude-plugin-floating-git-ref`, `claude-plugin-provider-secret`, `claude-plugin-pipe-to-shell`, `claude-plugin-unsigned-executable-download` (hooks and package.json lifecycle scripts), `claude-plugin-unpinned-package-install`, `claude-plugin-undeclared-executable`, `claude-plugin-symlink-escape`, `claude-plugin-archive-path-traversal`, `claude-plugin-unadmitted-submodule`, `claude-plugin-duplicate-json-member`, `claude-plugin-nonstandard-json-constant`, `claude-plugin-malformed-utf8`, `claude-plugin-inconsistent-normalized-name`, `claude-plugin-vendored-scope-undeclared`, `claude-plugin-conflicting-identity`, `claude-plugin-unbounded-mcp`, `claude-plugin-license-missing`, `claude-plugin-license-mismatch`, `claude-plugin-dynamic-eval`, `claude-plugin-hidden-undeclared-executable`, `claude-plugin-concealed-identity`, `claude-plugin-oversized-package`, `claude-plugin-source-mismatch`, `claude-plugin-github-write-token`, `claude-plugin-docker-socket`, `claude-plugin-browser-profile-access`, `claude-plugin-deceptive-description`, `claude-plugin-secret-to-network`, `claude-plugin-secret-to-prompt`, `claude-plugin-secret-to-mcp`, `claude-plugin-hide-actions-directive` / `claude-plugin-self-modify-directive` / `claude-plugin-goal-escalation-directive`, `claude-plugin-setuid-executable` / `claude-plugin-world-writable-executable`, `claude-plugin-decompression-bomb`, reused #1036 `skill-name-homoglyph-confusable` / `skill-manifest-prompt-injection-payload` / `skill-doc-exfiltration-endpoint-directive` / `skill-placeholder-template-unresolved` on plugin skill/agent/command surfaces, deterministic scan receipt with catalog repository/SHA bind, SARIF 2.1.0 `sarif_sha256` bound to the same finding rule_ids, `policy_provenance` bound to the AppGuardrail release plus exact scan-policy digest, and `sbom_sha256` of a deterministic CycloneDX 1.5 document, `claude-plugin-checksum-mismatch` when a first-party SHA256SUMS or sibling `*.sha256` disagrees with bytes on disk, `claude-plugin-unsigned-checksum` when checksum digest rows have no sibling Cosign/GPG signature file, `claude-plugin-excessive-path-depth` when a materialized file or archive member nests past 32 path components, `claude-plugin-github-merge-command` for hook or manifest `gh pr merge`, `claude-plugin-github-release-command` for `gh release create|upload|delete|edit`, `claude-plugin-kubectl-apply-command` for hook or manifest `kubectl apply`, `claude-plugin-docker-push-command` for `docker push`, `claude-plugin-terraform-apply-command` for `terraform apply`, `claude-plugin-helm-install-command` for `helm install`, `claude-plugin-vercel-deploy-command` for hook or manifest `vercel deploy`, `claude-plugin-fly-deploy-command` for `fly deploy`, `claude-plugin-aws-deploy-command` for hook or manifest `aws cloudformation deploy`, `claude-plugin-gcloud-deploy-command` for `gcloud run deploy`, `claude-plugin-az-deploy-command` for `az webapp deploy`, `claude-plugin-aws-s3-write-command` for hook or manifest `aws s3 sync`/`cp`, `claude-plugin-az-containerapp-up-command` for `az containerapp up`, `claude-plugin-npm-publish-command` for hook or manifest `npm publish`, `claude-plugin-pypi-upload-command` for `twine upload`, `claude-plugin-cargo-publish-command` for `cargo publish`, `claude-plugin-pnpm-publish-command` for `pnpm publish`, `claude-plugin-uv-publish-command` for `uv publish`, `claude-plugin-poetry-publish-command` for `poetry publish`, `claude-plugin-gem-push-command` for hook or manifest `gem push`, `claude-plugin-nuget-push-command` for `nuget push`, `claude-plugin-pub-publish-command` for `dart pub publish`/`flutter pub publish`, `claude-plugin-hex-publish-command` for `hex publish`/`mix hex.publish`, `claude-plugin-conda-upload-command` for `conda upload`/`anaconda upload`, `claude-plugin-cabal-upload-command` for `cabal upload`/`cabal v2-upload`, `claude-plugin-mvn-deploy-command` for `mvn deploy`, `claude-plugin-credential-store-access` for host cookie and token stores that are not browser profiles, fail-closed receipt verification | implemented-branch |
| Claude plugin marketplace/package supply chain (#1099) | `claude-plugin-floating-git-ref`, `claude-plugin-provider-secret`, `claude-plugin-pipe-to-shell`, `claude-plugin-unsigned-executable-download` (hooks and package.json lifecycle scripts), `claude-plugin-unpinned-package-install`, `claude-plugin-undeclared-executable`, `claude-plugin-symlink-escape`, `claude-plugin-archive-path-traversal`, `claude-plugin-unadmitted-submodule`, `claude-plugin-duplicate-json-member`, `claude-plugin-nonstandard-json-constant`, `claude-plugin-malformed-utf8`, `claude-plugin-inconsistent-normalized-name`, `claude-plugin-vendored-scope-undeclared`, `claude-plugin-conflicting-identity`, `claude-plugin-unbounded-mcp`, `claude-plugin-license-missing`, `claude-plugin-license-mismatch`, `claude-plugin-dynamic-eval`, `claude-plugin-hidden-undeclared-executable`, `claude-plugin-concealed-identity`, `claude-plugin-oversized-package`, `claude-plugin-source-mismatch`, `claude-plugin-github-write-token`, `claude-plugin-docker-socket`, `claude-plugin-browser-profile-access`, `claude-plugin-deceptive-description`, `claude-plugin-secret-to-network`, `claude-plugin-secret-to-prompt`, `claude-plugin-secret-to-mcp`, `claude-plugin-hide-actions-directive` / `claude-plugin-self-modify-directive` / `claude-plugin-goal-escalation-directive`, `claude-plugin-setuid-executable` / `claude-plugin-world-writable-executable`, `claude-plugin-decompression-bomb`, reused #1036 `skill-name-homoglyph-confusable` / `skill-manifest-prompt-injection-payload` / `skill-doc-exfiltration-endpoint-directive` / `skill-placeholder-template-unresolved` on plugin skill/agent/command surfaces, deterministic scan receipt with catalog repository/SHA bind, SARIF 2.1.0 `sarif_sha256` bound to the same finding rule_ids, `policy_provenance` bound to the AppGuardrail release plus exact scan-policy digest, and `sbom_sha256` of a deterministic CycloneDX 1.5 document, `claude-plugin-checksum-mismatch` when a first-party SHA256SUMS or sibling `*.sha256` disagrees with bytes on disk, `claude-plugin-unsigned-checksum` when checksum digest rows have no sibling Cosign/GPG signature file, `claude-plugin-excessive-path-depth` when a materialized file or archive member nests past 32 path components, `claude-plugin-github-merge-command` for hook or manifest `gh pr merge`, `claude-plugin-github-release-command` for `gh release create|upload|delete|edit`, `claude-plugin-kubectl-apply-command` for hook or manifest `kubectl apply`, `claude-plugin-docker-push-command` for `docker push`, `claude-plugin-terraform-apply-command` for `terraform apply`, `claude-plugin-helm-install-command` for `helm install`, `claude-plugin-vercel-deploy-command` for hook or manifest `vercel deploy`, `claude-plugin-fly-deploy-command` for `fly deploy`, `claude-plugin-aws-deploy-command` for hook or manifest `aws cloudformation deploy`, `claude-plugin-gcloud-deploy-command` for `gcloud run deploy`, `claude-plugin-az-deploy-command` for `az webapp deploy`, `claude-plugin-aws-s3-write-command` for hook or manifest `aws s3 sync`/`cp`, `claude-plugin-az-containerapp-up-command` for `az containerapp up`, `claude-plugin-npm-publish-command` for hook or manifest `npm publish`, `claude-plugin-pypi-upload-command` for `twine upload`, `claude-plugin-cargo-publish-command` for `cargo publish`, `claude-plugin-pnpm-publish-command` for `pnpm publish`, `claude-plugin-uv-publish-command` for `uv publish`, `claude-plugin-poetry-publish-command` for `poetry publish`, `claude-plugin-gem-push-command` for hook or manifest `gem push`, `claude-plugin-nuget-push-command` for `nuget push`, `claude-plugin-pub-publish-command` for `dart pub publish`/`flutter pub publish`, `claude-plugin-hex-publish-command` for `hex publish`/`mix hex.publish`, `claude-plugin-conda-upload-command` for `conda upload`/`anaconda upload`, `claude-plugin-cabal-upload-command` for `cabal upload`/`cabal v2-upload`, `claude-plugin-mvn-deploy-command` for `mvn deploy`, `claude-plugin-gradle-publish-command` for `gradle publish`/`gradlew publish`, `claude-plugin-luarocks-upload-command` for `luarocks upload`, `claude-plugin-credential-store-access` for host cookie and token stores that are not browser profiles, fail-closed receipt verification | implemented-branch |
| Orphaned GitHub Actions registry identities (#929) | owned by PR #966 / issue #929; live registry DAST | mapped-family only; this successor does not ship or close the detector |
| Org security-failure CI tickets without copied vuln evidence | documented non-detectable family | snapshot in `tests/fixtures/cwl-security-issue-inventory.json` |

Expand Down
6 changes: 4 additions & 2 deletions docs/sast-dast-rule-research.md
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,8 @@ files being scanned, then applies the union of relevant checks. Examples:
`claude-plugin-conda-upload-command` for ``conda upload``,
`claude-plugin-cabal-upload-command` for ``cabal upload``,
`claude-plugin-mvn-deploy-command` for ``mvn deploy``,
`claude-plugin-gradle-publish-command` for ``gradle publish``,
`claude-plugin-luarocks-upload-command` for ``luarocks upload``,
and
`claude-plugin-credential-store-access` for host ``~/.netrc``,
``~/.aws/credentials``, GitHub CLI hosts, Docker auth, cookie jars, and
Expand All @@ -134,8 +136,8 @@ files being scanned, then applies the union of relevant checks. Examples:
``kubectl get``, ``docker ps``, ``terraform plan``, ``helm list``,
``vercel ls``, ``fly status``, ``aws s3 ls``, ``gcloud config list``,
``az account show``, ``npm pack``, ``cargo check``, ``gem list``,
``nuget list``, ``hex info``, ``conda list``, ``cabal list``, and
``mvn package`` stay inventory.
``nuget list``, ``hex info``, ``conda list``, ``cabal list``,
``mvn package``, ``gradle tasks``, and ``luarocks list`` stay inventory.
- Mapped, not owned here: GitHub Actions transport-only poll loops (#1087,
PR #1088) and orphaned workflow registry DAST (#929, PR #966).
- `tool-execute-parameters-passthrough`: Strix-observed dynamic tool execution
Expand Down
Loading