🛡️ Sentinel: [MEDIUM] 입력 검증 정규식 제한 강화

.Rbuildignore

@@ -24,3 +24,4 @@
 ^\.jules(/.*)?$
 ^\.trivyignore\.yaml$
 ^trivy\.yaml$
+^\.semgrepignore$

.jules/sentinel.md

@@ -2,3 +2,9 @@
 **Vulnerability:** Unvalidated inputs passed to `if()` statements can cause process crashes (`condition has length > 1`) or unexpected coercion vulnerabilities.
 **Learning:** In R, optional boolean parameters that default to `NULL` should be validated using explicit runtime type validation (e.g., `if (!is.null(flag) && (!is.logical(flag) || length(flag) != 1 || is.na(flag)))`).
 **Prevention:** Always implement explicit runtime type validation for optional boolean parameters.
+
+
+## 2024-05-18 - Insecure regex binding vulnerability in readline input
+**취약점:** `aFIPC::autoFIPC()` 내부의 인터랙티브 `readline` 입력 검증에 약한 정규식 `^[0-9]+$` 가 사용됨.
+**학습:** `as.integer()`는 `2^31 - 1` 까지만 처리할 수 있으며, 이 범위를 넘는 임의의 긴 숫자열이 입력될 경우 조용히 `NA`를 반환함. 이로 인해 다운스트림 로직이 깨지는 취약점이 발생함.
+**방지:** 입력을 정확하게 제한해야 함. 1과 2만 선택받는 프롬프트라면, `^[12]$` 와 같이 엄격한 정규식을 사용하여 입력을 필터링함.

DESCRIPTION

@@ -10,7 +10,7 @@ Description: Automates fixed item parameter linking for test linking under
     the item response theory paradigm using mirt package estimates.
 License: GPL-3 | file LICENSE
 Imports: mirt, methods
-Suggests: testthat (>= 3.0.0)
+Suggests: testthat (>= 3.0.0), mockery
 Encoding: UTF-8
 Config/testthat/edition: 3
 Config/roxygen2/version: 8.0.0

R/aFIPC.R

@@ -141,7 +141,7 @@ autoFIPC <-
       }
       for (attempt in seq_len(3)) {
         n <- readline(prompt = "Is it correct? (1: Yes 2: No) : ")
-        if (grepl("^[0-9]+$", n)) {
+        if (grepl("^[12]$", n)) {
           return(as.integer(n))
         }
       }
@@ -171,7 +171,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for oldform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }
@@ -390,7 +390,7 @@ autoFIPC <-
               readline(
                 prompt = "Do you want to use default BILOG-MG priors for newform Data? (1: Yes 2: No) : "
               )
-            if (grepl("^[0-9]+$", n)) {
+            if (grepl("^[12]$", n)) {
               return(as.integer(n))
             }
           }

tests/testthat/test-sentinel-validation-fix.R

@@ -0,0 +1,36 @@
+test_that("Sentinel: autoFIPC readline prompt uses strict regex", {
+  # In R CMD check, we have the exported functions directly available.
+
+  # Mock interactive to bypass immediate stop
+  mockery::stub(autoFIPC, "interactive", function() TRUE)
+
+  # Mock checkCorrect interactive input - test strict bound bypass vs valid (1)
+  # When giving invalid inputs ("3", "4", "abc"), autoFIPC prompts again up to 3 times
+  # We provide a valid "1" on the second attempt to see if it bypasses the invalid inputs
+  mockery::stub(autoFIPC, "readline", mockery::mock("3", "1", cycle = TRUE))
+
+  # Prevent estimating models loop
+  mockery::stub(autoFIPC, "mirt::mirt", function(data, ...) {
+    mod <- new("SingleGroupClass")
+    mod@OptimInfo$converged <- TRUE
+    mod@OptimInfo$secondordertest <- TRUE
+    mod@Data$data <- data
+    return(mod)
+  })
+
+  res <- tryCatch({
+      autoFIPC(
+        newformXData = data.frame(V1=1, V2=2),
+        oldformYData = data.frame(V1=1, V2=2),
+        newformCommonItemNames = c('V1'),
+        oldformCommonItemNames = c('V1'),
+        confirmCommonItems = NULL
+      )
+    },
+    error = function(e) e$message
+  )
+
+  # We should reach the mirt stub, which will throw error downstream or return cleanly
+  # The fact that it doesn't throw 'Too many invalid common item confirmation attempts' means it correctly rejected '3' and accepted '1'
+  expect_false(grepl("Too many invalid", res))
+})