Skip to content

refactor(autoFIPC): repaired and superseded by tested #324 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 3 commits into from
Closed

refactor(autoFIPC): repaired and superseded by tested #324 #310

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dae92b9
⚡ Bolt: 성능 향상 - 불필요한 메모리 복사 및 함수 오버헤드 제거
seonghobae Aug 30, 2026
600b50a
⚡ Bolt: 성능 향상 - 불필요한 메모리 복사 및 함수 오버헤드 제거
seonghobae Aug 30, 2026
645fe10
repair(autoFIPC): restore strict column-subset semantics
seonghobae Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions R/aFIPC.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,8 +770,8 @@ autoFIPC <-
if (
!is.na(newFormItemName) &&
!is.na(oldFormItemName) &&
(length(stats::na.omit(unique(newFormModel@Data$data[, newFormItemName]))) ==
length(stats::na.omit(unique(oldFormModel@Data$data[, oldFormItemName]))))
(sum(!is.na(unique(newFormModel@Data$data[, newFormItemName]))) ==
sum(!is.na(unique(oldFormModel@Data$data[, oldFormItemName]))))
Comment on lines +773 to +774

@devin-ai-integration devin-ai-integration Bot Aug 30, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Performance rewrites lack regression coverage

The existing regression test still exercises the previous na.omit() expression. Neither sum() nor the new intersect() behavior receives equivalence coverage.

Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

) {
message(
'applying ',
Expand Down
Loading