refactor(distinct-count): repaired and superseded by tested #324

[seonghobae]

Scope repair and verified successor disposition

This branch originally mixed the two distinct-nonmissing R rewrites with unrelated package-build-ignore changes, formatting-only doctrine churn, a generated Bolt performance prescription, Palette/Sentinel rewrites, and a new .markdownlint.json that disabled MD013/MD022/MD041 globally. None of those changes is required to preserve the distinct-count behavior and the Markdown configuration would weaken an unrelated documentation gate.

Normal descendants preserve branch history while restoring those authorities:

• d5278391e47761b58afecdba4a2d7b8d957ad2fe restores .Rbuildignore, .jules/bolt.md, .jules/palette.md, and .jules/sentinel.md to protected blobs and aligns both R files with canonical refactor: simplify distinct non-missing category counts #324's semantic implementation;
• c2e352995db0a365a38ad515e81e67e929441faf removes the unrelated .markdownlint.json suppression.

Fresh compare from protected master@f87c2324f1686135e57d8730c1b0b9420874f300 to exact head c2e352995db0a365a38ad515e81e67e929441faf is ahead-only (ahead_by=8, behind_by=0) and now has exactly two effective files: R/aFIPC.R and R/surveyFA.R. Those are precisely the distinct-nonmissing semantic rewrites already present in canonical #324.

#324 exact head e21ad17df4cea456d1f291e9e4b9eea3c6ce0062 contains both remaining production deltas and stronger executable equivalence evidence over numeric, NA/NaN, character, factor-with-unused-level, and constant inputs. No branch-local O(1), percentage-speedup, formatting-policy, security-policy, or Markdown-gate claim is transferred.

No predecessor checks, reviews, or approvals transfer. Closing unmerged only after scope repair and fresh verification that every remaining valid semantic/test obligation is fully present in the stronger canonical successor.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

Next included review available in 9 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 80389539-f7d1-4faa-aa56-b51b1f648384

📥 Commits

Reviewing files that changed from the base of the PR and between f87c232 and c2e3529.

📒 Files selected for processing (2)

• R/aFIPC.R
• R/surveyFA.R

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[opencode-agent]

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 8f326b57f9a8884b7b2af057e526f123f85edf89.

• Head SHA: 8f326b57f9a8884b7b2af057e526f123f85edf89

• Workflow run: 32122451823

• Workflow attempt: 1

Coverage evidence

Coverage Decision

• Result: FAIL
• Test evidence: not proven passing
• Docstring evidence: not proven passing when configured
• Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (7 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (7 files)"]
  R1 --> V1["required checks"]

Loading

[opencode-agent]

OpenCode Review Overview

• Head SHA: 8f326b57f9a8884b7b2af057e526f123f85edf89
• Workflow run: 32122451823
• Workflow attempt: 1
• Gate result: REQUEST_CHANGES (approval step)

Pull request overview

OpenCode cannot approve yet because required coverage evidence did not pass.

Review outcome

1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence

• Problem: The required coverage-evidence job result was failure, so OpenCode cannot establish approval sufficiency for this head.

• Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.

• Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports success with required evidence or explicit no-source not-applicable evidence.

• Regression test: Keep the approval branch checking needs.coverage-evidence.result == success before posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present.

• Result: REQUEST_CHANGES

• Reason: coverage-evidence result was failure, so required test/docstring evidence was not proven for current head 8f326b57f9a8884b7b2af057e526f123f85edf89.

• Head SHA: 8f326b57f9a8884b7b2af057e526f123f85edf89

• Workflow run: 32122451823

• Workflow attempt: 1

Coverage evidence

Coverage Decision

• Result: FAIL
• Test evidence: not proven passing
• Docstring evidence: not proven passing when configured
• Failure count: 1

Changed-File Evidence Map

flowchart LR
  PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
  Evidence --> S1["Changed file (7 files)"]
  S1 --> I1["repository behavior"]
  I1 --> R1["Review risk: Changed file (7 files)"]
  R1 --> V1["required checks"]

Loading